Skip to content

Commit

Permalink
resolve commented code
Browse files Browse the repository at this point in the history
  • Loading branch information
hannahkm committed Sep 24, 2024
1 parent 5e3eee0 commit 773414d
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 2 deletions.
2 changes: 1 addition & 1 deletion instrumentation/httptrace/httptrace.go
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ func FinishRequestSpan(s *tracer.Span, status int, opts ...tracer.FinishOption)
}
s.SetTag(ext.HTTPCode, statusStr)
if status >= 500 && status < 600 {
//s.SetTag(ext.Error, fmt.Errorf("%s: %s", statusStr, http.StatusText(status)))
s.SetTag(ext.Error, fmt.Errorf("%s: %s", statusStr, http.StatusText(status)))
opts = append(opts, tracer.WithError(fmt.Errorf("%s: %s", statusStr, http.StatusText(status))))
}
s.Finish(opts...)
Expand Down
1 change: 0 additions & 1 deletion instrumentation/internal/namingschematest/database_sql.go
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,6 @@ func dbSQLGenSpans(driverName string, registerOverride bool) harness.GenSpansFn
t.Fatal("unknown driver: ", driverName)
}
sqltrace.Register(driverName, dv, registerOpts...)
// defer unregister(driverName)
db, err := sqltrace.Open(driverName, dsn, openOpts...)
require.NoError(t, err)

Expand Down

0 comments on commit 773414d

Please sign in to comment.