Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tracing] Refactor internal Span Links API #6341

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

[Tracing] Refactor internal Span Links API #6341

wants to merge 4 commits into from

Commits on Nov 22, 2024

  1. SpanLink API Update: Remove DecoratedSpan property so that we only op… 

    …erate on SpanContext
    @zacharycmontoya
    zacharycmontoya committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    fbe182f View commit details
    Browse the repository at this point in the history

  2. Update Span.AddSpanLink API to accept a SpanLink instead of a Span. T… 

    …his updated interface is eaiser to use from instrumentations when there are no Spans for incoming headers, only span contexts.
    @zacharycmontoya
    zacharycmontoya committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    6c3d293 View commit details
    Browse the repository at this point in the history

  3. Updates to make the SpanLink API more similar to the Activity API: 

    - Rename the method from AddSpanLink to AddLink (this also mirrors the suggestion from OpenTelemetry Tracing API spec)
- Return the Span object instead of returning nothing
    @zacharycmontoya
    zacharycmontoya committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    2bfad3d View commit details
    Browse the repository at this point in the history

  4. Add small doc comment for new Span return

    @zacharycmontoya
    zacharycmontoya committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    4cfb37f View commit details
    Browse the repository at this point in the history