Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

creating toString for json configuration source #6307

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

creating toString for json configuration source #6307

wants to merge 2 commits into from
+19 −1

Conversation

chojomok
Copy link
Collaborator

Summary of changes

added toString() for datadog jsonConfigurationSource for startup logs

Reason for change

https://datadoghq.atlassian.net/browse/APMLP-297

Implementation details

new constructor for JsonConfigurationSource that takes an additional parameter of filename, which is saved and printed. This constructor is only used in conjunction with FromFile.

Test coverage

Other details

@chojomok chojomok requested a review from a team as a code owner November 18, 2024 21:45
@github-actions github-actions bot added the area:tracer The core tracer library (Datadog.Trace, does not include OpenTracing, native code, or integrations) label Nov 18, 2024
@andrewlock
Copy link
Member

andrewlock commented Nov 18, 2024 •
edited
Loading

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6307) - mean (72ms)  : 64, 79
     .   : milestone, 72,
    master - mean (72ms)  : 64, 79
     .   : milestone, 72,

    section CallTarget+Inlining+NGEN
    This PR (6307) - mean (1,110ms)  : 1095, 1125
     .   : milestone, 1110,
    master - mean (1,109ms)  : 1091, 1126
     .   : milestone, 1109,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6307) - mean (109ms)  : 107, 111
     .   : milestone, 109,
    master - mean (108ms)  : 105, 112
     .   : milestone, 108,

    section CallTarget+Inlining+NGEN
    This PR (6307) - mean (769ms)  : 755, 782
     .   : milestone, 769,
    master - mean (770ms)  : 752, 789
     .   : milestone, 770,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6307) - mean (92ms)  : 89, 95
     .   : milestone, 92,
    master - mean (92ms)  : 90, 94
     .   : milestone, 92,

    section CallTarget+Inlining+NGEN
    This PR (6307) - mean (723ms)  : 705, 741
     .   : milestone, 723,
    master - mean (724ms)  : 710, 739
     .   : milestone, 724,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6307) - mean (191ms)  : 186, 196
     .   : milestone, 191,
    master - mean (191ms)  : 187, 196
     .   : milestone, 191,

    section CallTarget+Inlining+NGEN
    This PR (6307) - mean (1,212ms)  : 1189, 1235
     .   : milestone, 1212,
    master - mean (1,210ms)  : 1187, 1233
     .   : milestone, 1210,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6307) - mean (277ms)  : 273, 281
     .   : milestone, 277,
    master - mean (277ms)  : 273, 282
     .   : milestone, 277,

    section CallTarget+Inlining+NGEN
    This PR (6307) - mean (946ms)  : 926, 967
     .   : milestone, 946,
    master - mean (947ms)  : 929, 964
     .   : milestone, 947,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6307) - mean (267ms)  : 263, 270
     .   : milestone, 267,
    master - mean (266ms)  : 262, 271
     .   : milestone, 266,

    section CallTarget+Inlining+NGEN
    This PR (6307) - mean (933ms)  : 918, 948
     .   : milestone, 933,
    master - mean (928ms)  : 908, 948
     .   : milestone, 928,
Loading

@datadog-ddstaging
Copy link

datadog-ddstaging bot commented Nov 18, 2024 •
edited
Loading

Datadog Report

Branch report: mohammad/datadog_json_tracer_logs
Commit report: 0691329
Test service: dd-trace-dotnet

❌ 29 Failed (0 Known Flaky), 426220 Passed, 2709 Skipped, 19h 18m 56.18s Total Time
⌛ 1 Performance Regression

❌ Failed Tests (29)

This report shows up to 5 failed tests.

  • PublicApiHasNotChanged - Datadog.Trace.Tests.PublicApiTests.DatadogTraceTests - Details

    Expand for error 
     String has differences from expected value because Public API should match the verified API. Update verified snapshot when the public API changes as appropriate. Diff:
 +305:        public override string ToString() { }

  • PublicApiHasNotChanged - Datadog.Trace.Tests.PublicApiTests.DatadogTraceTests - Details

    Expand for error 
     PublicApi has differences from expected value because Public API should match the verified API. Update verified snapshot when the public API changes as appropriate. Diff:
 +305:        public override string ToString() { }

  • PublicApiHasNotChanged - Datadog.Trace.Tests.PublicApiTests.DatadogTraceTests - Details

    Expand for error 
     PublicApi has differences from expected value because Public API should match the verified API. Update verified snapshot when the public API changes as appropriate. Diff:
 +305:        public override string ToString() { }

  • PublicApiHasNotChanged - Datadog.Trace.Tests.PublicApiTests.DatadogTraceTests - Details

    Expand for error 
     String has differences from expected value because Public API should match the verified API. Update verified snapshot when the public API changes as appropriate. Diff:
 +305:        public override string ToString() { }

  • PublicApiHasNotChanged - Datadog.Trace.Tests.PublicApiTests.DatadogTraceTests - Details

    Expand for error 
     String has differences from expected value because Public API should match the verified API. Update verified snapshot when the public API changes as appropriate. Diff:
 +305:        public override string ToString() { }

⌛ Performance Regressions vs Default Branch (1)

  • Profiler_cpu_walltime - scenarios 3.52s (+195.55ms, +6%) - Details

@andrewlock
Copy link
Member

andrewlock commented Nov 18, 2024 •
edited
Loading

Benchmarks Report for tracer 🐌

Benchmarks for #6307 compared to master:

  • 2 benchmarks are slower, with geometric mean 1.140
  • All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 7.97μs 45.4ns 327ns 0.0119 0.00398 0 5.61 KB
master StartStopWithChild netcoreapp3.1 9.92μs 54.9ns 334ns 0.0151 0.00503 0 5.8 KB
master StartStopWithChild net472 16.3μs 51.3ns 199ns 1.06 0.332 0.116 6.21 KB
#6307 StartStopWithChild net6.0 8.18μs 46.4ns 341ns 0.017 0.00426 0 5.61 KB
#6307 StartStopWithChild netcoreapp3.1 9.99μs 55ns 348ns 0.0191 0.00955 0 5.8 KB
#6307 StartStopWithChild net472 16.2μs 49.9ns 193ns 1.04 0.308 0.0811 6.21 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 487μs 394ns 1.53μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 654μs 145ns 543ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 859μs 583ns 2.26μs 0.425 0 0 3.3 KB
#6307 WriteAndFlushEnrichedTraces net6.0 474μs 273ns 1.06μs 0 0 0 2.7 KB
#6307 WriteAndFlushEnrichedTraces netcoreapp3.1 655μs 212ns 766ns 0 0 0 2.7 KB
#6307 WriteAndFlushEnrichedTraces net472 862μs 397ns 1.49μs 0.428 0 0 3.3 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 152μs 856ns 6.52μs 0.148 0 0 14.47 KB
master SendRequest netcoreapp3.1 167μs 884ns 6μs 0.169 0 0 17.27 KB
master SendRequest net472 0.000513ns 0.000275ns 0.00103ns 0 0 0 0 b
#6307 SendRequest net6.0 152μs 859ns 6.01μs 0.144 0 0 14.47 KB
#6307 SendRequest netcoreapp3.1 170μs 988ns 9μs 0.159 0 0 17.27 KB
#6307 SendRequest net472 0.000122ns 0.000122ns 0.00044ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 564μs 2.75μs 11μs 0.558 0 0 41.57 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 680μs 3.75μs 22.8μs 0.406 0 0 41.75 KB
master WriteAndFlushEnrichedTraces net472 863μs 4.32μs 18.3μs 8.56 2.57 0.428 53.28 KB
#6307 WriteAndFlushEnrichedTraces net6.0 572μs 2.55μs 9.55μs 0.576 0 0 41.55 KB
#6307 WriteAndFlushEnrichedTraces netcoreapp3.1 688μs 3.88μs 25.7μs 0.331 0 0 41.73 KB
#6307 WriteAndFlushEnrichedTraces net472 874μs 4.04μs 15.7μs 8.28 2.48 0.414 53.33 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.31μs 0.782ns 2.93ns 0.0145 0 0 1.02 KB
master ExecuteNonQuery netcoreapp3.1 1.73μs 2.21ns 8.25ns 0.0138 0 0 1.02 KB
master ExecuteNonQuery net472 2.04μs 2.42ns 9.38ns 0.156 0.00102 0 987 B
#6307 ExecuteNonQuery net6.0 1.36μs 1.17ns 4.55ns 0.0143 0 0 1.02 KB
#6307 ExecuteNonQuery netcoreapp3.1 1.75μs 2.08ns 7.78ns 0.0138 0 0 1.02 KB
#6307 ExecuteNonQuery net472 2.12μs 1.33ns 4.97ns 0.156 0.00106 0 987 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.2μs 0.724ns 2.71ns 0.0138 0 0 976 B
master CallElasticsearch netcoreapp3.1 1.51μs 1.23ns 4.6ns 0.0129 0 0 976 B
master CallElasticsearch net472 2.46μs 1.32ns 5.12ns 0.157 0 0 995 B
master CallElasticsearchAsync net6.0 1.35μs 0.535ns 2.07ns 0.0129 0 0 952 B
master CallElasticsearchAsync netcoreapp3.1 1.66μs 0.878ns 3.4ns 0.0134 0 0 1.02 KB
master CallElasticsearchAsync net472 2.75μs 1.27ns 4.76ns 0.166 0 0 1.05 KB
#6307 CallElasticsearch net6.0 1.22μs 4.26ns 16.5ns 0.0139 0 0 976 B
#6307 CallElasticsearch netcoreapp3.1 1.58μs 0.462ns 1.6ns 0.0136 0 0 976 B
#6307 CallElasticsearch net472 2.52μs 1.44ns 5.4ns 0.158 0 0 995 B
#6307 CallElasticsearchAsync net6.0 1.24μs 0.725ns 2.71ns 0.0131 0 0 952 B
#6307 CallElasticsearchAsync netcoreapp3.1 1.6μs 2.4ns 9.31ns 0.0136 0 0 1.02 KB
#6307 CallElasticsearchAsync net472 2.67μs 0.761ns 2.75ns 0.166 0 0 1.05 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.31μs 0.484ns 1.81ns 0.0131 0 0 952 B
master ExecuteAsync netcoreapp3.1 1.62μs 2.24ns 8.37ns 0.0128 0 0 952 B
master ExecuteAsync net472 1.77μs 0.485ns 1.81ns 0.145 0 0 915 B
#6307 ExecuteAsync net6.0 1.21μs 0.558ns 2.16ns 0.013 0 0 952 B
#6307 ExecuteAsync netcoreapp3.1 1.61μs 0.977ns 3.66ns 0.0129 0 0 952 B
#6307 ExecuteAsync net472 1.87μs 0.419ns 1.57ns 0.145 0 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 4.32μs 3.27ns 12.7ns 0.0323 0 0 2.31 KB
master SendAsync netcoreapp3.1 5.35μs 3.02ns 11.7ns 0.0375 0 0 2.85 KB
master SendAsync net472 7.37μs 8.02ns 31.1ns 0.493 0 0 3.12 KB
#6307 SendAsync net6.0 4.36μs 3.76ns 14.6ns 0.0327 0 0 2.31 KB
#6307 SendAsync netcoreapp3.1 5.33μs 2.14ns 8.01ns 0.0373 0 0 2.85 KB
#6307 SendAsync net472 7.4μs 1.86ns 7.2ns 0.495 0 0 3.12 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.6μs 0.785ns 2.94ns 0.0233 0 0 1.64 KB
master EnrichedLog netcoreapp3.1 2.22μs 0.93ns 3.48ns 0.0221 0 0 1.64 KB
master EnrichedLog net472 2.77μs 0.859ns 3.33ns 0.249 0 0 1.57 KB
#6307 EnrichedLog net6.0 1.54μs 0.73ns 2.73ns 0.0232 0 0 1.64 KB
#6307 EnrichedLog netcoreapp3.1 2.15μs 1.72ns 6.42ns 0.0214 0 0 1.64 KB
#6307 EnrichedLog net472 2.52μs 2.74ns 10.6ns 0.249 0 0 1.57 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 119μs 174ns 673ns 0.0596 0 0 4.28 KB
master EnrichedLog netcoreapp3.1 124μs 226ns 875ns 0 0 0 4.28 KB
master EnrichedLog net472 150μs 107ns 399ns 0.681 0.227 0 4.46 KB
#6307 EnrichedLog net6.0 119μs 173ns 668ns 0.061 0 0 4.28 KB
#6307 EnrichedLog netcoreapp3.1 124μs 98.7ns 369ns 0 0 0 4.28 KB
#6307 EnrichedLog net472 149μs 107ns 384ns 0.669 0.223 0 4.46 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 3.12μs 1.24ns 4.82ns 0.0297 0 0 2.2 KB
master EnrichedLog netcoreapp3.1 4.17μs 3.85ns 14.9ns 0.0293 0 0 2.2 KB
master EnrichedLog net472 4.91μs 4.95ns 19.2ns 0.32 0 0 2.02 KB
#6307 EnrichedLog net6.0 3.15μs 1.01ns 3.9ns 0.0315 0 0 2.2 KB
#6307 EnrichedLog netcoreapp3.1 4.12μs 11.3ns 43.7ns 0.0307 0 0 2.2 KB
#6307 EnrichedLog net472 4.81μs 1.09ns 4.07ns 0.321 0 0 2.02 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.29μs 0.403ns 1.51ns 0.016 0 0 1.14 KB
master SendReceive netcoreapp3.1 1.76μs 1ns 3.88ns 0.015 0 0 1.14 KB
master SendReceive net472 2.03μs 1.27ns 4.92ns 0.183 0 0 1.16 KB
#6307 SendReceive net6.0 1.41μs 1.11ns 4.29ns 0.0163 0 0 1.14 KB
#6307 SendReceive netcoreapp3.1 1.79μs 0.441ns 1.65ns 0.0152 0 0 1.14 KB
#6307 SendReceive net472 2.11μs 2.26ns 8.76ns 0.184 0 0 1.16 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.7μs 0.665ns 2.49ns 0.0217 0 0 1.6 KB
master EnrichedLog netcoreapp3.1 3.99μs 1.83ns 6.59ns 0.0223 0 0 1.65 KB
master EnrichedLog net472 4.34μs 1.7ns 6.12ns 0.322 0 0 2.04 KB
#6307 EnrichedLog net6.0 2.72μs 1.17ns 4.54ns 0.0217 0 0 1.6 KB
#6307 EnrichedLog netcoreapp3.1 3.85μs 1.85ns 7.17ns 0.0212 0 0 1.65 KB
#6307 EnrichedLog net472 4.33μs 1.1ns 3.96ns 0.323 0 0 2.04 KB
Benchmarks.Trace.SpanBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6307

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0 1.151 477.12 549.01
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net472 1.130 644.86 728.59

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 388ns 0.528ns 2.04ns 0.00809 0 0 576 B
master StartFinishSpan netcoreapp3.1 615ns 1.12ns 4.34ns 0.00767 0 0 576 B
master StartFinishSpan net472 643ns 1.25ns 4.82ns 0.0917 0 0 578 B
master StartFinishScope net6.0 477ns 0.672ns 2.6ns 0.0099 0 0 696 B
master StartFinishScope netcoreapp3.1 639ns 1.12ns 4.18ns 0.00921 0 0 696 B
master StartFinishScope net472 847ns 1.27ns 4.91ns 0.105 0 0 658 B
#6307 StartFinishSpan net6.0 391ns 0.822ns 3.18ns 0.00803 0 0 576 B
#6307 StartFinishSpan netcoreapp3.1 568ns 0.85ns 3.29ns 0.00776 0 0 576 B
#6307 StartFinishSpan net472 728ns 2.14ns 8.3ns 0.0916 0 0 578 B
#6307 StartFinishScope net6.0 549ns 1.05ns 4.08ns 0.00968 0 0 696 B
#6307 StartFinishScope netcoreapp3.1 670ns 1.26ns 4.87ns 0.0095 0 0 696 B
#6307 StartFinishScope net472 873ns 2.69ns 10.4ns 0.104 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 594ns 0.832ns 3.22ns 0.00963 0 0 696 B
master RunOnMethodBegin netcoreapp3.1 857ns 1.45ns 5.61ns 0.00952 0 0 696 B
master RunOnMethodBegin net472 1.09μs 1.86ns 7.22ns 0.104 0 0 658 B
#6307 RunOnMethodBegin net6.0 638ns 1.57ns 6.07ns 0.00992 0 0 696 B
#6307 RunOnMethodBegin netcoreapp3.1 886ns 0.687ns 2.66ns 0.00932 0 0 696 B
#6307 RunOnMethodBegin net472 1.08μs 1.32ns 5.13ns 0.104 0 0 658 B

@andrewlock
Copy link
Member

Throughput/Crank Report ⚡

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6307) (11.064M)   : 0, 11064474
    master (11.023M)   : 0, 11022833
    benchmarks/2.9.0 (11.033M)   : 0, 11032866

    section Automatic
    This PR (6307) (7.297M)   : 0, 7297250
    master (7.260M)   : 0, 7260053
    benchmarks/2.9.0 (7.786M)   : 0, 7785853

    section Trace stats
    master (7.629M)   : 0, 7628683

    section Manual
    master (11.013M)   : 0, 11013178

    section Manual + Automatic
    This PR (6307) (6.784M)   : 0, 6783532
    master (6.716M)   : 0, 6715780

    section DD_TRACE_ENABLED=0
    master (10.359M)   : 0, 10358723
Loading 
gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6307) (9.461M)   : 0, 9460985
    master (9.545M)   : 0, 9544523
    benchmarks/2.9.0 (9.495M)   : 0, 9494821

    section Automatic
    This PR (6307) (6.302M)   : 0, 6301743
    master (6.327M)   : 0, 6326537

    section Trace stats
    master (6.647M)   : 0, 6647295

    section Manual
    master (9.451M)   : 0, 9450807

    section Manual + Automatic
    This PR (6307) (5.841M)   : 0, 5840573
    master (5.878M)   : 0, 5878431

    section DD_TRACE_ENABLED=0
    master (8.854M)   : 0, 8854495
Loading 
gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6307) (9.657M)   : 0, 9656914
    master (10.335M)   : 0, 10334663
    benchmarks/2.9.0 (10.020M)   : 0, 10019592

    section Automatic
    This PR (6307) (6.052M)   : crit ,0, 6051890
    master (6.679M)   : 0, 6679257
    benchmarks/2.9.0 (7.255M)   : 0, 7255257

    section Trace stats
    master (7.478M)   : 0, 7478083

    section Manual
    master (10.372M)   : 0, 10371575

    section Manual + Automatic
    This PR (6307) (5.746M)   : crit ,0, 5746132
    master (6.184M)   : 0, 6184431

    section DD_TRACE_ENABLED=0
    master (9.494M)   : 0, 9493826
Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area:tracer The core tracer library (Datadog.Trace, does not include OpenTracing, native code, or integrations)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chojomok @andrewlock