[ASM] Send header values as string to the WAF #6116
Closed
+795
−781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snapshots difference summaryThe following differences have been observed in committed snapshots. It is meant to help the reviewer. 81 occurrences of : - _dd.appsec.fp.http.header: hdr-0000000000--1-4740ae63,
- _dd.appsec.fp.http.network: net-0-1000000000,
+ _dd.appsec.fp.http.header: hdr-0000000000-3626b5f8-1-4740ae63,
+ _dd.appsec.fp.http.network: net-1-1000000000,
6 occurrences of : - _dd.appsec.fp.http.header: hdr-0100000001--3-bf93958a,
- _dd.appsec.fp.http.network: net-0-1000000000,
+ _dd.appsec.fp.http.header: hdr-0100000001-3626b5f8-3-bf93958a,
+ _dd.appsec.fp.http.network: net-1-1000000000,
17 occurrences of : - _dd.appsec.fp.http.header: hdr-0100000100--2-da57b738,
- _dd.appsec.fp.http.network: net-0-1000000000,
+ _dd.appsec.fp.http.header: hdr-0100000100-3626b5f8-2-da57b738,
+ _dd.appsec.fp.http.network: net-1-1000000000,
14 occurrences of : - _dd.appsec.fp.http.header: hdr-0000000001--3-bf93958a,
- _dd.appsec.fp.http.network: net-0-1000000000,
+ _dd.appsec.fp.http.header: hdr-0000000001-3626b5f8-3-bf93958a,
+ _dd.appsec.fp.http.network: net-1-1000000000,
17 occurrences of : - _dd.appsec.fp.http.header: hdr-0000000100--2-da57b738,
- _dd.appsec.fp.http.network: net-0-1000000000,
+ _dd.appsec.fp.http.header: hdr-0000000100-3626b5f8-2-da57b738,
+ _dd.appsec.fp.http.network: net-1-1000000000,
26 occurrences of : - _dd.appsec.fp.http.header: hdr-0000000100--3-4d739311,
- _dd.appsec.fp.http.network: net-0-1000000000,
+ _dd.appsec.fp.http.header: hdr-0000000100-3626b5f8-3-4d739311,
+ _dd.appsec.fp.http.network: net-1-1000000000,
8 occurrences of : - _dd.appsec.fp.http.header: hdr-0000000001--5-6cdcf2fe,
- _dd.appsec.fp.http.network: net-0-1000000000,
+ _dd.appsec.fp.http.header: hdr-0000000001-3626b5f8-5-6cdcf2fe,
+ _dd.appsec.fp.http.network: net-1-1000000000,
25 occurrences of : - _dd.appsec.fp.http.header: hdr-0000000100--5-07490af2,
- _dd.appsec.fp.http.network: net-0-1000000000,
+ _dd.appsec.fp.http.header: hdr-0000000100-3626b5f8-5-07490af2,
+ _dd.appsec.fp.http.network: net-1-1000000000,
1 occurrences of : - _dd.appsec.s.req.headers: [{"connection":[[[8]],{"len":1}],"content-length":[[[8]],{"len":1}],"content-type":[[[8]],{"len":1}],"host":[[[8]],{"len":1}],"user-agent":[[[8]],{"len":1}],"x-forwarded-for":[[[8]],{"len":1}]}],
+ _dd.appsec.s.req.headers: [{"connection":[8],"content-length":[8],"content-type":[8],"host":[8],"user-agent":[8],"x-forwarded-for":[8]}],
1 occurrences of : - _dd.appsec.s.req.headers: [{"connection":[[[8]],{"len":1}],"content-length":[[[8]],{"len":1}],"content-type":[[[8]],{"len":1}],"host":[[[8]],{"len":1}],"user-agent":[[[8]],{"len":1}],"x-forwarded-for":[[[8]],{"len":1}]}],
- _dd.appsec.s.res.headers: [{"content-type":[[[8]],{"len":1}]}],
+ _dd.appsec.s.req.headers: [{"connection":[8],"content-length":[8],"content-type":[8],"host":[8],"user-agent":[8],"x-forwarded-for":[8]}],
+ _dd.appsec.s.res.headers: [{"content-type":[8]}],
1 occurrences of : - _dd.appsec.s.req.headers: [{"connection":[[[8]],{"len":1}],"content-length":[[[8]],{"len":1}],"content-type":[[[8]],{"len":1}],"host":[[[8]],{"len":1}],"user-agent":[[[8]],{"len":1}],"x-forwarded-for":[[[8]],{"len":1}]}],
+ _dd.appsec.s.req.headers: [{"connection":[8],"content-length":[8],"content-type":[8],"host":[8],"user-agent":[8],"x-forwarded-for":[8]}],
[...]
- _dd.appsec.s.res.headers: [{"content-type":[[[8]],{"len":1}]}],
+ _dd.appsec.s.res.headers: [{"content-type":[8]}],
1 occurrences of : - _dd.appsec.s.req.headers: [{"content-length":[[[8]],{"len":1}],"content-type":[[[8]],{"len":1}],"host":[[[8]],{"len":1}],"user-agent":[[[8]],{"len":1}],"x-forwarded-for":[[[8]],{"len":1}]}],
+ _dd.appsec.s.req.headers: [{"content-length":[8],"content-type":[8],"host":[8],"user-agent":[8],"x-forwarded-for":[8]}],
2 occurrences of : - _dd.appsec.s.req.headers: [{"content-length":[[[8]],{"len":1}],"content-type":[[[8]],{"len":1}],"host":[[[8]],{"len":1}],"user-agent":[[[8]],{"len":1}],"x-forwarded-for":[[[8]],{"len":1}]}],
+ _dd.appsec.s.req.headers: [{"content-length":[8],"content-type":[8],"host":[8],"user-agent":[8],"x-forwarded-for":[8]}],
[...]
- _dd.appsec.s.res.headers: [{"content-type":[[[8]],{"len":1}]}],
+ _dd.appsec.s.res.headers: [{"content-type":[8]}],
5 occurrences of : - _dd.appsec.fp.http.header: hdr-0100000000--1-4740ae63,
- _dd.appsec.fp.http.network: net-0-1000000000,
- _dd.appsec.json: {"triggers":[{"rule":{"id":"ublock","name":"Hello","tags":{"category":"attack_attempt","type":"security_scanner"}},"rule_matches":[{"operator":"match_regex","operator_value":"hello","parameters":[{"address":"server.request.headers.no_cookies","highlight":["hello"],"key_path":["user-agent","0"],"value":"mistake not... hello/v"}]}]}]},
+ _dd.appsec.fp.http.header: hdr-0100000000-197358b8-1-4740ae63,
+ _dd.appsec.fp.http.network: net-1-1000000000,
+ _dd.appsec.json: {"triggers":[{"rule":{"id":"ublock","name":"Hello","tags":{"category":"attack_attempt","type":"security_scanner"}},"rule_matches":[{"operator":"match_regex","operator_value":"hello","parameters":[{"address":"server.request.headers.no_cookies","highlight":["hello"],"key_path":["user-agent"],"value":"mistake not... hello/v"}]}]}]},
20 occurrences of : - _dd.appsec.fp.http.network: net-0-1000000000,
+ _dd.appsec.fp.http.network: <NetworkPrint>,
15 occurrences of : - _dd.appsec.fp.http.network: net-0-1000000000,
- _dd.appsec.json: {"triggers":[{"rule":{"id":"tst-037-009","name":"Test block on response header","tags":{"category":"attack_attempt","type":"lfi"}},"rule_matches":[{"operator":"match_regex","operator_value":"en-us|krypton","parameters":[{"address":"server.response.headers.no_cookies","highlight":["krypton"],"key_path":["content-language","0"],"value":"krypton"}]}]}]},
+ _dd.appsec.fp.http.network: <NetworkPrint>,
+ _dd.appsec.json: {"triggers":[{"rule":{"id":"tst-037-009","name":"Test block on response header","tags":{"category":"attack_attempt","type":"lfi"}},"rule_matches":[{"operator":"match_regex","operator_value":"en-us|krypton","parameters":[{"address":"server.response.headers.no_cookies","highlight":["krypton"],"key_path":["content-language"],"value":"krypton"}]}]}]},
1 occurrences of : - _dd.appsec.fp.http.header: hdr-0000000010--1-4740ae63,
- _dd.appsec.fp.http.network: net-0-1000000000,
+ _dd.appsec.fp.http.header: hdr-0000000010-3626b5f8-1-4740ae63,
+ _dd.appsec.fp.http.network: net-1-1000000000,
20 occurrences of : - _dd.appsec.fp.http.header: hdr-0000000000--1-4740ae63,
- _dd.appsec.fp.http.network: net-0-1000000000,
- _dd.appsec.json: {"triggers":[{"rule":{"id":"ublock","name":"Hello","tags":{"category":"attack_attempt","type":"security_scanner"}},"rule_matches":[{"operator":"match_regex","operator_value":"hello","parameters":[{"address":"server.request.headers.no_cookies","highlight":["hello"],"key_path":["user-agent","0"],"value":"mistake not... hello/v"}]}]}]},
+ _dd.appsec.fp.http.header: hdr-0000000000-197358b8-1-4740ae63,
+ _dd.appsec.fp.http.network: net-1-1000000000,
+ _dd.appsec.json: {"triggers":[{"rule":{"id":"ublock","name":"Hello","tags":{"category":"attack_attempt","type":"security_scanner"}},"rule_matches":[{"operator":"match_regex","operator_value":"hello","parameters":[{"address":"server.request.headers.no_cookies","highlight":["hello"],"key_path":["user-agent"],"value":"mistake not... hello/v"}]}]}]},
1 occurrences of : - _dd.appsec.json: {"triggers":[{"rule":{"id":"new-test-non-blocking","name":"Datadog test scanner - NON blocking version: user-agent","tags":{"category":"attack_attempt","type":"attack_tool"}},"rule_matches":[{"operator":"match_regex","operator_value":"^dd-test-scanner-log-block(?:$|/|\\s)","parameters":[{"address":"server.request.headers.no_cookies","highlight":["dd-test-scanner-log-block"],"key_path":["user-agent","0"],"value":"dd-test-scanner-log-block"}]}]}]},
+ _dd.appsec.json: {"triggers":[{"rule":{"id":"new-test-non-blocking","name":"Datadog test scanner - NON blocking version: user-agent","tags":{"category":"attack_attempt","type":"attack_tool"}},"rule_matches":[{"operator":"match_regex","operator_value":"^dd-test-scanner-log-block(?:$|/|\\s)","parameters":[{"address":"server.request.headers.no_cookies","highlight":["dd-test-scanner-log-block"],"key_path":["user-agent"],"value":"dd-test-scanner-log-block"}]}]}]},
2 occurrences of : - _dd.appsec.json: {"triggers":[{"rule":{"id":"ua0-600-56x","name":"Datadog test scanner - blocking version: user-agent","tags":{"category":"attack_attempt","type":"attack_tool"}},"rule_matches":[{"operator":"match_regex","operator_value":"^dd-test-scanner-log-block(?:$|/|\\s)","parameters":[{"address":"server.request.headers.no_cookies","highlight":["dd-test-scanner-log-block"],"key_path":["user-agent","0"],"value":"dd-test-scanner-log-block"}]}]}]},
+ _dd.appsec.json: {"triggers":[{"rule":{"id":"ua0-600-56x","name":"Datadog test scanner - blocking version: user-agent","tags":{"category":"attack_attempt","type":"attack_tool"}},"rule_matches":[{"operator":"match_regex","operator_value":"^dd-test-scanner-log-block(?:$|/|\\s)","parameters":[{"address":"server.request.headers.no_cookies","highlight":["dd-test-scanner-log-block"],"key_path":["user-agent"],"value":"dd-test-scanner-log-block"}]}]}]},
3 occurrences of : - _dd.appsec.s.req.headers: [{"content-length":[[[8]],{"len":1}],"content-type":[[[8]],{"len":1}],"expect":[[[8]],{"len":1}],"host":[[[8]],{"len":1}],"traceparent":[[[8]],{"len":1}],"tracestate":[[[8]],{"len":1}],"user-agent":[[[8]],{"len":1}],"x-datadog-parent-id":[[[8]],{"len":1}],"x-datadog-sampling-priority":[[[8]],{"len":1}],"x-datadog-tags":[[[8]],{"len":1}],"x-datadog-trace-id":[[[8]],{"len":1}],"x-forwarded-for":[[[8]],{"len":1}]}],
+ _dd.appsec.s.req.headers: [{"content-length":[8],"content-type":[8],"expect":[8],"host":[8],"traceparent":[8],"tracestate":[8],"user-agent":[8],"x-datadog-parent-id":[8],"x-datadog-sampling-priority":[8],"x-datadog-tags":[8],"x-datadog-trace-id":[8],"x-forwarded-for":[8]}],
[...]
- _dd.appsec.s.res.headers: [{"cache-control":[[[8]],{"len":1}],"content-length":[[[8]],{"len":1}],"content-type":[[[8]],{"len":1}],"expires":[[[8]],{"len":1}],"pragma":[[[8]],{"len":1}],"server":[[[8]],{"len":1}],"x-aspnet-version":[[[8]],{"len":1}]}],
+ _dd.appsec.s.res.headers: [{"cache-control":[8],"content-length":[8],"content-type":[8],"expires":[8],"pragma":[8],"server":[8],"x-aspnet-version":[8]}],
1 occurrences of : - _dd.appsec.fp.http.header: hdr-0100000100--3-4d739311,
- _dd.appsec.fp.http.network: net-0-1000000000,
+ _dd.appsec.fp.http.header: hdr-0100000100-3626b5f8-3-4d739311,
+ _dd.appsec.fp.http.network: net-1-1000000000,
15 occurrences of : - _dd.appsec.fp.http.header: hdr-0000000000--3-98425651,
- _dd.appsec.fp.http.network: net-0-1000000000,
- _dd.appsec.json: {"triggers":[{"rule":{"id":"ublock","name":"Hello","tags":{"category":"attack_attempt","type":"security_scanner"}},"rule_matches":[{"operator":"match_regex","operator_value":"hello","parameters":[{"address":"server.request.headers.no_cookies","highlight":["hello"],"key_path":["user-agent","0"],"value":"mistake not... hello/v"}]}]}]},
+ _dd.appsec.fp.http.header: hdr-0000000000-197358b8-3-98425651,
+ _dd.appsec.fp.http.network: net-1-1000000000,
+ _dd.appsec.json: {"triggers":[{"rule":{"id":"ublock","name":"Hello","tags":{"category":"attack_attempt","type":"security_scanner"}},"rule_matches":[{"operator":"match_regex","operator_value":"hello","parameters":[{"address":"server.request.headers.no_cookies","highlight":["hello"],"key_path":["user-agent"],"value":"mistake not... hello/v"}]}]}]},
54 occurrences of : - _dd.appsec.fp.http.header: hdr-0000000000--3-98425651,
- _dd.appsec.fp.http.network: net-0-1000000000,
+ _dd.appsec.fp.http.header: hdr-0000000000-3626b5f8-3-98425651,
+ _dd.appsec.fp.http.network: net-1-1000000000,
2 occurrences of : - _dd.appsec.fp.http.header: hdr-0100000100--5-07490af2,
- _dd.appsec.fp.http.network: net-0-1000000000,
+ _dd.appsec.fp.http.header: hdr-0100000100-3626b5f8-5-07490af2,
+ _dd.appsec.fp.http.network: net-1-1000000000,
5 occurrences of : - _dd.appsec.fp.http.header: hdr-0000000000--3-98425651,
- _dd.appsec.fp.http.network: net-0-1000000000,
- _dd.appsec.json: {"triggers":[{"rule":{"id":"tst-037-009","name":"Test block on response header","tags":{"category":"attack_attempt","type":"lfi"}},"rule_matches":[{"operator":"match_regex","operator_value":"en-us|krypton","parameters":[{"address":"server.response.headers.no_cookies","highlight":["krypton"],"key_path":["content-language","0"],"value":"krypton"}]}]}]},
+ _dd.appsec.fp.http.header: hdr-0000000000-3626b5f8-3-98425651,
+ _dd.appsec.fp.http.network: net-1-1000000000,
+ _dd.appsec.json: {"triggers":[{"rule":{"id":"tst-037-009","name":"Test block on response header","tags":{"category":"attack_attempt","type":"lfi"}},"rule_matches":[{"operator":"match_regex","operator_value":"en-us|krypton","parameters":[{"address":"server.response.headers.no_cookies","highlight":["krypton"],"key_path":["content-language"],"value":"krypton"}]}]}]},
2 occurrences of : - _dd.appsec.s.req.headers: [{"content-length":[[[8]],{"len":1}],"content-type":[[[8]],{"len":1}],"expect":[[[8]],{"len":1}],"host":[[[8]],{"len":1}],"traceparent":[[[8]],{"len":1}],"tracestate":[[[8]],{"len":1}],"user-agent":[[[8]],{"len":1}],"x-datadog-parent-id":[[[8]],{"len":1}],"x-datadog-sampling-priority":[[[8]],{"len":1}],"x-datadog-tags":[[[8]],{"len":1}],"x-datadog-trace-id":[[[8]],{"len":1}],"x-forwarded-for":[[[8]],{"len":1}]}],
+ _dd.appsec.s.req.headers: [{"content-length":[8],"content-type":[8],"expect":[8],"host":[8],"traceparent":[8],"tracestate":[8],"user-agent":[8],"x-datadog-parent-id":[8],"x-datadog-sampling-priority":[8],"x-datadog-tags":[8],"x-datadog-trace-id":[8],"x-forwarded-for":[8]}],
[...]
- _dd.appsec.s.res.headers: [{"cache-control":[[[8]],{"len":1}],"content-type":[[[8]],{"len":1}],"server":[[[8]],{"len":1}],"x-aspnetmvc-version":[[[8]],{"len":1}],"x-aspnet-version":[[[8]],{"len":1}]}],
+ _dd.appsec.s.res.headers: [{"cache-control":[8],"content-type":[8],"server":[8],"x-aspnetmvc-version":[8],"x-aspnet-version":[8]}],
1 occurrences of : - _dd.appsec.s.req.headers: [{"content-length":[[[8]],{"len":1}],"content-type":[[[8]],{"len":1}],"expect":[[[8]],{"len":1}],"host":[[[8]],{"len":1}],"traceparent":[[[8]],{"len":1}],"tracestate":[[[8]],{"len":1}],"user-agent":[[[8]],{"len":1}],"x-datadog-parent-id":[[[8]],{"len":1}],"x-datadog-sampling-priority":[[[8]],{"len":1}],"x-datadog-tags":[[[8]],{"len":1}],"x-datadog-trace-id":[[[8]],{"len":1}],"x-forwarded-for":[[[8]],{"len":1}]}],
+ _dd.appsec.s.req.headers: [{"content-length":[8],"content-type":[8],"expect":[8],"host":[8],"traceparent":[8],"tracestate":[8],"user-agent":[8],"x-datadog-parent-id":[8],"x-datadog-sampling-priority":[8],"x-datadog-tags":[8],"x-datadog-trace-id":[8],"x-forwarded-for":[8]}],
[...]
- _dd.appsec.s.res.headers: [{"cache-control":[[[8]],{"len":1}],"content-type":[[[8]],{"len":1}],"x-aspnet-version":[[[8]],{"len":1}]}],
+ _dd.appsec.s.res.headers: [{"cache-control":[8],"content-type":[8],"x-aspnet-version":[8]}],
3 occurrences of : - _dd.appsec.fp.http.header: hdr-0100000000--1-4740ae63,
- _dd.appsec.fp.http.network: net-0-1000000000,
+ _dd.appsec.fp.http.header: hdr-0100000000-3626b5f8-1-4740ae63,
+ _dd.appsec.fp.http.network: net-1-1000000000,
2 occurrences of : - _dd.appsec.fp.http.header: hdr-0100000000--3-98425651,
- _dd.appsec.fp.http.network: net-0-1000000000,
+ _dd.appsec.fp.http.header: hdr-0100000000-3626b5f8-3-98425651,
+ _dd.appsec.fp.http.network: net-1-1000000000,
6 occurrences of : - _dd.appsec.json: {"triggers":[{"rule":{"id":"ua0-600-16x","name":"SQL power injector","tags":{"category":"attack_attempt","type":"attack_tool"}},"rule_matches":[{"operator":"match_regex","operator_value":"sql power injector","parameters":[{"address":"server.request.headers.no_cookies","highlight":["sql power injector"],"key_path":["user-agent","0"],"value":"Mistake Not... (sql power injector)"}]}]}]},
+ _dd.appsec.json: {"triggers":[{"rule":{"id":"ua0-600-16x","name":"SQL power injector","tags":{"category":"attack_attempt","type":"attack_tool"}},"rule_matches":[{"operator":"match_regex","operator_value":"sql power injector","parameters":[{"address":"server.request.headers.no_cookies","highlight":["sql power injector"],"key_path":["user-agent"],"value":"Mistake Not... (sql power injector)"}]}]}]},
3 occurrences of : - _dd.appsec.json: {"triggers":[{"rule":{"id":"crs-913-110","name":"Acunetix","tags":{"category":"attack_attempt","type":"commercial_scanner"}},"rule_matches":[{"operator":"phrase_match","operator_value":"","parameters":[{"address":"server.request.headers.no_cookies","highlight":["acunetix-product"],"key_path":["user-agent","0"],"value":"mistake not... acunetix-product"}]}]}]},
+ _dd.appsec.json: {"triggers":[{"rule":{"id":"crs-913-110","name":"Acunetix","tags":{"category":"attack_attempt","type":"commercial_scanner"}},"rule_matches":[{"operator":"phrase_match","operator_value":"","parameters":[{"address":"server.request.headers.no_cookies","highlight":["acunetix-product"],"key_path":["user-agent"],"value":"mistake not... acunetix-product"}]}]}]},
|
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing the following branches/commits: Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6116) - mean (70ms) : 66, 74
. : milestone, 70,
master - mean (70ms) : 67, 72
. : milestone, 70,
section CallTarget+Inlining+NGEN
This PR (6116) - mean (1,113ms) : 1090, 1137
. : milestone, 1113,
master - mean (1,107ms) : 1085, 1130
. : milestone, 1107,
gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6116) - mean (108ms) : 105, 112
. : milestone, 108,
master - mean (109ms) : 106, 111
. : milestone, 109,
section CallTarget+Inlining+NGEN
This PR (6116) - mean (771ms) : 755, 786
. : milestone, 771,
master - mean (769ms) : 751, 787
. : milestone, 769,
gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6116) - mean (92ms) : 89, 95
. : milestone, 92,
master - mean (91ms) : 89, 94
. : milestone, 91,
section CallTarget+Inlining+NGEN
This PR (6116) - mean (728ms) : 714, 742
. : milestone, 728,
master - mean (726ms) : 712, 740
. : milestone, 726,
gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6116) - mean (189ms) : 186, 193
. : milestone, 189,
master - mean (189ms) : 186, 191
. : milestone, 189,
section CallTarget+Inlining+NGEN
This PR (6116) - mean (1,201ms) : 1172, 1229
. : milestone, 1201,
master - mean (1,195ms) : 1171, 1219
. : milestone, 1195,
gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6116) - mean (275ms) : 271, 278
. : milestone, 275,
master - mean (274ms) : 268, 279
. : milestone, 274,
section CallTarget+Inlining+NGEN
This PR (6116) - mean (944ms) : 926, 961
. : milestone, 944,
master - mean (944ms) : 929, 958
. : milestone, 944,
gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6116) - mean (263ms) : 260, 267
. : milestone, 263,
master - mean (262ms) : 258, 266
. : milestone, 262,
section CallTarget+Inlining+NGEN
This PR (6116) - mean (926ms) : 910, 943
. : milestone, 926,
master - mean (925ms) : 903, 947
. : milestone, 925,
|
NachoEchevarria
changed the title
Datadog ReportBranch report: ❌ 2 Failed (1 Known Flaky), 470989 Passed, 3292 Skipped, 29h 42m 45.1s Total Time ❌ Failed Tests (2)
|
Benchmarks Report for appsec 🐌Benchmarks for #6116 compared to master:
The following thresholds were used for comparing the benchmark speeds:
Allocation changes below 0.5% are ignored. Benchmark detailsBenchmarks.Trace.Asm.AppSecBodyBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.Asm.AppSecEncoderBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.Asm.AppSecWafBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.Iast.StringAspectsBenchmark - Same speed ✔️ Fewer allocations 🎉
|
| Benchmark | Base Allocated | Diff Allocated | Change | Change % |
|---|---|---|---|---|
| Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑net472 | 59.71 KB | 58.79 KB | -920 B | -1.54% |
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | StringConcatBenchmark |
net6.0 | 62μs | 750ns | 7.5μs | 0 | 0 | 0 | 43.44 KB |
| master | StringConcatBenchmark |
netcoreapp3.1 | 54.2μs | 314ns | 2.51μs | 0 | 0 | 0 | 42.64 KB |
| master | StringConcatBenchmark |
net472 | 37.1μs | 82.1ns | 284ns | 0 | 0 | 0 | 59.71 KB |
| master | StringConcatAspectBenchmark |
net6.0 | 276μs | 5.74μs | 56μs | 0 | 0 | 0 | 254.9 KB |
| master | StringConcatAspectBenchmark |
netcoreapp3.1 | 331μs | 2.11μs | 20.1μs | 0 | 0 | 0 | 252.79 KB |
| master | StringConcatAspectBenchmark |
net472 | 293μs | 6.96μs | 67.4μs | 0 | 0 | 0 | 278.53 KB |
| #6116 | StringConcatBenchmark |
net6.0 | 61.6μs | 756ns | 7.48μs | 0 | 0 | 0 | 43.44 KB |
| #6116 | StringConcatBenchmark |
netcoreapp3.1 | 61.5μs | 844ns | 8.31μs | 0 | 0 | 0 | 42.64 KB |
| #6116 | StringConcatBenchmark |
net472 | 37.1μs | 62.9ns | 218ns | 0 | 0 | 0 | 58.79 KB |
| #6116 | StringConcatAspectBenchmark |
net6.0 | 320μs | 1.74μs | 10.7μs | 0 | 0 | 0 | 255.53 KB |
| #6116 | StringConcatAspectBenchmark |
netcoreapp3.1 | 347μs | 2μs | 16.8μs | 0 | 0 | 0 | 252.56 KB |
| #6116 | StringConcatAspectBenchmark |
net472 | 287μs | 5.72μs | 55.5μs | 0 | 0 | 0 | 278.53 KB |
Benchmarks Report for tracer 🐌Benchmarks for #6116 compared to master:
The following thresholds were used for comparing the benchmark speeds:
Allocation changes below 0.5% are ignored. Benchmark detailsBenchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.SpanBenchmark - Faster 🎉 Same allocations ✔️
|
| Benchmark | base/diff | Base Median (ns) | Diff Median (ns) | Modality |
|---|---|---|---|---|
| Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0 | 1.133 | 544.75 | 480.80 |
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | StartFinishSpan |
net6.0 | 403ns | 0.194ns | 0.752ns | 0.00816 | 0 | 0 | 576 B |
| master | StartFinishSpan |
netcoreapp3.1 | 574ns | 0.486ns | 1.75ns | 0.0077 | 0 | 0 | 576 B |
| master | StartFinishSpan |
net472 | 717ns | 0.916ns | 3.43ns | 0.0916 | 0 | 0 | 578 B |
| master | StartFinishScope |
net6.0 | 545ns | 0.305ns | 1.18ns | 0.00987 | 0 | 0 | 696 B |
| master | StartFinishScope |
netcoreapp3.1 | 696ns | 0.34ns | 1.27ns | 0.00944 | 0 | 0 | 696 B |
| master | StartFinishScope |
net472 | 988ns | 1.13ns | 4.38ns | 0.104 | 0 | 0 | 658 B |
| #6116 | StartFinishSpan |
net6.0 | 405ns | 0.257ns | 0.996ns | 0.00814 | 0 | 0 | 576 B |
| #6116 | StartFinishSpan |
netcoreapp3.1 | 626ns | 0.395ns | 1.53ns | 0.00774 | 0 | 0 | 576 B |
| #6116 | StartFinishSpan |
net472 | 679ns | 0.785ns | 3.04ns | 0.0918 | 0 | 0 | 578 B |
| #6116 | StartFinishScope |
net6.0 | 481ns | 0.334ns | 1.29ns | 0.00965 | 0 | 0 | 696 B |
| #6116 | StartFinishScope |
netcoreapp3.1 | 699ns | 0.305ns | 1.18ns | 0.00947 | 0 | 0 | 696 B |
| #6116 | StartFinishScope |
net472 | 907ns | 1.31ns | 5.07ns | 0.105 | 0 | 0 | 658 B |
Benchmarks.Trace.TraceAnnotationsBenchmark - Faster 🎉 Same allocations ✔️
Faster 🎉 in #6116
Benchmark
base/diff
Base Median (ns)
Diff Median (ns)
Modality
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0
1.118
679.78
608.01
| Benchmark | base/diff | Base Median (ns) | Diff Median (ns) | Modality |
|---|---|---|---|---|
| Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0 | 1.118 | 679.78 | 608.01 |
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | RunOnMethodBegin |
net6.0 | 680ns | 0.402ns | 1.5ns | 0.0099 | 0 | 0 | 696 B |
| master | RunOnMethodBegin |
netcoreapp3.1 | 958ns | 0.33ns | 1.28ns | 0.00943 | 0 | 0 | 696 B |
| master | RunOnMethodBegin |
net472 | 1.18μs | 0.506ns | 1.89ns | 0.104 | 0 | 0 | 658 B |
| #6116 | RunOnMethodBegin |
net6.0 | 608ns | 0.223ns | 0.863ns | 0.00955 | 0 | 0 | 696 B |
| #6116 | RunOnMethodBegin |
netcoreapp3.1 | 949ns | 0.433ns | 1.68ns | 0.00947 | 0 | 0 | 696 B |
| #6116 | RunOnMethodBegin |
net472 | 1.15μs | 1.33ns | 5.15ns | 0.104 | 0 | 0 | 658 B |
Throughput/Crank Report ⚡Throughput results for AspNetCoreSimpleController comparing the following branches/commits: Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red. Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards! gantt
title Throughput Linux x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6116) (11.148M) : 0, 11147615
master (11.155M) : 0, 11155081
benchmarks/2.9.0 (11.081M) : 0, 11080577
section Automatic
This PR (6116) (7.289M) : 0, 7289168
master (7.305M) : 0, 7305110
benchmarks/2.9.0 (7.732M) : 0, 7732233
section Trace stats
master (7.702M) : 0, 7701988
section Manual
master (11.059M) : 0, 11059270
section Manual + Automatic
This PR (6116) (6.780M) : 0, 6780180
master (6.814M) : 0, 6814282
section DD_TRACE_ENABLED=0
master (10.361M) : 0, 10360619
gantt
title Throughput Linux arm64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6116) (9.609M) : 0, 9608880
master (9.579M) : 0, 9579150
benchmarks/2.9.0 (9.798M) : 0, 9798067
section Automatic
This PR (6116) (6.560M) : 0, 6559994
master (6.566M) : 0, 6565557
section Trace stats
master (6.905M) : 0, 6904856
section Manual
master (9.517M) : 0, 9517110
section Manual + Automatic
This PR (6116) (6.100M) : 0, 6100146
master (6.276M) : 0, 6275958
section DD_TRACE_ENABLED=0
master (9.030M) : 0, 9029662
gantt
title Throughput Windows x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6116) (10.141M) : 0, 10140587
master (9.971M) : 0, 9971352
benchmarks/2.9.0 (10.067M) : 0, 10067315
section Automatic
This PR (6116) (6.629M) : 0, 6629329
master (6.722M) : 0, 6722260
benchmarks/2.9.0 (7.552M) : 0, 7552193
section Trace stats
master (7.411M) : 0, 7411045
section Manual
master (10.212M) : 0, 10212002
section Manual + Automatic
This PR (6116) (6.288M) : 0, 6288346
master (6.485M) : 0, 6485151
section DD_TRACE_ENABLED=0
master (9.627M) : 0, 9627344
|
anna-git
approved these changes
Oct 8, 2024
daniel-romano-DD
approved these changes
Oct 8, 2024
NachoEchevarria
changed the title
NachoEchevarria
changed the title
lucaspimentel
approved these changes
Oct 9, 2024
NachoEchevarria
force-pushed
the
nacho/SendUserAgentHeaderAsStringToTheWAF
branch
from
7d791db
to
39557e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Util this PR, we woudl store the request headers in a array of strings and we would send that array to the WAF. When generating fingerprints, the WAF does not accept arrays of strings but a single string, so, when we have a single header value, we store it in a string instead of in an array of strings with a single value inside the array.
This change has fixed some problems related to the fingerprint generation, which has derived in a large amount of updated snapshots.
Reason for change
Implementation details
Test coverage
Other details