[Profiler] Allow tests for .NET Framework #5948
Open
+1,521
−106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing the following branches/commits: Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5948) - mean (70ms) : 68, 72
. : milestone, 70,
master - mean (70ms) : 67, 73
. : milestone, 70,
section CallTarget+Inlining+NGEN
This PR (5948) - mean (1,116ms) : 1088, 1145
. : milestone, 1116,
master - mean (1,111ms) : 1087, 1134
. : milestone, 1111,
gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5948) - mean (109ms) : 106, 111
. : milestone, 109,
master - mean (109ms) : 105, 113
. : milestone, 109,
section CallTarget+Inlining+NGEN
This PR (5948) - mean (795ms) : 672, 919
. : milestone, 795,
master - mean (770ms) : 756, 784
. : milestone, 770,
gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5948) - mean (92ms) : 90, 94
. : milestone, 92,
master - mean (92ms) : 90, 94
. : milestone, 92,
section CallTarget+Inlining+NGEN
This PR (5948) - mean (725ms) : 707, 743
. : milestone, 725,
master - mean (727ms) : 710, 744
. : milestone, 727,
gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5948) - mean (190ms) : 186, 194
. : milestone, 190,
master - mean (190ms) : 187, 193
. : milestone, 190,
section CallTarget+Inlining+NGEN
This PR (5948) - mean (1,205ms) : 1182, 1229
. : milestone, 1205,
master - mean (1,199ms) : 1173, 1225
. : milestone, 1199,
gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5948) - mean (275ms) : 270, 279
. : milestone, 275,
master - mean (275ms) : 270, 280
. : milestone, 275,
section CallTarget+Inlining+NGEN
This PR (5948) - mean (945ms) : 922, 968
. : milestone, 945,
master - mean (945ms) : 928, 963
. : milestone, 945,
gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5948) - mean (265ms) : 260, 269
. : milestone, 265,
master - mean (264ms) : 259, 268
. : milestone, 264,
section CallTarget+Inlining+NGEN
This PR (5948) - mean (926ms) : 910, 943
. : milestone, 926,
master - mean (922ms) : 899, 946
. : milestone, 922,
|
Datadog ReportBranch report: ❌ 5 Failed (0 Known Flaky), 164683 Passed, 1270 Skipped, 11h 39m 54.76s Total Time ❌ Failed Tests (5)
|
Benchmarks Report for tracer 🐌Benchmarks for #5948 compared to master:
The following thresholds were used for comparing the benchmark speeds:
Allocation changes below 0.5% are ignored. Benchmark detailsBenchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.RedisBenchmark - Faster 🎉 Same allocations ✔️
|
| Benchmark | base/diff | Base Median (ns) | Diff Median (ns) | Modality |
|---|---|---|---|---|
| Benchmarks.Trace.RedisBenchmark.SendReceive‑net6.0 | 1.113 | 1,441.49 | 1,295.04 |
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | SendReceive |
net6.0 | 1.44μs | 0.536ns | 2ns | 0.0159 | 0 | 0 | 1.14 KB |
| master | SendReceive |
netcoreapp3.1 | 1.75μs | 1.06ns | 4.11ns | 0.0158 | 0 | 0 | 1.14 KB |
| master | SendReceive |
net472 | 2.12μs | 1.12ns | 4.2ns | 0.183 | 0.00106 | 0 | 1.16 KB |
| #5948 | SendReceive |
net6.0 | 1.3μs | 0.499ns | 1.93ns | 0.0163 | 0 | 0 | 1.14 KB |
| #5948 | SendReceive |
netcoreapp3.1 | 1.75μs | 1.68ns | 6.5ns | 0.0157 | 0 | 0 | 1.14 KB |
| #5948 | SendReceive |
net472 | 2.08μs | 0.979ns | 3.79ns | 0.183 | 0.00104 | 0 | 1.16 KB |
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | EnrichedLog |
net6.0 | 2.71μs | 0.634ns | 2.46ns | 0.0217 | 0 | 0 | 1.6 KB |
| master | EnrichedLog |
netcoreapp3.1 | 3.97μs | 1.38ns | 5.18ns | 0.0217 | 0 | 0 | 1.65 KB |
| master | EnrichedLog |
net472 | 4.54μs | 1.32ns | 4.94ns | 0.322 | 0 | 0 | 2.04 KB |
| #5948 | EnrichedLog |
net6.0 | 2.76μs | 1.25ns | 4.66ns | 0.022 | 0 | 0 | 1.6 KB |
| #5948 | EnrichedLog |
netcoreapp3.1 | 3.82μs | 1.94ns | 7.52ns | 0.0209 | 0 | 0 | 1.65 KB |
| #5948 | EnrichedLog |
net472 | 4.39μs | 1.89ns | 7.33ns | 0.322 | 0 | 0 | 2.04 KB |
Benchmarks.Trace.SpanBenchmark - Slower ⚠️ Same allocations ✔️
Slower ⚠️ in #5948
Benchmark
diff/base
Base Median (ns)
Diff Median (ns)
Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net6.0
1.221
400.36
488.99
| Benchmark | diff/base | Base Median (ns) | Diff Median (ns) | Modality |
|---|---|---|---|---|
| Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net6.0 | 1.221 | 400.36 | 488.99 |
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | StartFinishSpan |
net6.0 | 400ns | 0.173ns | 0.669ns | 0.00805 | 0 | 0 | 576 B |
| master | StartFinishSpan |
netcoreapp3.1 | 594ns | 0.522ns | 2.02ns | 0.00781 | 0 | 0 | 576 B |
| master | StartFinishSpan |
net472 | 720ns | 0.394ns | 1.53ns | 0.0915 | 0 | 0 | 578 B |
| master | StartFinishScope |
net6.0 | 483ns | 0.242ns | 0.939ns | 0.0097 | 0 | 0 | 696 B |
| master | StartFinishScope |
netcoreapp3.1 | 717ns | 0.438ns | 1.7ns | 0.00935 | 0 | 0 | 696 B |
| master | StartFinishScope |
net472 | 932ns | 0.652ns | 2.52ns | 0.105 | 0 | 0 | 658 B |
| #5948 | StartFinishSpan |
net6.0 | 489ns | 0.199ns | 0.769ns | 0.0081 | 0 | 0 | 576 B |
| #5948 | StartFinishSpan |
netcoreapp3.1 | 632ns | 1.01ns | 3.77ns | 0.00792 | 0 | 0 | 576 B |
| #5948 | StartFinishSpan |
net472 | 715ns | 0.426ns | 1.6ns | 0.0915 | 0 | 0 | 578 B |
| #5948 | StartFinishScope |
net6.0 | 488ns | 0.386ns | 1.45ns | 0.00986 | 0 | 0 | 696 B |
| #5948 | StartFinishScope |
netcoreapp3.1 | 673ns | 0.48ns | 1.86ns | 0.00945 | 0 | 0 | 696 B |
| #5948 | StartFinishScope |
net472 | 914ns | 0.821ns | 3.18ns | 0.105 | 0 | 0 | 658 B |
Benchmarks.Trace.TraceAnnotationsBenchmark - Faster 🎉 Same allocations ✔️
Faster 🎉 in #5948
Benchmark
base/diff
Base Median (ns)
Diff Median (ns)
Modality
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0
1.138
734.52
645.55
| Benchmark | base/diff | Base Median (ns) | Diff Median (ns) | Modality |
|---|---|---|---|---|
| Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0 | 1.138 | 734.52 | 645.55 |
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | RunOnMethodBegin |
net6.0 | 734ns | 0.274ns | 1.06ns | 0.00982 | 0 | 0 | 696 B |
| master | RunOnMethodBegin |
netcoreapp3.1 | 916ns | 0.21ns | 0.758ns | 0.00921 | 0 | 0 | 696 B |
| master | RunOnMethodBegin |
net472 | 1.12μs | 0.475ns | 1.71ns | 0.104 | 0 | 0 | 658 B |
| #5948 | RunOnMethodBegin |
net6.0 | 646ns | 0.464ns | 1.8ns | 0.00971 | 0 | 0 | 696 B |
| #5948 | RunOnMethodBegin |
netcoreapp3.1 | 983ns | 0.521ns | 1.95ns | 0.00942 | 0 | 0 | 696 B |
| #5948 | RunOnMethodBegin |
net472 | 1.12μs | 0.711ns | 2.75ns | 0.104 | 0 | 0 | 658 B |
Throughput/Crank Report ⚡Throughput results for AspNetCoreSimpleController comparing the following branches/commits: Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red. Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards! gantt
title Throughput Linux x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (5948) (11.267M) : 0, 11266735
master (11.099M) : 0, 11098662
benchmarks/2.9.0 (11.081M) : 0, 11080577
section Automatic
This PR (5948) (7.242M) : 0, 7241705
master (7.353M) : 0, 7353407
benchmarks/2.9.0 (7.732M) : 0, 7732233
section Trace stats
master (7.604M) : 0, 7604389
section Manual
master (10.912M) : 0, 10911730
section Manual + Automatic
This PR (5948) (6.791M) : 0, 6791407
master (6.757M) : 0, 6756825
section DD_TRACE_ENABLED=0
master (10.056M) : 0, 10055906
gantt
title Throughput Linux arm64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (5948) (9.528M) : 0, 9528300
master (9.588M) : 0, 9587958
benchmarks/2.9.0 (9.798M) : 0, 9798067
section Automatic
This PR (5948) (6.660M) : 0, 6660228
master (6.554M) : 0, 6554472
section Trace stats
master (6.811M) : 0, 6811095
section Manual
master (9.622M) : 0, 9622473
section Manual + Automatic
This PR (5948) (6.077M) : 0, 6077150
master (5.894M) : 0, 5893873
section DD_TRACE_ENABLED=0
master (8.887M) : 0, 8886504
gantt
title Throughput Windows x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (5948) (10.286M) : 0, 10285612
master (10.171M) : 0, 10171179
benchmarks/2.9.0 (10.067M) : 0, 10067315
section Automatic
This PR (5948) (6.732M) : 0, 6731605
master (6.514M) : 0, 6513949
benchmarks/2.9.0 (7.552M) : 0, 7552193
section Trace stats
master (7.311M) : 0, 7310649
section Manual
master (10.008M) : 0, 10007638
section Manual + Automatic
This PR (5948) (6.320M) : 0, 6320022
master (6.286M) : 0, 6285745
section DD_TRACE_ENABLED=0
master (9.389M) : 0, 9388827
|
gleocadie
reviewed
Sep 3, 2024
profiler/src/ProfilerEngine/Datadog.Profiler.Native.Windows/ETW/EtwEventsHandler.cpp
Show resolved
Hide resolved
profiler/src/ProfilerEngine/Datadog.Profiler.Native.Windows/EtwEventsManager.cpp
Outdated
Show resolved
Hide resolved
profiler/src/Tools/ETW/dd-prof-etw/dd-prof-etw-client/EtwEventDumper.h
Outdated
Show resolved
Hide resolved
profiler/src/Tools/ETW/dd-prof-etw/dd-prof-etw-client/EtwEventDumper.h
Outdated
Show resolved
Hide resolved
gleocadie
approved these changes
Oct 14, 2024
| @@ -110,6 +110,7 @@ class EtwEventsManager : | |||
|
|
|||
| // responsible for receiving ETW events from the Windows Agent | |||
| std::unique_ptr<EtwEventsHandler> _eventsHandler; | |||
| std::string _agentEndpoint; | |||
There was a problem hiding this comment.
_agentEndpoint is for the replay scenario only ?
if yes, maybe make it explicit can help understand that's not a normal case (in prod)
Comment on lines
+322
to
+323
| std::stringstream buffer; | ||
| buffer << "OnGarbageCollectionStart: " << number << " " << generation << " " << reason << " " << type; |
There was a problem hiding this comment.
[PERF] I expect this log to be written in Debug only, so I would expect the std::stringstream to be construction only if we are debug level no?
Comment on lines
+346
to
+348
| std::stringstream buffer; | ||
| buffer << "OnGarbageCollectionEnd: " << number << " " << generation << " " << reason << " " << type; | ||
| LOG_GC_EVENT(buffer.str()); |
| @@ -93,6 +93,7 @@ Configuration::Configuration() | |||
| _isEtwEnabled = GetEnvironmentValue(EnvironmentVariables::EtwEnabled, false); | |||
| _deploymentMode = GetEnvironmentValue(EnvironmentVariables::SsiDeployed, DeploymentMode::Manual); | |||
| _isEtwLoggingEnabled = GetEnvironmentValue(EnvironmentVariables::EtwLoggingEnabled, false); | |||
| _etwEndpoint = GetEnvironmentValue(EnvironmentVariables::EtwEndpoint, DefaultEmptyString); | |||
There was a problem hiding this comment.
is the _etwEndpoint only for the replay scenario ? if yes maybe make it clear :)
| @@ -565,6 +566,15 @@ bool Configuration::IsEtwLoggingEnabled() const | |||
| #endif | |||
| } | |||
|
|
|||
| std::string const& Configuration::GetEtwEndpoint() const | |||
There was a problem hiding this comment.
same for the method name
| @@ -63,6 +63,7 @@ class EnvironmentVariables final | |||
| inline static const shared::WSTRING EtwEnabled = WStr("DD_INTERNAL_PROFILING_ETW_ENABLED"); | |||
| inline static const shared::WSTRING SsiDeployed = WStr("DD_INJECTION_ENABLED"); | |||
| inline static const shared::WSTRING EtwLoggingEnabled = WStr("DD_INTERNAL_ETW_LOGGING_ENABLED"); | |||
| inline static const shared::WSTRING EtwEndpoint = WStr("DD_INTERNAL_ETW_ENDPOINT"); | |||
There was a problem hiding this comment.
same for the environment variable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Record and replay ETW events received by the Datadog agent.
Reason for change
Since ETW events sent by the .NET Framework are proxied by the Datadog agent, it is needed to mock this data exchange in integration tests.
Implementation details
Test coverage
Other details