Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v3-main] fix tests that rebase broke #5638

Merged
merged 2 commits into from
Jun 3, 2024
Merged

[v3-main] fix tests that rebase broke #5638

merged 2 commits into from
Jun 3, 2024

Conversation

robertpi
Copy link
Member

Summary of changes

Fix some tests broken in the last rebase.

Reason for change

Fixing things is good.

Test coverage

Yes.

@robertpi robertpi requested review from a team as code owners May 31, 2024 16:33
@robertpi robertpi changed the base branch from master to v3-main May 31, 2024 16:35
@DataDog DataDog deleted a comment from github-actions bot May 31, 2024
andrewlock
andrewlock approved these changes May 31, 2024
View reviewed changes
Copy link
Member

@andrewlock andrewlock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it works, :shipit:

@datadog-ddstaging
Copy link

datadog-ddstaging bot commented May 31, 2024 •
edited
Loading

Datadog Report

Branch report: robert/v3/fix-rebase
Commit report: b3ce405
Test service: dd-trace-dotnet

❌ 1 Failed (0 Known Flaky), 419038 Passed, 3184 Skipped, 34h 16m 27.88s Total Time

❌ Failed Tests (1)

  • MethodProbeTest - Datadog.Trace.Debugger.IntegrationTests.ProbesTests - Details

    Expand for error 
     Snapshot count not found. Expected 2, actual 0

@andrewlock
Copy link
Member

andrewlock commented May 31, 2024 •
edited
Loading

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5638) - mean (74ms)  : 63, 84
     .   : milestone, 74,
    master - mean (73ms)  : 65, 81
     .   : milestone, 73,

    section CallTarget+Inlining+NGEN
    This PR (5638) - mean (997ms)  : 974, 1019
     .   : milestone, 997,
    master - mean (991ms)  : 968, 1014
     .   : milestone, 991,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5638) - mean (109ms)  : 106, 112
     .   : milestone, 109,
    master - mean (109ms)  : 106, 112
     .   : milestone, 109,

    section CallTarget+Inlining+NGEN
    This PR (5638) - mean (703ms)  : 686, 719
     .   : milestone, 703,
    master - mean (701ms)  : 678, 724
     .   : milestone, 701,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5638) - mean (92ms)  : 89, 95
     .   : milestone, 92,
    master - mean (93ms)  : 90, 97
     .   : milestone, 93,

    section CallTarget+Inlining+NGEN
    This PR (5638) - mean (661ms)  : 634, 688
     .   : milestone, 661,
    master - mean (658ms)  : 629, 687
     .   : milestone, 658,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5638) - mean (194ms)  : 191, 198
     .   : milestone, 194,
    master - mean (191ms)  : 188, 195
     .   : milestone, 191,

    section CallTarget+Inlining+NGEN
    This PR (5638) - mean (1,107ms)  : 1079, 1134
     .   : milestone, 1107,
    master - mean (1,071ms)  : 1045, 1098
     .   : milestone, 1071,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5638) - mean (281ms)  : 277, 286
     .   : milestone, 281,
    master - mean (276ms)  : 270, 282
     .   : milestone, 276,

    section CallTarget+Inlining+NGEN
    This PR (5638) - mean (895ms)  : 871, 919
     .   : milestone, 895,
    master - mean (854ms)  : 830, 878
     .   : milestone, 854,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5638) - mean (270ms)  : 267, 273
     .   : milestone, 270,
    master - mean (266ms)  : 262, 270
     .   : milestone, 266,

    section CallTarget+Inlining+NGEN
    This PR (5638) - mean (871ms)  : 846, 896
     .   : milestone, 871,
    master - mean (846ms)  : 817, 875
     .   : milestone, 846,
Loading

@andrewlock
Copy link
Member

andrewlock commented May 31, 2024 •
edited
Loading

Throughput/Crank Report ⚡

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5638) (11.653M)   : 0, 11652790
    master (11.529M)   : 0, 11529287
    benchmarks/2.9.0 (11.482M)   : 0, 11482120

    section Automatic
    This PR (5638) (7.949M)   : 0, 7948684
    master (7.871M)   : 0, 7871133
    benchmarks/2.9.0 (8.261M)   : 0, 8261135

    section Trace stats
    master (8.132M)   : 0, 8131982

    section Manual
    master (9.883M)   : 0, 9883244

    section Manual + Automatic
    This PR (5638) (7.359M)   : 0, 7359056
    master (7.413M)   : 0, 7412988
Loading 
gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5638) (9.590M)   : 0, 9589793
    master (9.468M)   : 0, 9467617
    benchmarks/2.9.0 (9.752M)   : 0, 9752478

    section Automatic
    This PR (5638) (6.743M)   : 0, 6743199
    master (6.589M)   : 0, 6588742

    section Trace stats
    master (7.075M)   : 0, 7075282

    section Manual
    master (8.304M)   : 0, 8303709

    section Manual + Automatic
    This PR (5638) (6.185M)   : 0, 6185203
    master (6.063M)   : 0, 6063471
Loading 
gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5638) (9.762M)   : 0, 9762148
    master (9.822M)   : 0, 9822132
    benchmarks/2.9.0 (9.820M)   : 0, 9820306

    section Automatic
    This PR (5638) (6.863M)   : 0, 6862758
    master (6.876M)   : 0, 6875542
    benchmarks/2.9.0 (7.183M)   : 0, 7183038

    section Trace stats
    master (7.302M)   : 0, 7301642

    section Manual
    master (8.457M)   : 0, 8456584

    section Manual + Automatic
    This PR (5638) (6.501M)   : 0, 6501319
    master (6.670M)   : 0, 6670202
Loading

@andrewlock
Copy link
Member

andrewlock commented May 31, 2024 •
edited
Loading

Benchmarks Report for appsec 🐌

Benchmarks for #5638 compared to master:

  • 1 benchmarks are slower, with geometric mean 1.177
  • 3 benchmarks have fewer allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.Asm.AppSecBodyBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #5638

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorMoreComplexBody‑net472 1.177 3,795.70 4,469.25

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master AllCycleSimpleBody net6.0 72.6μs 121ns 470ns 0.0723 0 0 6 KB
master AllCycleSimpleBody netcoreapp3.1 62μs 83.2ns 322ns 0.092 0 0 6.94 KB
master AllCycleSimpleBody net472 49.1μs 68ns 254ns 1.32 0 0 8.33 KB
master AllCycleMoreComplexBody net6.0 77.5μs 94.4ns 366ns 0.116 0 0 9.5 KB
master AllCycleMoreComplexBody netcoreapp3.1 68.5μs 88.1ns 341ns 0.136 0 0 10.36 KB
master AllCycleMoreComplexBody net472 55.6μs 82.3ns 319ns 1.86 0.0278 0 11.84 KB
master ObjectExtractorSimpleBody net6.0 152ns 0.192ns 0.719ns 0.00393 0 0 280 B
master ObjectExtractorSimpleBody netcoreapp3.1 209ns 0.101ns 0.377ns 0.0037 0 0 272 B
master ObjectExtractorSimpleBody net472 169ns 0.323ns 1.25ns 0.0446 0 0 281 B
master ObjectExtractorMoreComplexBody net6.0 3.03μs 1.34ns 5.21ns 0.0531 0 0 3.78 KB
master ObjectExtractorMoreComplexBody netcoreapp3.1 4.02μs 3.36ns 13ns 0.0504 0 0 3.69 KB
master ObjectExtractorMoreComplexBody net472 3.8μs 2.65ns 10.3ns 0.603 0.00572 0 3.8 KB
#5638 AllCycleSimpleBody net6.0 73μs 67.2ns 251ns 0.0731 0 0 6 KB
#5638 AllCycleSimpleBody netcoreapp3.1 62.2μs 110ns 411ns 0.0921 0 0 6.94 KB
#5638 AllCycleSimpleBody net472 49.6μs 76.3ns 286ns 1.31 0 0 8.33 KB
#5638 AllCycleMoreComplexBody net6.0 77.9μs 124ns 480ns 0.117 0 0 9.5 KB
#5638 AllCycleMoreComplexBody netcoreapp3.1 70.5μs 137ns 513ns 0.114 0 0 10.36 KB
#5638 AllCycleMoreComplexBody net472 56.3μs 120ns 465ns 1.86 0.0278 0 11.84 KB
#5638 ObjectExtractorSimpleBody net6.0 145ns 0.0694ns 0.269ns 0.00397 0 0 280 B
#5638 ObjectExtractorSimpleBody netcoreapp3.1 219ns 0.142ns 0.549ns 0.00374 0 0 272 B
#5638 ObjectExtractorSimpleBody net472 174ns 0.481ns 1.86ns 0.0446 0 0 281 B
#5638 ObjectExtractorMoreComplexBody net6.0 2.98μs 1.68ns 6.5ns 0.0538 0 0 3.78 KB
#5638 ObjectExtractorMoreComplexBody netcoreapp3.1 4.09μs 2.66ns 10.3ns 0.0509 0 0 3.69 KB
#5638 ObjectExtractorMoreComplexBody net472 4.47μs 3.19ns 12.3ns 0.602 0.00672 0 3.8 KB
Benchmarks.Trace.Asm.AppSecEncoderBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EncodeArgs net6.0 39.3μs 46.5ns 174ns 0.449 0 0 32.4 KB
master EncodeArgs netcoreapp3.1 55.4μs 19.7ns 76.1ns 0.44 0 0 32.4 KB
master EncodeArgs net472 68.6μs 47.8ns 185ns 5.15 0.0682 0 32.5 KB
master EncodeLegacyArgs net6.0 70.7μs 91.8ns 331ns 0 0 0 2.14 KB
master EncodeLegacyArgs netcoreapp3.1 106μs 111ns 432ns 0 0 0 2.14 KB
master EncodeLegacyArgs net472 155μs 104ns 404ns 0.31 0 0 2.15 KB
#5638 EncodeArgs net6.0 41.2μs 28.5ns 110ns 0.454 0 0 32.4 KB
#5638 EncodeArgs netcoreapp3.1 55μs 24.9ns 96.5ns 0.44 0 0 32.4 KB
#5638 EncodeArgs net472 68.6μs 31ns 120ns 5.16 0.0683 0 32.5 KB
#5638 EncodeLegacyArgs net6.0 76.8μs 117ns 453ns 0.0349 0 0 2.14 KB
#5638 EncodeLegacyArgs netcoreapp3.1 104μs 86.2ns 334ns 0 0 0 2.15 KB
#5638 EncodeLegacyArgs net472 155μs 55.5ns 200ns 0.308 0 0 2.15 KB
Benchmarks.Trace.Asm.AppSecWafBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunWafRealisticBenchmark net6.0 183μs 247ns 956ns 0 0 0 2.42 KB
master RunWafRealisticBenchmark netcoreapp3.1 198μs 291ns 1.13μs 0 0 0 2.37 KB
master RunWafRealisticBenchmark net472 216μs 125ns 483ns 0.323 0 0 2.43 KB
master RunWafRealisticBenchmarkWithAttack net6.0 122μs 61.5ns 238ns 0 0 0 1.46 KB
master RunWafRealisticBenchmarkWithAttack netcoreapp3.1 132μs 143ns 535ns 0 0 0 1.45 KB
master RunWafRealisticBenchmarkWithAttack net472 142μs 68.6ns 266ns 0.213 0 0 1.48 KB
#5638 RunWafRealisticBenchmark net6.0 184μs 125ns 484ns 0 0 0 2.42 KB
#5638 RunWafRealisticBenchmark netcoreapp3.1 195μs 251ns 974ns 0 0 0 2.37 KB
#5638 RunWafRealisticBenchmark net472 214μs 90.2ns 338ns 0.32 0 0 2.43 KB
#5638 RunWafRealisticBenchmarkWithAttack net6.0 122μs 104ns 402ns 0 0 0 1.46 KB
#5638 RunWafRealisticBenchmarkWithAttack netcoreapp3.1 131μs 180ns 699ns 0 0 0 1.45 KB
#5638 RunWafRealisticBenchmarkWithAttack net472 141μs 48.3ns 187ns 0.211 0 0 1.48 KB
Benchmarks.Trace.Iast.StringAspectsBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #5638

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑netcoreapp3.1 263.66 KB 253.96 KB -9.7 KB -3.68%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net6.0 265.44 KB 254.07 KB -11.37 KB -4.28%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑net472 62.53 KB 58.47 KB -4.06 KB -6.49%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StringConcatBenchmark net6.0 62.3μs 865ns 8.65μs 0 0 0 43.44 KB
master StringConcatBenchmark netcoreapp3.1 53.5μs 240ns 830ns 0 0 0 42.64 KB
master StringConcatBenchmark net472 37.9μs 103ns 386ns 0 0 0 62.53 KB
master StringConcatAspectBenchmark net6.0 287μs 5.34μs 52μs 0 0 0 265.44 KB
master StringConcatAspectBenchmark netcoreapp3.1 334μs 1.75μs 10.9μs 0 0 0 263.66 KB
master StringConcatAspectBenchmark net472 306μs 7.73μs 75.3μs 0 0 0 278.53 KB
#5638 StringConcatBenchmark net6.0 59.8μs 706ns 6.99μs 0 0 0 43.44 KB
#5638 StringConcatBenchmark netcoreapp3.1 54.8μs 233ns 839ns 0 0 0 42.64 KB
#5638 StringConcatBenchmark net472 38.2μs 61.7ns 231ns 0 0 0 58.47 KB
#5638 StringConcatAspectBenchmark net6.0 295μs 1.51μs 7.24μs 0 0 0 254.07 KB
#5638 StringConcatAspectBenchmark netcoreapp3.1 328μs 1.63μs 9.53μs 0 0 0 253.96 KB
#5638 StringConcatAspectBenchmark net472 287μs 5.99μs 57.5μs 0 0 0 278.53 KB

@andrewlock
Copy link
Member

andrewlock commented May 31, 2024 •
edited
Loading

Benchmarks Report for tracer 🐌

Benchmarks for #5638 compared to master:

  • 2 benchmarks are faster, with geometric mean 1.144
  • 1 benchmarks are slower, with geometric mean 1.124
  • All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 8.82μs 48.2ns 320ns 0.0217 0.00866 0 7.55 KB
master StartStopWithChild netcoreapp3.1 10.9μs 53.8ns 274ns 0.0268 0.0107 0 7.65 KB
master StartStopWithChild net472 17.9μs 88.8ns 366ns 1.37 0.394 0.131 8.05 KB
#5638 StartStopWithChild net6.0 8.79μs 48.4ns 302ns 0.0226 0.00905 0 7.55 KB
#5638 StartStopWithChild netcoreapp3.1 11μs 62.4ns 437ns 0.0279 0.0112 0 7.65 KB
#5638 StartStopWithChild net472 17.6μs 68.3ns 264ns 1.36 0.372 0.106 8.07 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 462μs 327ns 1.23μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 642μs 359ns 1.39μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 844μs 217ns 839ns 0.419 0 0 3.3 KB
#5638 WriteAndFlushEnrichedTraces net6.0 479μs 213ns 824ns 0 0 0 2.7 KB
#5638 WriteAndFlushEnrichedTraces netcoreapp3.1 629μs 212ns 821ns 0 0 0 2.7 KB
#5638 WriteAndFlushEnrichedTraces net472 834μs 201ns 777ns 0.419 0 0 3.3 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 172μs 252ns 942ns 0.254 0 0 18.44 KB
master SendRequest netcoreapp3.1 192μs 310ns 1.2μs 0.193 0 0 20.6 KB
master SendRequest net472 0.000922ns 0.000306ns 0.00114ns 0 0 0 0 b
#5638 SendRequest net6.0 172μs 257ns 996ns 0.174 0 0 18.44 KB
#5638 SendRequest netcoreapp3.1 190μs 195ns 730ns 0.191 0 0 20.6 KB
#5638 SendRequest net472 0.000805ns 0.000298ns 0.00115ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 563μs 839ns 3.25μs 0.534 0 0 41.69 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 662μs 2.36μs 9.72μs 0.326 0 0 41.84 KB
master WriteAndFlushEnrichedTraces net472 860μs 3.4μs 12.3μs 8.25 2.6 0.434 53.26 KB
#5638 WriteAndFlushEnrichedTraces net6.0 542μs 382ns 1.38μs 0.551 0 0 41.69 KB
#5638 WriteAndFlushEnrichedTraces netcoreapp3.1 642μs 1.58μs 6.11μs 0.322 0 0 41.75 KB
#5638 WriteAndFlushEnrichedTraces net472 864μs 3.48μs 13.5μs 8.36 2.64 0.44 53.27 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.13μs 0.649ns 2.51ns 0.0113 0 0 808 B
master ExecuteNonQuery netcoreapp3.1 1.53μs 0.753ns 2.92ns 0.0107 0 0 808 B
master ExecuteNonQuery net472 1.79μs 2.54ns 9.82ns 0.122 0 0 770 B
#5638 ExecuteNonQuery net6.0 1.09μs 3.34ns 12.9ns 0.0113 0 0 808 B
#5638 ExecuteNonQuery netcoreapp3.1 1.5μs 0.786ns 2.72ns 0.0105 0 0 808 B
#5638 ExecuteNonQuery net472 1.75μs 2.11ns 8.15ns 0.122 0 0 770 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.15μs 1.2ns 4.63ns 0.0138 0 0 976 B
master CallElasticsearch netcoreapp3.1 1.5μs 0.435ns 1.57ns 0.0135 0 0 976 B
master CallElasticsearch net472 2.48μs 1.8ns 6.95ns 0.158 0 0 995 B
master CallElasticsearchAsync net6.0 1.25μs 0.643ns 2.4ns 0.0131 0 0 952 B
master CallElasticsearchAsync netcoreapp3.1 1.64μs 0.595ns 2.14ns 0.014 0 0 1.02 KB
master CallElasticsearchAsync net472 2.58μs 1.66ns 6.42ns 0.166 0.00129 0 1.05 KB
#5638 CallElasticsearch net6.0 1.2μs 2.31ns 8.96ns 0.0136 0 0 976 B
#5638 CallElasticsearch netcoreapp3.1 1.48μs 0.613ns 2.21ns 0.0126 0 0 976 B
#5638 CallElasticsearch net472 2.48μs 1.73ns 6.7ns 0.157 0 0 995 B
#5638 CallElasticsearchAsync net6.0 1.27μs 0.841ns 3.15ns 0.0133 0 0 952 B
#5638 CallElasticsearchAsync netcoreapp3.1 1.68μs 0.624ns 2.25ns 0.0136 0 0 1.02 KB
#5638 CallElasticsearchAsync net472 2.51μs 2.12ns 8.22ns 0.167 0.00125 0 1.05 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.27μs 0.543ns 2.03ns 0.0133 0 0 952 B
master ExecuteAsync netcoreapp3.1 1.57μs 0.637ns 2.38ns 0.0126 0 0 952 B
master ExecuteAsync net472 1.75μs 0.874ns 3.38ns 0.145 0 0 915 B
#5638 ExecuteAsync net6.0 1.33μs 0.672ns 2.6ns 0.0133 0 0 952 B
#5638 ExecuteAsync netcoreapp3.1 1.59μs 0.627ns 2.43ns 0.0125 0 0 952 B
#5638 ExecuteAsync net472 1.78μs 1.01ns 3.64ns 0.145 0.000889 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 4.14μs 2.01ns 7.51ns 0.0311 0 0 2.22 KB
master SendAsync netcoreapp3.1 5.24μs 1.9ns 7.13ns 0.0368 0 0 2.76 KB
master SendAsync net472 7.52μs 1.99ns 7.71ns 0.496 0 0 3.12 KB
#5638 SendAsync net6.0 4.11μs 1.66ns 6.2ns 0.0311 0 0 2.22 KB
#5638 SendAsync netcoreapp3.1 5.06μs 3.28ns 12.7ns 0.0354 0 0 2.76 KB
#5638 SendAsync net472 7.55μs 2.92ns 11.3ns 0.494 0.00377 0 3.12 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.43μs 0.507ns 1.9ns 0.0229 0 0 1.64 KB
master EnrichedLog netcoreapp3.1 2.27μs 1.4ns 5.26ns 0.0216 0 0 1.64 KB
master EnrichedLog net472 2.47μs 1.11ns 4.29ns 0.249 0 0 1.57 KB
#5638 EnrichedLog net6.0 1.44μs 0.759ns 2.94ns 0.0232 0 0 1.64 KB
#5638 EnrichedLog netcoreapp3.1 2.25μs 0.628ns 2.35ns 0.0214 0 0 1.64 KB
#5638 EnrichedLog net472 2.57μs 0.749ns 2.59ns 0.25 0 0 1.57 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 117μs 388ns 1.5μs 0.0573 0 0 4.28 KB
master EnrichedLog netcoreapp3.1 118μs 124ns 482ns 0.0595 0 0 4.28 KB
master EnrichedLog net472 150μs 89.8ns 324ns 0.676 0.225 0 4.46 KB
#5638 EnrichedLog net6.0 118μs 197ns 763ns 0.0585 0 0 4.28 KB
#5638 EnrichedLog netcoreapp3.1 121μs 139ns 537ns 0.0607 0 0 4.28 KB
#5638 EnrichedLog net472 149μs 225ns 871ns 0.679 0.226 0 4.46 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 3.06μs 0.72ns 2.69ns 0.0306 0 0 2.2 KB
master EnrichedLog netcoreapp3.1 4.24μs 1.44ns 5.18ns 0.0296 0 0 2.2 KB
master EnrichedLog net472 4.82μs 1.6ns 5.97ns 0.319 0 0 2.02 KB
#5638 EnrichedLog net6.0 2.9μs 0.677ns 2.53ns 0.0302 0 0 2.2 KB
#5638 EnrichedLog netcoreapp3.1 4.13μs 1.87ns 7.24ns 0.0289 0 0 2.2 KB
#5638 EnrichedLog net472 4.8μs 2.54ns 9.83ns 0.321 0 0 2.02 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.26μs 0.666ns 2.4ns 0.0162 0 0 1.14 KB
master SendReceive netcoreapp3.1 1.69μs 0.788ns 2.95ns 0.0151 0 0 1.14 KB
master SendReceive net472 2.08μs 0.9ns 3.48ns 0.183 0 0 1.16 KB
#5638 SendReceive net6.0 1.37μs 0.585ns 2.27ns 0.0158 0 0 1.14 KB
#5638 SendReceive netcoreapp3.1 1.73μs 0.735ns 2.75ns 0.0156 0 0 1.14 KB
#5638 SendReceive net472 2.15μs 0.974ns 3.51ns 0.183 0 0 1.16 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.74μs 0.395ns 1.53ns 0.022 0 0 1.6 KB
master EnrichedLog netcoreapp3.1 3.83μs 1.88ns 7.29ns 0.0212 0 0 1.65 KB
master EnrichedLog net472 4.34μs 2.64ns 10.2ns 0.322 0 0 2.04 KB
#5638 EnrichedLog net6.0 2.89μs 0.781ns 3.03ns 0.0232 0 0 1.6 KB
#5638 EnrichedLog netcoreapp3.1 3.86μs 0.991ns 3.84ns 0.0212 0 0 1.65 KB
#5638 EnrichedLog net472 4.32μs 2.63ns 10.2ns 0.323 0 0 2.04 KB
Benchmarks.Trace.SpanBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #5638

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net472 1.124 578.60 650.12

Faster 🎉 in #5638

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net6.0 1.166 462.70 396.78

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 462ns 0.238ns 0.92ns 0.00815 0 0 576 B
master StartFinishSpan netcoreapp3.1 564ns 0.79ns 3.06ns 0.00786 0 0 576 B
master StartFinishSpan net472 579ns 0.785ns 2.94ns 0.0916 0 0 578 B
master StartFinishScope net6.0 473ns 0.267ns 1.03ns 0.00988 0 0 696 B
master StartFinishScope netcoreapp3.1 712ns 1.2ns 4.63ns 0.00927 0 0 696 B
master StartFinishScope net472 831ns 0.8ns 3.1ns 0.104 0 0 658 B
#5638 StartFinishSpan net6.0 397ns 0.155ns 0.599ns 0.00815 0 0 576 B
#5638 StartFinishSpan netcoreapp3.1 559ns 0.528ns 1.98ns 0.00777 0 0 576 B
#5638 StartFinishSpan net472 650ns 0.544ns 2.04ns 0.0915 0 0 578 B
#5638 StartFinishScope net6.0 473ns 0.256ns 0.991ns 0.00971 0 0 696 B
#5638 StartFinishScope netcoreapp3.1 721ns 1.05ns 4.05ns 0.00954 0 0 696 B
#5638 StartFinishScope net472 828ns 2.09ns 8.11ns 0.105 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #5638

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑netcoreapp3.1 1.123 976.27 869.59

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 741ns 0.379ns 1.42ns 0.00963 0 0 696 B
master RunOnMethodBegin netcoreapp3.1 976ns 1.05ns 4.05ns 0.00931 0 0 696 B
master RunOnMethodBegin net472 1.09μs 1.08ns 4.18ns 0.104 0 0 658 B
#5638 RunOnMethodBegin net6.0 668ns 0.22ns 0.853ns 0.00975 0 0 696 B
#5638 RunOnMethodBegin netcoreapp3.1 869ns 0.526ns 1.97ns 0.00952 0 0 696 B
#5638 RunOnMethodBegin net472 1.05μs 1.5ns 5.8ns 0.104 0 0 658 B

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 3, 2024

Snapshots difference summary

The following differences have been observed in committed snapshots. It is meant to help the reviewer.
The diff is simplistic, so please check some files anyway while we improve it.

5 occurrences of :

-      _dd.agent_psr: 1.0,

@andrewlock andrewlock mentioned this pull request Jun 3, 2024
Closed
@robertpi robertpi merged commit 1623930 into v3-main Jun 3, 2024
63 of 65 checks passed
@robertpi robertpi deleted the robert/v3/fix-rebase branch June 3, 2024 14:20
@robertpi
Copy link
Member Author

robertpi commented Jun 3, 2024

Merged with one reviewer, as merging further changes on v3-main was blocked by these broken tests.

andrewlock pushed a commit that referenced this pull request Jun 5, 2024
@robertpi @andrewlock
[v3-main] fix tests that rebase broke (#5638)
c8f9aaf 
* fix integration test diffs

* correct other failing test
andrewlock pushed a commit that referenced this pull request Jun 12, 2024
@robertpi @andrewlock
[v3-main] fix tests that rebase broke (#5638)
2046074 
* fix integration test diffs

* correct other failing test
andrewlock pushed a commit that referenced this pull request Jun 24, 2024
@robertpi @andrewlock
[v3-main] fix tests that rebase broke (#5638)
551816d 
* fix integration test diffs

* correct other failing test
andrewlock pushed a commit that referenced this pull request Jun 26, 2024
@robertpi @andrewlock
[v3-main] fix tests that rebase broke (#5638)
599df04 
* fix integration test diffs

* correct other failing test
andrewlock pushed a commit that referenced this pull request Jun 27, 2024
@robertpi @andrewlock
[v3-main] fix tests that rebase broke (#5638)
1369303 
* fix integration test diffs

* correct other failing test
andrewlock pushed a commit that referenced this pull request Jul 1, 2024
@robertpi @andrewlock
[v3-main] fix tests that rebase broke (#5638)
66938bc 
* fix integration test diffs

* correct other failing test
andrewlock pushed a commit that referenced this pull request Jul 1, 2024
@robertpi @andrewlock
[v3-main] fix tests that rebase broke (#5638)
31b0465 
* fix integration test diffs

* correct other failing test
andrewlock pushed a commit that referenced this pull request Jul 2, 2024
@robertpi @andrewlock
[v3-main] fix tests that rebase broke (#5638)
d80bd9d 
* fix integration test diffs

* correct other failing test
andrewlock pushed a commit that referenced this pull request Jul 2, 2024
@robertpi @andrewlock
[v3-main] fix tests that rebase broke (#5638)
421f4e2 
* fix integration test diffs

* correct other failing test
andrewlock pushed a commit that referenced this pull request Jul 2, 2024
@robertpi @andrewlock
[v3-main] fix tests that rebase broke (#5638)
cef1eab 
* fix integration test diffs

* correct other failing test
andrewlock pushed a commit that referenced this pull request Jul 3, 2024
@robertpi @andrewlock
[v3-main] fix tests that rebase broke (#5638)
8cdb910 
* fix integration test diffs

* correct other failing test
andrewlock pushed a commit that referenced this pull request Jul 4, 2024
@robertpi @andrewlock
[v3-main] fix tests that rebase broke (#5638)
9b48749 
* fix integration test diffs

* correct other failing test
andrewlock pushed a commit that referenced this pull request Jul 4, 2024
@robertpi @andrewlock
[v3-main] fix tests that rebase broke (#5638)
5c17424 
* fix integration test diffs

* correct other failing test
andrewlock pushed a commit that referenced this pull request Jul 16, 2024
@robertpi @andrewlock
[v3-main] fix tests that rebase broke (#5638)
31cccae 
* fix integration test diffs

* correct other failing test
andrewlock pushed a commit that referenced this pull request Jul 18, 2024
@robertpi @andrewlock
[v3-main] fix tests that rebase broke (#5638)
b98b039 
* fix integration test diffs

* correct other failing test
andrewlock pushed a commit that referenced this pull request Jul 24, 2024
@robertpi @andrewlock
[v3-main] fix tests that rebase broke (#5638)
e6fe27d 
* fix integration test diffs

* correct other failing test
andrewlock pushed a commit that referenced this pull request Jul 25, 2024
@robertpi @andrewlock
[v3-main] fix tests that rebase broke (#5638)
a00e48e 
* fix integration test diffs

* correct other failing test
andrewlock pushed a commit that referenced this pull request Jul 25, 2024
@robertpi @andrewlock
[v3-main] fix tests that rebase broke (#5638)
cfe0d26 
* fix integration test diffs

* correct other failing test
andrewlock pushed a commit that referenced this pull request Jul 25, 2024
@robertpi @andrewlock
[v3-main] fix tests that rebase broke (#5638)
f5190d9 
* fix integration test diffs

* correct other failing test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewlock andrewlock andrewlock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robertpi @andrewlock