-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI Visibility] Automatic reporting of Microsoft.CodeCoverage percentage #5633
[CI Visibility] Automatic reporting of Microsoft.CodeCoverage percentage #5633
Conversation
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing the following branches/commits: Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5633) - mean (74ms) : 62, 87
. : milestone, 74,
master - mean (74ms) : 60, 88
. : milestone, 74,
section CallTarget+Inlining+NGEN
This PR (5633) - mean (982ms) : 959, 1005
. : milestone, 982,
master - mean (981ms) : 962, 1000
. : milestone, 981,
gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5633) - mean (109ms) : 107, 111
. : milestone, 109,
master - mean (110ms) : 106, 113
. : milestone, 110,
section CallTarget+Inlining+NGEN
This PR (5633) - mean (689ms) : 668, 710
. : milestone, 689,
master - mean (687ms) : 665, 709
. : milestone, 687,
gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5633) - mean (93ms) : 89, 97
. : milestone, 93,
master - mean (93ms) : 89, 97
. : milestone, 93,
section CallTarget+Inlining+NGEN
This PR (5633) - mean (644ms) : 620, 668
. : milestone, 644,
master - mean (645ms) : 624, 665
. : milestone, 645,
gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5633) - mean (191ms) : 188, 194
. : milestone, 191,
master - mean (190ms) : 188, 193
. : milestone, 190,
section CallTarget+Inlining+NGEN
This PR (5633) - mean (1,074ms) : 1055, 1092
. : milestone, 1074,
master - mean (1,069ms) : 1054, 1083
. : milestone, 1069,
gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5633) - mean (276ms) : 272, 280
. : milestone, 276,
master - mean (276ms) : 272, 280
. : milestone, 276,
section CallTarget+Inlining+NGEN
This PR (5633) - mean (861ms) : 837, 885
. : milestone, 861,
master - mean (856ms) : 836, 875
. : milestone, 856,
gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5633) - mean (267ms) : 263, 271
. : milestone, 267,
master - mean (266ms) : 263, 270
. : milestone, 266,
section CallTarget+Inlining+NGEN
This PR (5633) - mean (851ms) : 820, 881
. : milestone, 851,
master - mean (847ms) : 827, 867
. : milestone, 847,
|
Datadog ReportBranch report: ✅ 0 Failed, 338233 Passed, 1584 Skipped, 13h 46m 2.59s Total Time |
Throughput/Crank Report:zap:Throughput results for AspNetCoreSimpleController comparing the following branches/commits: Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red. Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards! gantt
title Throughput Linux x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (5633) (11.449M) : 0, 11448523
master (11.826M) : 0, 11826483
benchmarks/2.9.0 (11.612M) : 0, 11612163
section Automatic
This PR (5633) (7.749M) : 0, 7748695
master (8.039M) : 0, 8039339
benchmarks/2.9.0 (8.366M) : 0, 8366444
section Trace stats
master (8.329M) : 0, 8328674
section Manual
This PR (5633) (9.911M) : 0, 9910591
master (10.225M) : 0, 10224995
section Manual + Automatic
This PR (5633) (7.234M) : 0, 7234102
master (7.521M) : 0, 7521284
section Version Conflict
master (6.849M) : 0, 6848531
gantt
title Throughput Linux arm64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (5633) (9.673M) : 0, 9672777
master (9.594M) : 0, 9593567
benchmarks/2.9.0 (9.562M) : 0, 9561595
section Automatic
This PR (5633) (6.640M) : 0, 6640173
master (6.504M) : 0, 6504122
section Trace stats
master (6.949M) : 0, 6948727
section Manual
This PR (5633) (8.173M) : 0, 8172534
master (8.212M) : 0, 8212265
section Manual + Automatic
This PR (5633) (6.156M) : 0, 6156405
master (5.936M) : 0, 5936307
section Version Conflict
master (5.719M) : 0, 5719369
gantt
title Throughput Windows x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (5633) (10.227M) : 0, 10226980
master (9.941M) : 0, 9941216
benchmarks/2.9.0 (10.029M) : 0, 10029228
section Automatic
This PR (5633) (7.013M) : 0, 7013233
master (6.969M) : 0, 6968634
benchmarks/2.9.0 (7.366M) : 0, 7366349
section Trace stats
master (7.408M) : 0, 7408153
section Manual
This PR (5633) (8.784M) : 0, 8784138
master (8.880M) : 0, 8880192
section Manual + Automatic
This PR (5633) (6.783M) : 0, 6782931
master (6.768M) : 0, 6768086
section Version Conflict
master (6.226M) : 0, 6226120
|
Benchmarks Report for tracer 🐌Benchmarks for #5633 compared to master:
The following thresholds were used for comparing the benchmark speeds:
Allocation changes below 0.5% are ignored. Benchmark detailsBenchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.ElasticsearchBenchmark - Slower
|
Benchmark | diff/base | Base Median (ns) | Diff Median (ns) | Modality |
---|---|---|---|---|
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync‑net6.0 | 1.117 | 1,221.47 | 1,364.22 |
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | CallElasticsearch |
net6.0 | 1.15μs | 0.671ns | 2.51ns | 0.0133 | 0 | 0 | 976 B |
master | CallElasticsearch |
netcoreapp3.1 | 1.51μs | 0.661ns | 2.56ns | 0.013 | 0 | 0 | 976 B |
master | CallElasticsearch |
net472 | 2.49μs | 1.01ns | 3.9ns | 0.157 | 0.00125 | 0 | 995 B |
master | CallElasticsearchAsync |
net6.0 | 1.22μs | 0.964ns | 3.73ns | 0.0135 | 0 | 0 | 952 B |
master | CallElasticsearchAsync |
netcoreapp3.1 | 1.69μs | 1.4ns | 5.43ns | 0.0143 | 0 | 0 | 1.02 KB |
master | CallElasticsearchAsync |
net472 | 2.6μs | 1.25ns | 4.51ns | 0.166 | 0.0013 | 0 | 1.05 KB |
#5633 | CallElasticsearch |
net6.0 | 1.24μs | 0.89ns | 3.33ns | 0.0137 | 0 | 0 | 976 B |
#5633 | CallElasticsearch |
netcoreapp3.1 | 1.44μs | 0.611ns | 2.36ns | 0.0129 | 0 | 0 | 976 B |
#5633 | CallElasticsearch |
net472 | 2.37μs | 1.94ns | 7.52ns | 0.158 | 0 | 0 | 995 B |
#5633 | CallElasticsearchAsync |
net6.0 | 1.36μs | 0.501ns | 1.87ns | 0.013 | 0 | 0 | 952 B |
#5633 | CallElasticsearchAsync |
netcoreapp3.1 | 1.64μs | 1.01ns | 3.76ns | 0.0139 | 0 | 0 | 1.02 KB |
#5633 | CallElasticsearchAsync |
net472 | 2.67μs | 1.79ns | 6.93ns | 0.166 | 0.00133 | 0 | 1.05 KB |
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | ExecuteAsync |
net6.0 | 1.22μs | 0.793ns | 3.07ns | 0.0135 | 0 | 0 | 952 B |
master | ExecuteAsync |
netcoreapp3.1 | 1.59μs | 0.744ns | 2.88ns | 0.0127 | 0 | 0 | 952 B |
master | ExecuteAsync |
net472 | 1.77μs | 0.786ns | 2.94ns | 0.145 | 0.000887 | 0 | 915 B |
#5633 | ExecuteAsync |
net6.0 | 1.27μs | 0.461ns | 1.72ns | 0.0134 | 0 | 0 | 952 B |
#5633 | ExecuteAsync |
netcoreapp3.1 | 1.68μs | 3.76ns | 14.5ns | 0.0125 | 0 | 0 | 952 B |
#5633 | ExecuteAsync |
net472 | 1.73μs | 1ns | 3.89ns | 0.145 | 0.000868 | 0 | 915 B |
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | SendAsync |
net6.0 | 4.17μs | 1.9ns | 7.35ns | 0.0313 | 0 | 0 | 2.22 KB |
master | SendAsync |
netcoreapp3.1 | 5.1μs | 1.93ns | 7.48ns | 0.0363 | 0 | 0 | 2.76 KB |
master | SendAsync |
net472 | 7.7μs | 3.06ns | 11.8ns | 0.496 | 0 | 0 | 3.12 KB |
#5633 | SendAsync |
net6.0 | 4.22μs | 1.87ns | 7ns | 0.0317 | 0 | 0 | 2.22 KB |
#5633 | SendAsync |
netcoreapp3.1 | 5.02μs | 1.34ns | 5.2ns | 0.0377 | 0 | 0 | 2.76 KB |
#5633 | SendAsync |
net472 | 7.53μs | 1.68ns | 6.5ns | 0.496 | 0 | 0 | 3.12 KB |
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | EnrichedLog |
net6.0 | 1.53μs | 0.64ns | 2.48ns | 0.0229 | 0 | 0 | 1.64 KB |
master | EnrichedLog |
netcoreapp3.1 | 2.1μs | 1.56ns | 6.02ns | 0.0221 | 0 | 0 | 1.64 KB |
master | EnrichedLog |
net472 | 2.58μs | 0.502ns | 1.88ns | 0.249 | 0 | 0 | 1.57 KB |
#5633 | EnrichedLog |
net6.0 | 1.52μs | 0.626ns | 2.34ns | 0.0227 | 0 | 0 | 1.64 KB |
#5633 | EnrichedLog |
netcoreapp3.1 | 2.17μs | 4.29ns | 16ns | 0.0226 | 0 | 0 | 1.64 KB |
#5633 | EnrichedLog |
net472 | 2.44μs | 2.12ns | 8.2ns | 0.25 | 0 | 0 | 1.57 KB |
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | EnrichedLog |
net6.0 | 116μs | 98.5ns | 381ns | 0.0584 | 0 | 0 | 4.28 KB |
master | EnrichedLog |
netcoreapp3.1 | 122μs | 145ns | 563ns | 0.0602 | 0 | 0 | 4.28 KB |
master | EnrichedLog |
net472 | 151μs | 128ns | 498ns | 0.676 | 0.225 | 0 | 4.46 KB |
#5633 | EnrichedLog |
net6.0 | 116μs | 166ns | 641ns | 0.0581 | 0 | 0 | 4.28 KB |
#5633 | EnrichedLog |
netcoreapp3.1 | 121μs | 143ns | 553ns | 0 | 0 | 0 | 4.28 KB |
#5633 | EnrichedLog |
net472 | 152μs | 125ns | 485ns | 0.676 | 0.225 | 0 | 4.46 KB |
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | EnrichedLog |
net6.0 | 3.2μs | 0.969ns | 3.75ns | 0.0304 | 0 | 0 | 2.2 KB |
master | EnrichedLog |
netcoreapp3.1 | 4.19μs | 2.12ns | 8.21ns | 0.0294 | 0 | 0 | 2.2 KB |
master | EnrichedLog |
net472 | 4.86μs | 1.41ns | 5.45ns | 0.321 | 0 | 0 | 2.02 KB |
#5633 | EnrichedLog |
net6.0 | 3.03μs | 0.667ns | 2.58ns | 0.0304 | 0 | 0 | 2.2 KB |
#5633 | EnrichedLog |
netcoreapp3.1 | 4.33μs | 2.14ns | 8.3ns | 0.0283 | 0 | 0 | 2.2 KB |
#5633 | EnrichedLog |
net472 | 4.87μs | 1.01ns | 3.63ns | 0.32 | 0 | 0 | 2.02 KB |
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | SendReceive |
net6.0 | 1.24μs | 0.543ns | 2.1ns | 0.0162 | 0 | 0 | 1.14 KB |
master | SendReceive |
netcoreapp3.1 | 1.75μs | 2.82ns | 10.9ns | 0.0157 | 0 | 0 | 1.14 KB |
master | SendReceive |
net472 | 2.13μs | 1.36ns | 4.9ns | 0.183 | 0 | 0 | 1.16 KB |
#5633 | SendReceive |
net6.0 | 1.36μs | 0.789ns | 3.06ns | 0.0163 | 0 | 0 | 1.14 KB |
#5633 | SendReceive |
netcoreapp3.1 | 1.65μs | 2.24ns | 8.66ns | 0.0148 | 0 | 0 | 1.14 KB |
#5633 | SendReceive |
net472 | 2.08μs | 0.923ns | 3.45ns | 0.183 | 0 | 0 | 1.16 KB |
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | EnrichedLog |
net6.0 | 2.84μs | 0.736ns | 2.85ns | 0.0228 | 0 | 0 | 1.6 KB |
master | EnrichedLog |
netcoreapp3.1 | 4μs | 1.5ns | 5.81ns | 0.022 | 0 | 0 | 1.65 KB |
master | EnrichedLog |
net472 | 4.35μs | 4.94ns | 19.1ns | 0.323 | 0 | 0 | 2.04 KB |
#5633 | EnrichedLog |
net6.0 | 2.85μs | 0.997ns | 3.6ns | 0.0229 | 0 | 0 | 1.6 KB |
#5633 | EnrichedLog |
netcoreapp3.1 | 3.83μs | 1.7ns | 6.59ns | 0.0229 | 0 | 0 | 1.65 KB |
#5633 | EnrichedLog |
net472 | 4.38μs | 2.35ns | 9.12ns | 0.322 | 0 | 0 | 2.04 KB |
Benchmarks.Trace.SpanBenchmark - Slower ⚠️ Same allocations ✔️
Slower ⚠️ in #5633
Benchmark
diff/base
Base Median (ns)
Diff Median (ns)
Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0
1.256
475.98
597.61
Benchmark | diff/base | Base Median (ns) | Diff Median (ns) | Modality |
---|---|---|---|---|
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0 | 1.256 | 475.98 | 597.61 |
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | StartFinishSpan |
net6.0 | 402ns | 0.437ns | 1.69ns | 0.00805 | 0 | 0 | 576 B |
master | StartFinishSpan |
netcoreapp3.1 | 632ns | 0.907ns | 3.51ns | 0.00787 | 0 | 0 | 576 B |
master | StartFinishSpan |
net472 | 654ns | 0.452ns | 1.75ns | 0.0915 | 0 | 0 | 578 B |
master | StartFinishScope |
net6.0 | 476ns | 0.35ns | 1.36ns | 0.00977 | 0 | 0 | 696 B |
master | StartFinishScope |
netcoreapp3.1 | 767ns | 0.95ns | 3.68ns | 0.00955 | 0 | 0 | 696 B |
master | StartFinishScope |
net472 | 843ns | 0.561ns | 2.1ns | 0.104 | 0 | 0 | 658 B |
#5633 | StartFinishSpan |
net6.0 | 400ns | 0.26ns | 1.01ns | 0.00803 | 0 | 0 | 576 B |
#5633 | StartFinishSpan |
netcoreapp3.1 | 646ns | 0.595ns | 2.23ns | 0.00763 | 0 | 0 | 576 B |
#5633 | StartFinishSpan |
net472 | 629ns | 0.535ns | 1.93ns | 0.0915 | 0 | 0 | 578 B |
#5633 | StartFinishScope |
net6.0 | 598ns | 0.506ns | 1.96ns | 0.00963 | 0 | 0 | 696 B |
#5633 | StartFinishScope |
netcoreapp3.1 | 752ns | 0.176ns | 0.657ns | 0.00943 | 0 | 0 | 696 B |
#5633 | StartFinishScope |
net472 | 889ns | 0.649ns | 2.43ns | 0.104 | 0 | 0 | 658 B |
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | RunOnMethodBegin |
net6.0 | 596ns | 0.787ns | 2.84ns | 0.00974 | 0 | 0 | 696 B |
master | RunOnMethodBegin |
netcoreapp3.1 | 883ns | 0.925ns | 3.58ns | 0.00937 | 0 | 0 | 696 B |
master | RunOnMethodBegin |
net472 | 1.07μs | 0.557ns | 2.16ns | 0.104 | 0 | 0 | 658 B |
#5633 | RunOnMethodBegin |
net6.0 | 585ns | 0.333ns | 1.29ns | 0.01 | 0 | 0 | 696 B |
#5633 | RunOnMethodBegin |
netcoreapp3.1 | 901ns | 0.457ns | 1.71ns | 0.00918 | 0 | 0 | 696 B |
#5633 | RunOnMethodBegin |
net472 | 1.08μs | 0.408ns | 1.47ns | 0.104 | 0 | 0 | 658 B |
Summary of changes
This PR automatically register the code coverage percentage of a test session when using the Microsoft.CodeCoverage package in Xml mode.
Reason for change
We already do the same for
coverlet
but we were missing the xml results from the legacyMicrosoft.CodeCoverage
nuget package.Implementation details
Really similar to the
coverlet
integration. In this case instrumenting the managed controller and retrieving the coverage xml files. Process the files and send the coverage percentage using the Ipc mechanism to the test session.Tests
The selenium tests was modified to include Microsoft.CodeCoverage that way we test in a real example if we recive the code coverage payload on the Ipc session.