Capture dump on timeout (#5602)

DataDog · May 23, 2024 · 9efea18 · 9efea18
1 parent 5946a8d
commit 9efea18
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 3 deletions.
diff --git a/profiler/test/Datadog.Profiler.IntegrationTests/Helpers/TestApplicationRunner.cs b/profiler/test/Datadog.Profiler.IntegrationTests/Helpers/TestApplicationRunner.cs
@@ -70,6 +70,19 @@ public void Run(MockDatadogAgent agent)
  PrintTestInfo();
  }
 
+ public bool WaitForExitOrCaptureDump(Process process, int milliseconds)
+ {
+ var success = process.WaitForExit(milliseconds);
+
+ if (!success)
+ {
+ process.GetAllThreadsStack(_testBaseOutputDir, _output);
+ process.TakeMemoryDump(_testBaseOutputDir, _output);
+ }
+
+ return success;
+ }
+
  public ProcessHelper LaunchProcess(MockDatadogAgent agent = null)
  {
  var (executor, arguments) = BuildTestCommandLine();

diff --git a/profiler/test/Datadog.Profiler.IntegrationTests/LinuxOnly/WrapperLibraryTest.cs b/profiler/test/Datadog.Profiler.IntegrationTests/LinuxOnly/WrapperLibraryTest.cs
@@ -87,12 +87,12 @@ public void RedirectCrashHandler(string appName, string framework, string appAss
  var runner = new TestApplicationRunner(appName, framework, appAssembly, _output, enableTracer: true, commandLine: "--scenario 7");
 
  runner.Environment.SetVariable("COMPlus_DbgMiniDumpType", string.Empty);
- 
+
  RegisterCrashHandler(runner);
 
  using var processHelper = runner.LaunchProcess();
 
- processHelper.Process.WaitForExit(milliseconds: 30_000).Should().BeTrue();
+ runner.WaitForExitOrCaptureDump(processHelper.Process, milliseconds: 30_000).Should().BeTrue();
  processHelper.Drain();
  processHelper.ErrorOutput.Should().Contain("Unhandled exception. System.InvalidOperationException: Task failed successfully");
  processHelper.StandardOutput.Should().MatchRegex(@"createdump [\w\.\/]+createdump \d+")
@@ -111,7 +111,7 @@ public void DontRedirectCrashHandlerIfPathNotSet(string appName, string framewor
 
  using var processHelper = runner.LaunchProcess();
 
- processHelper.Process.WaitForExit(milliseconds: 30_000).Should().BeTrue();
+ runner.WaitForExitOrCaptureDump(processHelper.Process, milliseconds: 30_000).Should().BeTrue();
  processHelper.Drain();
  processHelper.ErrorOutput.Should().Contain("Unhandled exception. System.InvalidOperationException: Task failed successfully");
  processHelper.StandardOutput.Should().NotMatchRegex(@"createdump [\w\.\/]+createdump \d+")