Disable crashtracking on Windows

DataDog · Oct 14, 2024 · 0d4f3b3 · 0d4f3b3
1 parent cabf0fd
commit 0d4f3b3
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/shared/src/Datadog.Trace.ClrProfiler.Native/dllmain.cpp b/shared/src/Datadog.Trace.ClrProfiler.Native/dllmain.cpp
@@ -80,7 +80,7 @@ EXTERN_C BOOL STDMETHODCALLTYPE DllMain(HMODULE hModule, DWORD ul_reason_for_cal
  bool telemetry_enabled = true;
  shared::TryParseBooleanEnvironmentValue(shared::GetEnvironmentValue(L"DD_INSTRUMENTATION_TELEMETRY_ENABLED"), telemetry_enabled);
 
- bool crashtracking_enabled = true;
+ bool crashtracking_enabled = false;
  shared::TryParseBooleanEnvironmentValue(shared::GetEnvironmentValue(L"DD_CRASHTRACKING_ENABLED"), crashtracking_enabled);
 
  if (telemetry_enabled && crashtracking_enabled)

diff --git a/tracer/test/Datadog.Trace.Tools.dd_dotnet.ArtifactTests/CreatedumpTests.cs b/tracer/test/Datadog.Trace.Tools.dd_dotnet.ArtifactTests/CreatedumpTests.cs
@@ -35,6 +35,11 @@ public CreatedumpTests(ITestOutputHelper output)
  SetEnvironmentVariable("COMPlus_DbgMiniDumpType", string.Empty);
  SetEnvironmentVariable("COMPlus_DbgEnableMiniDump", string.Empty);
  SetEnvironmentVariable("DD_INSTRUMENTATION_TELEMETRY_ENABLED", string.Empty);
+
+ if (RuntimeInformation.IsOSPlatform(OSPlatform.Windows))
+ {
+ SetEnvironmentVariable("DD_CRASHTRACKING_ENABLED", "1");
+ }
  }
 
  private static (string Key, string Value) LdPreloadConfig