[RUM-6255] Auto-Instrumented Native WebView #732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![datadog-datadog-prod-us1[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
packages/react-native-webview/src/__tests__/WebviewDatadog.test.tsx
Outdated
Show resolved
Hide resolved
marco-saia-datadog
force-pushed
the
marcosaia/RUM-6255/native-webview
branch
from
5f75dfe
to
be62b5b
Compare
0xnm
reviewed
Oct 16, 2024
...ew/android/src/main/kotlin/com/datadog/reactnative/webview/DdSdkReactNativeWebViewManager.kt
Outdated
Show resolved
Hide resolved
...ew/android/src/main/kotlin/com/datadog/reactnative/webview/DdSdkReactNativeWebViewManager.kt
Outdated
Show resolved
Hide resolved
...ew/android/src/main/kotlin/com/datadog/reactnative/webview/DdSdkReactNativeWebViewManager.kt
Outdated
Show resolved
Hide resolved
...ct-native-webview/android/src/test/kotlin/com/datadog/reactnative/tools/unit/ReflectUtils.kt
Outdated
Show resolved
Hide resolved
...ct-native-webview/android/src/test/kotlin/com/datadog/reactnative/tools/unit/ReflectUtils.kt
Outdated
Show resolved
Hide resolved
...ct-native-webview/android/src/test/kotlin/com/datadog/reactnative/tools/unit/ReflectUtils.kt
Outdated
Show resolved
Hide resolved
...ct-native-webview/android/src/test/kotlin/com/datadog/reactnative/tools/unit/ReflectUtils.kt
Outdated
Show resolved
Hide resolved
...ct-native-webview/android/src/test/kotlin/com/datadog/reactnative/tools/unit/ReflectUtils.kt
Outdated
Show resolved
Hide resolved
0xnm
reviewed
Nov 15, 2024
...native-webview/android/src/test/kotlin/com/datadog/reactnative/webview/DatadogWebViewTest.kt
Show resolved
Hide resolved
...native-webview/android/src/test/kotlin/com/datadog/reactnative/webview/DatadogWebViewTest.kt
Show resolved
Hide resolved
marco-saia-datadog
force-pushed
the
marcosaia/RUM-6255/native-webview
branch
from
a5fdb9c
to
36c3d39
Compare
0xnm
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Introduces a native implementation for
@datadog/mobile-react-native-webview, to allow fully fledged auto-instrumentation of WebView(s).How does it work?
The implementation leverages react-native-webview APIs.
We define a custom WebView, ViewManager and WebViewClient and we enable WebView tracking on new WebView instances by using the DD Native APIs.
Notes
TODO
react-native-webviewpeer dependencyReview checklist (to be filled by reviewers)