Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RUM-5744] iOS: exclude DatadogWebViewTracking in tvOS #719

Merged
merged 1 commit into from
Aug 26, 2024
Merged

[RUM-5744] iOS: exclude DatadogWebViewTracking in tvOS #719

merged 1 commit into from
Aug 26, 2024

Conversation

marco-saia-datadog
Copy link
Member

What does this PR do?

Only install DatadogWebViewTracking on target iOS, since it does not support tvOS.

Additional Notes

Tested with https://github.com/DataDog/dd-sdk-reactnative-examples/tree/main/rum-react-native-tvos

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)
  • If this PR is auto-generated, please make sure also to manually update the code related to the change

@marco-saia-datadog marco-saia-datadog requested a review from a team as a code owner August 26, 2024 13:17
@marco-saia-datadog marco-saia-datadog merged commit 2365f6d into develop Aug 26, 2024
6 checks passed
@marco-saia-datadog marco-saia-datadog deleted the marcosaia/RUM-5744/tvos-compatibility branch August 26, 2024 13:40
@marco-saia-datadog marco-saia-datadog mentioned this pull request Aug 26, 2024
Closed
@marco-saia-datadog marco-saia-datadog mentioned this pull request Oct 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xnm 0xnm 0xnm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marco-saia-datadog @0xnm