Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX #707] Replace ChoreographerCompat with Choreographer #708

Merged

Conversation

marco-saia-datadog
Copy link
Member

What does this PR do?

Fixes build error caused by the removal of ChoreographerCompat in RN 74 with this commit: facebook/react-native@248c324 in this PR: facebook/react-native#39775.

The PR replaces the implementation with Choreographer.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)
  • If this PR is auto-generated, please make sure also to manually update the code related to the change

@marco-saia-datadog marco-saia-datadog marked this pull request as ready for review July 26, 2024 12:35
@marco-saia-datadog marco-saia-datadog requested a review from a team as a code owner July 26, 2024 12:35
@marco-saia-datadog marco-saia-datadog merged commit 1656ad3 into develop Jul 26, 2024
6 checks passed
@marco-saia-datadog marco-saia-datadog deleted the marcosaia/issue-707/fix-choreographer-compat branch July 26, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants