Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RUM-3813] Support custom error fingerprinting #700

Merged
merged 1 commit into from
Jul 15, 2024
Merged

[RUM-3813] Support custom error fingerprinting #700

merged 1 commit into from
Jul 15, 2024

Conversation

marco-saia-datadog
Copy link
Member

@marco-saia-datadog marco-saia-datadog commented Jul 12, 2024 •
edited
Loading

What does this PR do?

Adds custom fingerprint attribute to addError and DdLogs with error.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)
  • If this PR is auto-generated, please make sure also to manually update the code related to the change

@marco-saia-datadog marco-saia-datadog force-pushed the marcosaia/RUM-3813/custom-error-fingerprint branch from 82f2dfb to bbdaf98 Compare July 12, 2024 16:55
@marco-saia-datadog marco-saia-datadog changed the title [RUM-3813] Added custom fingerprint to addError and logs with error [RUM-3813] Support custom error fingerprinting Jul 12, 2024
@marco-saia-datadog marco-saia-datadog force-pushed the marcosaia/RUM-3813/custom-error-fingerprint branch 2 times, most recently from e5d4050 to 854a3d1 Compare July 12, 2024 17:40
@marco-saia-datadog marco-saia-datadog force-pushed the marcosaia/RUM-3813/custom-error-fingerprint branch from 854a3d1 to 3b66240 Compare July 15, 2024 12:31
@marco-saia-datadog marco-saia-datadog marked this pull request as ready for review July 15, 2024 13:13
@marco-saia-datadog marco-saia-datadog requested a review from a team as a code owner July 15, 2024 13:13
@marco-saia-datadog marco-saia-datadog merged commit 469e328 into develop Jul 15, 2024
6 checks passed
@marco-saia-datadog marco-saia-datadog deleted the marcosaia/RUM-3813/custom-error-fingerprint branch July 15, 2024 16:06
This was referenced Jul 17, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xnm 0xnm 0xnm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marco-saia-datadog @0xnm