Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RUM-4019] Android: improved bundle task args resolving #688

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

[RUM-4019] Android: improved bundle task args resolving #688

wants to merge 1 commit into from

Conversation

marco-saia-datadog
Copy link
Member

@marco-saia-datadog marco-saia-datadog commented Jul 8, 2024 •
edited
Loading

What does this PR do?

Improves how JS Bundle Task path arguments are resolved, as in some cases reactConfig.bundleAssetName and reactConfig.bundleFileResolver() might not be accurate.

Additional Notes

It is also possible to override the paths with the following env variables:

  • DATADOG_BUNDLE_OUTPUT
  • DATADOG_SOURCEMAP_OUTPUT

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)
  • If this PR is auto-generated, please make sure also to manually update the code related to the change

@marco-saia-datadog marco-saia-datadog force-pushed the marcosaia/RUM-4019/bundle-task-args-resolve branch 3 times, most recently from 28bea3d to 11565c0 Compare July 8, 2024 10:18
@marco-saia-datadog marco-saia-datadog marked this pull request as ready for review July 15, 2024 13:54
@marco-saia-datadog marco-saia-datadog requested a review from a team as a code owner July 15, 2024 13:54
0xnm
0xnm approved these changes Jul 15, 2024
View reviewed changes
packages/core/datadog-sourcemaps.gradle Outdated Show resolved Hide resolved
@marco-saia-datadog marco-saia-datadog force-pushed the marcosaia/RUM-4019/bundle-task-args-resolve branch from 11565c0 to bd131ca Compare July 17, 2024 10:56
@marco-saia-datadog marco-saia-datadog added the Do not merge This PR is not ready to be merged yet label Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathanmos jonathanmos jonathanmos approved these changes

@0xnm 0xnm 0xnm approved these changes

Assignees
No one assigned
Labels
Do not merge This PR is not ready to be merged yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marco-saia-datadog @0xnm @jonathanmos