Pass font size to text wireframe builder #581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louiszawadzki
force-pushed
the
louiszawadzki/fix-font-size-for-ios-SR
branch
from
6bf40c6
to
07739e9
Compare
maciejburda
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When removing the
fontargument tocreateTextWireframewe lost the information of the font size (link to PR).We can now pass directly a
fontSizeargument to this method since this PR.Additional Notes
We used to call
shadowNode.textAttributes.effectiveFont()which sets the font size to a default value of14when it isNaN. I replicated the same logic here (passingNaNwould not render the text element).Review checklist (to be filled by reviewers)