Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix webview telemetry for new architecture apps #542

Merged
merged 2 commits into from
Oct 25, 2023

Conversation

louiszawadzki
Copy link
Contributor

@louiszawadzki louiszawadzki commented Oct 25, 2023

What does this PR do?

Uses the new TurboModule for calling telemetryError in the Webview support package.
We were trying to access NativeModules.DdSdk before, which would not be defined for the new architecture. The impact would be that in that case we would not call telemetryError, so not a big impact.

This PR makes sure we call the correct module in any case.

Test for this feature will come in #541 when we run every package in isolation.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)
  • If this PR is auto-generated, please make sure also to manually update the code related to the change

@louiszawadzki louiszawadzki requested a review from a team as a code owner October 25, 2023 12:57
@louiszawadzki louiszawadzki merged commit 1743791 into develop Oct 25, 2023
4 checks passed
@louiszawadzki louiszawadzki deleted the louiszawadzki/fix-webview-new-architecture branch October 25, 2023 13:26
louiszawadzki added a commit that referenced this pull request Oct 30, 2023
…chitecture

Fix webview telemetry for new architecture apps
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants