Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Github token reference #282

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

0xnm
Copy link
Member

@0xnm 0xnm commented Jul 16, 2024

What does this PR do?

Service account repo cannot access ci.dd-sdk-android.* namespace, so updating to the repo-specific namespace.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm 0xnm requested review from a team as code owners July 16, 2024 15:30
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.12%. Comparing base (96a89fa) to head (76ee187).

Additional details and impacted files
@@              Coverage Diff              @@
##             develop     #282      +/-   ##
=============================================
- Coverage      78.23%   78.12%   -0.11%     
  Complexity       251      251              
=============================================
  Files             31       31              
  Lines            914      914              
  Branches         114      114              
=============================================
- Hits             715      714       -1     
- Misses           147      148       +1     
  Partials          52       52              

see 1 file with indirect coverage changes

@0xnm 0xnm merged commit f94132c into develop Jul 16, 2024
13 checks passed
@0xnm 0xnm deleted the nogorodnikov/update-github-token-credential-reference branch July 16, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants