Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add uploading section to README. #281

Merged
merged 2 commits into from
Jul 5, 2024
Merged

Conversation

fuzzybinary
Copy link
Member

What does this PR do?

Add an Uploading section for the README which includes instructions for uploading mapping files and NDK symbol files

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@fuzzybinary fuzzybinary requested review from a team as code owners July 5, 2024 13:54
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Jul 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.68%. Comparing base (32fa206) to head (e3e6dbf).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop     #281      +/-   ##
=============================================
- Coverage      78.01%   77.68%   -0.33%     
+ Complexity       251      248       -3     
=============================================
  Files             31       31              
  Lines            914      914              
  Branches         114      114              
=============================================
- Hits             713      710       -3     
- Misses           148      150       +2     
- Partials          53       54       +1     

see 1 file with indirect coverage changes

Copy link

@michaelcretzman michaelcretzman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend adding the suggested change by Oxnm.

Co-authored-by: Nikita Ogorodnikov <[email protected]>
@fuzzybinary fuzzybinary requested a review from 0xnm July 5, 2024 15:16
@fuzzybinary fuzzybinary merged commit 96a89fa into develop Jul 5, 2024
13 checks passed
@fuzzybinary fuzzybinary deleted the jward/readme-update branch July 5, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants