Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the statement from README that logs are not deobfuscated #275

Merged

Conversation

0xnm
Copy link
Member

@0xnm 0xnm commented Jun 12, 2024

What does this PR do?

We support deobfuscation for logs for a long time already, so removing false statement.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm 0xnm requested review from a team as code owners June 12, 2024 13:27
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.12%. Comparing base (fe2c9b6) to head (4c2ebbb).

Additional details and impacted files
@@              Coverage Diff              @@
##             develop     #275      +/-   ##
=============================================
- Coverage      78.34%   78.12%   -0.22%     
+ Complexity       254      253       -1     
=============================================
  Files             31       31              
  Lines            914      914              
  Branches         114      114              
=============================================
- Hits             716      714       -2     
- Misses           147      148       +1     
- Partials          51       52       +1     

see 3 files with indirect coverage changes

@0xnm 0xnm merged commit f61aae1 into develop Jun 13, 2024
13 checks passed
@0xnm 0xnm deleted the nogorodnikov/remove-statement-that-logs-are-not-deobfuscated branch June 13, 2024 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants