Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install NDK 25.1.8937393 in the Docker image #248

Merged
merged 2 commits into from
Apr 15, 2024

Conversation

0xnm
Copy link
Member

@0xnm 0xnm commented Apr 15, 2024

What does this PR do?

Build script is using NDK 25.1.8937393 while Docker contains the older one, so we were wasting some time to download the necessary NDK version during the build process.

This PR updates NDK version to the necessary one in the Docker image.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm 0xnm requested review from a team as code owners April 15, 2024 13:55
@codecov-commenter
Copy link

Codecov Report

Merging #248 (e1f04f3) into develop (924006b) will decrease coverage by 0.08%.
The diff coverage is n/a.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop     #248      +/-   ##
=============================================
- Coverage      81.50%   81.42%   -0.08%     
- Complexity       203      204       +1     
=============================================
  Files             26       26              
  Lines            800      802       +2     
  Branches         103      104       +1     
=============================================
+ Hits             652      653       +1     
  Misses           112      112              
- Partials          36       37       +1     

see 1 file with indirect coverage changes

@0xnm 0xnm merged commit 81aace0 into develop Apr 15, 2024
13 checks passed
@0xnm 0xnm deleted the nogorodnikov/update-ndk-to-25-in-docker-image branch April 15, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants