Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUM-713 Allow customer to use non standard obfuscation #199

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

xgouchet
Copy link
Member

What does this PR do?

Adds a nonDefaultObfuscation option in the extension for our plugin. This will create an uploadTask even if the Android minifyEnabled option is false

Motivation

Among others, Dexguard users are not using Android's minifyEnabled which relies on the default R8/Proguard obfuscation. For those users, the upload task wasn't created even on variants using DexGuard who needed it.

Fixes #132

Usage

datadog {
    nonDefaultObfuscation = true
    mappingFilePath = "custom/path/to/mapping.txt"
}

@xgouchet xgouchet requested a review from a team as a code owner October 10, 2023 13:21
fuzzybinary
fuzzybinary previously approved these changes Oct 10, 2023
/**
* This property declares that the obfuscation technology used is not the default
* R8/Proguard included in the Android toolchain (e.g.: Dexguard, …).
* Doing so will create an upload task for all variants and all
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incomplete thought in this coment.

0xnm
0xnm previously approved these changes Oct 10, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #199 (5e2931f) into develop (288840c) will decrease coverage by 0.03%.
The diff coverage is 88.89%.

@@              Coverage Diff              @@
##             develop     #199      +/-   ##
=============================================
- Coverage      86.08%   86.05%   -0.03%     
- Complexity       177      181       +4     
=============================================
  Files             21       21              
  Lines            582      588       +6     
  Branches          76       78       +2     
=============================================
+ Hits             501      506       +5     
- Misses            53       55       +2     
+ Partials          28       27       -1     
Files Coverage Δ
.../datadog/gradle/plugin/DdExtensionConfiguration.kt 100.00% <100.00%> (ø)
...com/datadog/gradle/plugin/DdAndroidGradlePlugin.kt 74.38% <87.50%> (+0.02%) ⬆️

@xgouchet xgouchet merged commit 7dec088 into develop Oct 10, 2023
3 checks passed
@xgouchet xgouchet deleted the xgouchet/RUMM-2899/dexguard branch October 10, 2023 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to upload mapping file using Dexguard
4 participants