feat: add support for distributed traces #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majorgreys
force-pushed
the
majorgreys/trace-chunk
branch
from
f3a2bb4
to
761cbcd
Compare
There was a problem hiding this comment.
We should have an integration snapshot test with a distributed trace (shouldn't be too bad to add to test_snapshot_integration.py).
We'll have to figure out if we should leave the parent id as it is received or if we normalize it at all. I also suspect the snapshot logic assumes that all span ids have corresponding spans in the trace
majorgreys
force-pushed
the
majorgreys/trace-chunk
branch
from
761cbcd
to
f41a756
Compare
majorgreys
force-pushed
the
majorgreys/trace-chunk
branch
from
f41a756
to
b2b2544
Compare
|
Blocked on DataDog/sketches-py#55 |
|
DataDog/sketches-py#55 merged and released: https://pypi.org/project/ddsketch/2.0.3/ |
There was a problem hiding this comment.
can we just add a bullet point here: https://github.com/DataDog/dd-apm-test-agent#snapshot-output
to state how distributed traces (when some spans aren't sent) are handled?
once that's done then LGTM 🙌
Co-authored-by: Kyle Verhoog <[email protected]>
Kyle-Verhoog
approved these changes
May 27, 2022
brettlangdon
approved these changes
May 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for distributed traces where an instrumented service sends a trace chunk where the root span has a parent not in the trace chunk.