[Orch] Add CRD RC handler #1340
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1340 +/- ##
==========================================
- Coverage 49.01% 48.78% -0.24%
==========================================
Files 223 224 +1
Lines 19508 19623 +115
==========================================
+ Hits 9562 9573 +11
- Misses 9456 9560 +104
Partials 490 490
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
pkg/remoteconfig/updater.go
Outdated
| CoreAgent *CoreAgentFeaturesConfig `json:"config,omitempty"` | ||
| SystemProbe *SystemProbeFeaturesConfig `json:"system_probe,omitempty"` | ||
| SecurityAgent *SecurityAgentFeaturesConfig `json:"security_agent,omitempty"` | ||
| CRDs *CustomResourceDefinitionURLs `json:"crds,omitempty"` |
There was a problem hiding this comment.
Take this with a grain of salt since I'm not too familiar with the operator, but this looks to me like structurally, configs are broken out by agent binary. Should the CRD configs be wrapped inside a ClusterAgentFeatureConfig type?
There was a problem hiding this comment.
Yeah that's a great call. I think this is a good idea for future work
pkg/remoteconfig/updater.go
Outdated
| @@ -137,7 +146,7 @@ func (r *RemoteConfigUpdater) Start(apiKey string, site string, clusterName stri | |||
| "", | |||
| r.serviceConf.baseRawURL, | |||
| r.serviceConf.hostname, | |||
| []string{fmt.Sprintf("cluster_name:%s", r.serviceConf.clusterName)}, | |||
| r.getTags, | |||
There was a problem hiding this comment.
This is a required breaking change
JLineaweaver
force-pushed
the
jlineaweaver/cap-1652
branch
2 times, most recently
from
72892db
to
994024f
Compare
What does this PR do?
Adds remote config support for custom resources in the operator. This new code will merge the user defined configuration with the configuration stored in remote config. Operator users with remote config enabled should no longer require a custom operator configuration to send custom resources.
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Minimum Agent Versions
Are there minimum versions of the Datadog Agent and/or Cluster Agent required?
Describe your test plan
Write there any instructions and details you may have to test your PR.
Checklist
bug,enhancement,refactoring,documentation,tooling, and/ordependenciesqa/skip-qalabel