Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added saml configurations model #2772

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

pawel-macionczyk
Copy link

@pawel-macionczyk pawel-macionczyk commented Nov 8, 2024

What does this PR do?

In the Terraform Provider for Datadog there is a missing feature for uploading SAML Metadata XML file.
The endpoint for doing that already exists in Datadog API: Upload IdP Metadata. It is also implemented in this repo.

The endpoint references to version V2 and has only one subpath. That's why I decided to create a new structure called "Saml Configurations" -> like the last but one subpath in endpoint. For now the structure contains only IdpMetadata but using this approach will let others extend this feature in the future.

The provided structure is created based on other models in api/datadogV2 directory and is used in the PR in Terraform Provider for Datadog repo.

Additional Notes

This PR should be merged first. Then I can reference a stable version of this repo in the go.mod in Terraform Provider for Datadog.

Review checklist

Please check relevant items below:

  • This PR includes all newly recorded cassettes for any modified tests.

  • This PR does not rely on API client schema changes.

    • The CI should be fully passing.
  • Or, this PR relies on API schema changes and this is a Draft PR to include tests for that new functionality.

    • Note: CI shouldn't be run on this Draft PR, as its expected to fail without the corresponding schema changes.

Copy link

This PR has been automatically marked as stale because it has not had activity in the last 30 days.
If there is no activity for another 90 days, this issue will be automatically closed.

@github-actions github-actions bot added the stale Stale - Bot reminder label Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Stale - Bot reminder
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant