Start improving local deployments #136
Conversation
| dev_version="$1" | ||
| AZDO_PAT=$2 | ||
|
|
||
| dotnet nuget add source https://pkgs.dev.azure.com/datadoghq/dd-trace-dotnet/_packaging/Public_Feed/nuget/v3/index.json --name Public_Feed --username any_string --password $AZDO_PAT --store-password-in-clear-text |
There was a problem hiding this comment.
I'm wary of using this ever since I've been burnt in the past as artifiacts go in, are never removed, use up your allowance, and kill all CI... so on your head be-it 😛
There was a problem hiding this comment.
🤔 , Thanks for raising this, I didn't see this as a potential issue.
Here, we will do this only for testing changing on the extension itself and its setup, which is quite rare. So I assume it lowers the risk.
That said, we planned to do that on nightly builds, where the impact would be greater. I'll discuss it with @shurivich as well as they used to do that in Ozcode.
There was a problem hiding this comment.
I may just be scare-mongering, it's just something I avoid in personal projects now 🙂 Oh wait... maybe that was GitHub... pfft, I forget 😂
pierotibou
changed the title
dotnet/build-packages-dev.sh
Outdated
| echo "Downloading agent from ${AGENT_DOWNLOAD_URL}" | ||
| wget -O agent.zip $AGENT_DOWNLOAD_URL | ||
| #wget -O agent.zip $AGENT_DOWNLOAD_URL |
There was a problem hiding this comment.
Does this need to be uncommented?
There was a problem hiding this comment.
yep... Thanks a lot for catching it
There was a problem hiding this comment.
done in 802a5e5
dotnet/build-packages-dev.sh
Outdated
| TRACER_DOWNLOAD_URL="https://apmdotnetci.blob.core.windows.net/apm-dotnet-ci-artifacts-master/$TRACER_SHA/windows-tracer-home.zip" | ||
|
|
||
| echo "Downloading tracer from $TRACER_DOWNLOAD_URL" | ||
| #wget -O tracer.zip $TRACER_DOWNLOAD_URL |
There was a problem hiding this comment.
Does this need to be uncommented?
There was a problem hiding this comment.
done in 802a5e5
| @@ -0,0 +1,7 @@ | |||
| INSTALL_SHA="38787d2e9cadd408f541675e95fab7b9a687d559" | |||
There was a problem hiding this comment.
I get how the SHA is set for the GitHub Action, but is this also supposed to work right with a local dev build or is that out of scope?
There was a problem hiding this comment.
That's out of scope. As said in the description, 2 things are not yet handled: use a local tracer, and modify where the files are modified to avoid having to revert modified files (as the build process do a lot of sed to change the version)
Allow deploying a nuget to the dev package feed with local AAS modification (xdt files, packaging...).
To do so, I tried to reuse what Alexander had setup for nightly deploys. So we now have
deploy-packages-local.shthat will call the same scripts given a tracer sha and a package version.I've also added a bit of cleanup for this process to be ran several times (remove intermediary files, .gitignore).
There are still a few things to improve. The main ones being:
I've tested the changes, both locally, and on the deploy github action (cf this run )