Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chaosplt 207] namespace tag gone #936

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[chaosplt 207] namespace tag gone #936

wants to merge 3 commits into from

Conversation

clairecng
Copy link
Contributor

@clairecng clairecng commented Nov 21, 2024 •
edited
Loading

What does this PR do?

  • Adds new functionality
  • Alters existing functionality
  • Fixes a bug
  • Improves documentation or testing

Please briefly describe your changes as well as the motivation behind them:

  • Finally remove all of the bad namespaces tags
  • removes instance tag
  • move every recurrent tag to use consts from log pkg

Our logs were using multiple different tags for the same resource.

Code Quality Checklist

  • The documentation is up to date.
  • My code is sufficiently commented and passes continuous integration checks.
  • I have signed my commit (see Contributing Docs).

Testing

  • I leveraged continuous integration testing
    • by depending on existing unit tests or end-to-end tests.
    • by adding new unit tests or end-to-end tests.
  • I manually tested the following steps:
    • x
    • locally.
    • as a canary deployment to a cluster.

ptnapoleon
ptnapoleon reviewed Nov 21, 2024
View reviewed changes
api/v1beta1/disruption_webhook.go Outdated
@@ -113,7 +114,7 @@ var _ webhook.Defaulter = &Disruption{}
// Default implements webhook.Defaulter so a webhook will be registered for the type
func (r *Disruption) Default() {
if r.Spec.Duration.Duration() == 0 {
logger.Infow(fmt.Sprintf("setting default duration of %s in disruption", defaultDuration), "instance", r.Name, "namespace", r.Namespace)
logger.Infow(fmt.Sprintf("setting default duration of %s in disruption", defaultDuration), cLog.DisruptionNameKey, r.Name, cLog.DisruptionNamespaceKey, r.Namespace)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is gonna disappear on rebase

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Nov 22, 2024 •
edited
Loading

Datadog Report

Branch report: claire.chong/chaosplt-207/namespace-tag-gone
Commit report: 4cbcee5
Test service: chaos-controller

✅ 0 Failed, 978 Passed, 8 Skipped, 14m 37.08s Total Time

@clairecng clairecng marked this pull request as ready for review November 22, 2024 14:05
@clairecng clairecng requested a review from a team as a code owner November 22, 2024 14:05
aymericDD
aymericDD approved these changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@aymericDD aymericDD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧽

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aymericDD aymericDD aymericDD approved these changes

@ptnapoleon ptnapoleon ptnapoleon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@clairecng @ptnapoleon @aymericDD