Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
We need more tests over the whole ecosystem, to confirm we ship something that is working as expected, and not realise something's broken after it's been shipped.
How?
This PR adds a lot of tests, doing so, it also revealed some major bugs, especially around the injection plugin.
I had to fix those as well.
yarn loop
.inject
config point, mutating the configuration for the whole list of plugins (client side). This had the effect of breaking every sub builds, because they were re-using the configuration (with the newinject
config) but changing the plugins, thus removing our resolver and breaking the resolution of our injected file.doRequest
in the telemetry plugin.runBundlers
helper.