Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[testing] More testing #104

Draft
wants to merge 30 commits into
base: master
Choose a base branch
from
Draft

[testing] More testing #104

wants to merge 30 commits into from

Conversation

yoannmoinet
Copy link
Member

@yoannmoinet yoannmoinet commented Oct 9, 2024

What and why?

We need more tests over the whole ecosystem, to confirm we ship something that is working as expected, and not realise something's broken after it's been shipped.

How?

This PR adds a lot of tests, doing so, it also revealed some major bugs, especially around the injection plugin.
I had to fix those as well.

  • Minor linting updates.
  • Minor local dev scripts updates, factorising some scripts using yarn loop.
  • Add a bunch of helpers for the injection plugin.
  • Completely change how we do injection with esbuild:
    • We used to inject through the inject config point, mutating the configuration for the whole list of plugins (client side). This had the effect of breaking every sub builds, because they were re-using the configuration (with the new inject config) but changing the plugins, thus removing our resolver and breaking the resolution of our injected file.
  • Fix the build report following the new injection process.
  • Fix the internal plugin names.
  • Factorise the usage of doRequest in the telemetry plugin.
  • Some minor jest updates, helpers, configs, mocks...
  • Update how we run and handle errors for our runBundlers helper.
  • Add tests, a lot.
    • Especially for the build and verify that what we ship actually works IRL. Also add a warning when we run this test with an outdated build.
  • Copy files that are necessary to unplugin to work with their custom loaders.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant