Explicitly initialize AWS instance status object #103
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where on AWS, a long-unregistered node would completely block scale-ups.
e5bc070 changed the behavior of
getNotRegisteredNodes
to filter out nodes that were not expected to register withHowever, the
instance.Status
field is optional, and not all cloud providers set this. Notably, AWS did not initialize this unless a 'placeholder' instance was set, such that in normal circumstances, AWS instances will havenil
as a status. This meant thatexpectedToRegister
would return false, and the host would not have an entry appended to thenotRegistered
slice of nodes.This explicitly initializes AWS's instanceStatus struct, which means that for a long unregistered node,
expectedToRegister
should now properly returntrue
, and the normal mechanisms for clearing a long unregistered node can operate on it.