fix option

DataDog · Jun 14, 2024 · db624a5 · db624a5
1 parent 60df670
commit db624a5
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/cluster-autoscaler/expander/grpcplugin/grpc_client.go b/cluster-autoscaler/expander/grpcplugin/grpc_client.go
@@ -105,7 +105,6 @@ func (g *grpcclientstrategy) BestOptions(expansionOptions []expander.Option, nod
 		klog.V(4).Info("Unable to sanitize GPRC returned bestOptions, no options filtered")
 		return expansionOptions
 	}
-	// We would want these options to only have the similar nodegroups that the expander has not filtered out
 	return options
 }
 

diff --git a/cluster-autoscaler/main.go b/cluster-autoscaler/main.go
@@ -178,7 +178,7 @@ var (
 
 	grpcExpanderCert                          = flag.String("grpc-expander-cert", "", "Path to cert used by gRPC server over TLS")
 	grpcExpanderURL                           = flag.String("grpc-expander-url", "", "URL to reach gRPC expander server.")
-	includeSimilarNodegroupsInExpanderOptions = flag.Bool("include-similar-nodegroups-in-expander-options", false, "if true, similar nodegroups will be included in the BestOptions request to the expander")
+	includeSimilarNodegroupsInExpanderOptions = flag.Bool("include-similar-nodegroups-in-expander-options", false, "If true, similar nodegroups will be included in the BestOptions sent to and returned by expander")
 
 	ignoreDaemonSetsUtilization = flag.Bool("ignore-daemonsets-utilization", false,
 		"Should CA ignore DaemonSet pods when calculating resource utilization for scaling down")