fix: python version locking #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The current version is set to the current AWS Glue release (v4). Allowing to install higher versions, will cause confusion for final users. |
|
@shahinism I see your point, but Glue is the host. Sparkle supposed to ran on any spark platform including azure synapse as well. Maybe we can move the constraints to Damavand implementation for AWS? |
shahinism
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, Sparkle locked requireed-python version to exact 3.10.14 which causes issues when in a project the python version is higher. This PR suggest a minimum version for both pyspark and python instead of locking to specific version.