feat: add table reader #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
farbodahm
force-pushed
the
feature/add-iceberg-reader
branch
from
1096f70
to
8919420
Compare
shahinism
reviewed
Sep 5, 2024
| Returns: | ||
| str: The fully qualified table name in the format "catalog_name.database_name.table_name". | ||
| """ | ||
| return f"{self.catalog_name}.{self.database_name}.{self.table_name}" |
There was a problem hiding this comment.
Should we consider this format only works/is required for Iceberg tables?
There was a problem hiding this comment.
Have look at test_read_table test. Non-Iceberg table is also working with this format.
farbodahm
force-pushed
the
feature/add-iceberg-reader
branch
from
935b93a
to
dccd628
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR: