feat: spark etl application #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the cloud connection class along with controller factories was creating a fully connected dependency graph that required user to install all damavand dependencies. Also, it was redundent. Removing cloud connection and implementing the factory design pattern with generics improves the open/close principal implementation.
This reverts commit 7b25e27.
feat: refactor sparkle example
bugfix: core api controllers
|
This PR is already got huge. Previously, as I was the only developer wasn't a problem but since @callarelli93 is joining me now this is getting complex. Since we are not on any stable release yet, we decided to merge it to main for now and start putting the main branch as point of reference. |
callarelli93
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.