feat: refactor sparkle example #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkiani
force-pushed
the
feature/refactor-sparkle-example
branch
from
b0720a3
to
e4af94e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The example was only using Azure Synapse component to provision resources. This PR fix the sample to showcase the how to leverage damavand using the factory controllers. Furthermore, during developing the example I noticed that sparkle requires the spark session to be passed right away during initialization which is not possible with the current interface of spark controller. To fix this I removed the applications as init parameters of the controller and open the access to add applications later after the initialization of the controller.