Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] Experiment with WDS App Insights metrics reduction #4493

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from
Draft

[DO NOT MERGE] Experiment with WDS App Insights metrics reduction #4493

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
70b791a
use my test version of wds without jumping through a bunch of hoops
May 2, 2024
d9aa90a
update image in reference.conf
May 2, 2024
6bc2f2d
bump
May 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions http/src/main/resources/reference.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -386,6 +386,7 @@ azure {
wds-app-config {
environment = "dev"
environment-base = "live"
image: "us-central1-docker.pkg.dev/dsp-artifact-registry/mf-dataplane-metrics-wip/wds:insights"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Often to avoid the whole Leo dance I just kubectl edit deploy on a live WDS/CBAS/etc deployment to change the image and iterate.

Copy link
Author

@mikeflinn mikeflinn May 2, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! yeah I know that's faster. wanted to test something end to end :) With a fresh landing zone and clean deploy of wds. I don't actually need to iterate on WDS itself that much. The change I'm making is a one liner. But it's going to be hard to tell if it did the right thing in pre-existing landing zone with a bunch of other WDSes in it.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also apparently I don't have kubectl access to landing zone aks clusters and I'm not sure how give that access to myself. I'm being blocked by deny assignments. I am in the terra-workspace-dev AD group

instrumentation-enabled = false
chart-name = "terra-helm/wds"
chart-version = "0.76.0"
Expand Down
1 change: 1 addition & 0 deletions http/src/main/scala/org/broadinstitute/dsde/workbench/leonardo/app/WdsAppInstall.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@ class WdsAppInstall[F[_]](config: WdsAppConfig,
// pass enviiroment information to wds so it can properly pick its config
raw"wds.environment=${config.environment}",
raw"wds.environmentBase=${config.environmentBase}",
raw"wds.image=${config.image}",

// azure resources configs
raw"config.resourceGroup=${params.cloudContext.managedResourceGroupName.value}",
Expand Down
1 change: 1 addition & 0 deletions ...rc/main/scala/org/broadinstitute/dsde/workbench/leonardo/config/KubernetesAppConfig.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,6 +173,7 @@ final case class WdsAppConfig(chartName: ChartName,
databaseEnabled: Boolean,
environment: String,
environmentBase: String,
image: String,
chartVersionsToExcludeFromUpdates: List[ChartVersion]
) extends KubernetesAppConfig {
override lazy val kubernetesServices: List[KubernetesService] = services.map(s => KubernetesService(ServiceId(-1), s))
Expand Down
Loading