FE-231 upgrade aiohttp to 3.9.4 #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 52420cb.
… into FE-231-upgrade-aiohttp-to-3.9.4
…ather than using decorators or config files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
FE-231
The library aiohttp has a high severity vulnerability that could lead to denial of service attacks against the service. This vulnerability has been fixed in version 3.9.4.
The version found in import service is 3.9.2.
This PR
Sets the aiohttp version to 3.9.4.
Pytests were run locally, and are run when this PR is opened to merge to main.
note that the e2e tests are currently disabled
The updated image was deployed to dev and the validation pipeline was run to prove that this did not break our ability to reach the Dagster repository.
Smoke tests will also be run on prod after deploy, if they fail, the last known good image will be deployed.
Checklist