Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asus: Remove System.Management #335

Merged

Conversation

Aytackydln
Copy link
Contributor

I've had dependency problem with Aurora and my only solution was this. I know this is project specific change but I think this dependency is unnecessary anyway.

It should be removed so that it won't be problem for other projects in the future.

@DarthAffe
Copy link
Owner

what is the issue with the dependency?
since this is quite a major breaking change for the provider i'd prefer to fix the actual problem.

@Aytackydln
Copy link
Contributor Author

Error was like "Interop.AuraServiceLib.dll not found" or something. Research on internet said it was version conflict. I used various tools to figure out the conflict but none of them gave any clue. Difference between Aurora and Artemis was .net version and System.* dependencies. Removing System.Management from this library fixed my problem

@Aytackydln
Copy link
Contributor Author

Also, these changes made sense

@DarthAffe
Copy link
Owner

This doesn't make any sense - if the error is "Interop.AuraServiceLib.dll not found" then it normally is exactly this - sometimes aura does not correctly register it in the GAC, that's why artemis is distributing it.

@Aytackydln
Copy link
Contributor Author

Aytackydln commented Jun 15, 2023

I made sure to put the dll everywhere it can be found...

And this change fixes that

@DarthAffe
Copy link
Owner

yeah, but this change is also breaking device detection for some devices and i really can't see any relation between that dependency and the capability of finding a library.
can you provide a full error message and stacktrace for the error?

@DarthAffe
Copy link
Owner

from looking at it i'd say you have your version conflict in aurora as you're explicitely referencing 6.0.0 of System.Management, the provider uses 7.0.0.
i still don't see why that would cause in issue related to the interop lib but you'd need to generate binding redirects to fix that (or update the lib in aurora)

@Aytackydln
Copy link
Contributor Author

Well I'm out of arguments :)

@MesrineNathanael
Copy link

Thank you for your fix, it fixed the issue with the asus aura devices for me too, I was having the same issue as you had :)

@DarthAffe DarthAffe merged commit a26eaf9 into DarthAffe:Development Oct 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants