Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

初步实现Widget与完善英语翻译 #421

Merged
merged 7 commits into from
Oct 19, 2024
Merged

初步实现Widget与完善英语翻译 #421

merged 7 commits into from
Oct 19, 2024

Conversation

FengzihangCode
Copy link
Contributor

这个提交是作为#409的延续提交的，处理了#409提交时所提及的问题，并且继续完善了英语翻译
很抱歉拖了这么长时间 学校的事情太多了

@FengzihangCode
初步实现Widget与完善英语翻译
a079c9d 
这个提交是作为#409的延续提交的，处理了#409提交时所提及的问题，并且继续完善了英语翻译
@FengzihangCode
Copy link
Contributor Author

!Run check

@WindowsMEMZ WindowsMEMZ self-requested a review October 19, 2024 13:13
@FengzihangCode
Copy link
Contributor Author

The heck
是不是CI又出什么问题了

WindowsMEMZ
WindowsMEMZ requested changes Oct 19, 2024
View reviewed changes
.github/.DS_Store Outdated Show resolved Hide resolved
MeowWidget/AppIntent.swift Outdated Show resolved Hide resolved
MeowWidget/MeowWidgetLiveActivity.swift Outdated Show resolved Hide resolved
@FengzihangCode
Copy link
Contributor Author

Okay收到

@WindowsMEMZ
Copy link
Member

!Run check

Run check 操作由我来执行，先更改上面提到的问题。

@FengzihangCode
Copy link
Contributor Author

全部处理了

@WindowsMEMZ WindowsMEMZ self-requested a review October 19, 2024 13:28
WindowsMEMZ
WindowsMEMZ requested changes Oct 19, 2024
View reviewed changes
DarockBili.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved Outdated Show resolved Hide resolved
MeowWidget/AppIntent.swift Outdated Show resolved Hide resolved
MeowWidget/MeowWidgetLiveActivity.swift Outdated Show resolved Hide resolved
@FengzihangCode
Copy link
Contributor Author

不确定以后是否会使用这个文件 麻烦确认一下

@WindowsMEMZ
Copy link
Member

不确定以后是否会使用这个文件 麻烦确认一下

以后需要使用重新创建就行，不需要直接删掉。删除空代码文件不会产生任何影响。

@FengzihangCode
Copy link
Contributor Author

好的

@FengzihangCode
Copy link
Contributor Author

处理

@WindowsMEMZ
Copy link
Member

处理

Package.resolved 得加回来，不然 CI 编译不了，Resolve 一下 Package。

btw 以后更改完点一下 Re-request review 就行了

@FengzihangCode
Copy link
Contributor Author

已经添加Package.resolved了

WindowsMEMZ
WindowsMEMZ previously approved these changes Oct 19, 2024
View reviewed changes
@WindowsMEMZ
Copy link
Member

!Run check

@FengzihangCode
Copy link
Contributor Author

有问题（

@WindowsMEMZ
Copy link
Member 

/Users/runner/work/Darock-Bili/Darock-Bili/MeowWidget/MeowWidgetBundle.swift:26:9: error: cannot find 'MeowWidgetLiveActivity' in scope
        MeowWidgetLiveActivity()
        ^~~~~~~~~~~~~~~~~~~~~~

把这个移除掉。

@FengzihangCode
Copy link
Contributor Author

可以帮我看看什么地方fatal了吗？

@FengzihangCode
Copy link
Contributor Author

处理了

WindowsMEMZ
WindowsMEMZ previously approved these changes Oct 19, 2024
View reviewed changes
@WindowsMEMZ
Copy link
Member

!Run check

@WindowsMEMZ
Copy link
Member

!Run check

@WindowsMEMZ WindowsMEMZ merged commit 5da339e into Darock-Studio:main Oct 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WindowsMEMZ WindowsMEMZ WindowsMEMZ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FengzihangCode @WindowsMEMZ