Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opt: Optimized Video Player #399

Merged
merged 1 commit into from
Aug 20, 2024

opt: Optimized Video Player

8293450
Select commit
Loading
Failed to load commit list.
Merged

opt: Optimized Video Player #399

opt: Optimized Video Player
8293450
Select commit
Loading
Failed to load commit list.
Xcode Cloud / DarockBili | Analysis | Build - iOS succeeded Aug 20, 2024 in 9m 3s

91 warnings

Report Summary
Errors 0
Test Failures 0
Analysis Issues 0
Warnings 91

Details

91 Warnings

Details

  MeowBili/Others/SettingsView.swift:1176
      'onChange(of:perform:)' was deprecated in iOS 17.0: Use `onChange` with a two or zero parameter action closure instead.
  MeowBili/PersonalCenter/DownloadsView.swift:191
      Todo Violation: TODOs should be resolved (VideoCard refer to DownloadsVi...) (todo)
  MeowBili/UserDynamic/DynamicDetailView.swift:101
      'init(_:isActive:destination:)' was deprecated in watchOS 9.0: use NavigationLink(value:label:), or navigationDestination(isPresented:destination:), inside a NavigationStack or NavigationSplitView
  MeowBili/InMain/SearchView.swift:47
      'init(_:destination:isActive:)' was deprecated in watchOS 9.0: use NavigationLink(value:label:), or navigationDestination(isPresented:destination:), inside a NavigationStack or NavigationSplitView
  MeowBili/Others/PhoneFormatterExt.swift:31
      Comma Spacing Violation: There should be no space before and one after any comma (comma)
  MeowBili/Video/VideoPlayerView.swift:136
      'animation' was deprecated in iOS 15.0: Use withAnimation or animation(_:value:) instead.
  MeowBili/Extension/CodeExt.swift:194
      'responseJSON(queue:dataPreprocessor:emptyResponseCodes:emptyRequestMethods:options:completionHandler:)' is deprecated: responseJSON deprecated and will be removed in Alamofire 6. Use responseDecodable instead.
  MeowBili/Errors/NetwokFixView.swift:305
      Main actor-isolated property 'isTroubleshooting' can not be mutated from a Sendable closure; this is an error in the Swift 6 language mode
  MeowBili/PersonalCenter/UserDynamicListView.swift:156
      'init(_:isActive:destination:)' was deprecated in watchOS 9.0: use NavigationLink(value:label:), or navigationDestination(isPresented:destination:), inside a NavigationStack or NavigationSplitView
  MeowBili/GlobalView/CommentsView.swift:60
      'init(_:isActive:destination:)' was deprecated in watchOS 9.0: use NavigationLink(value:label:), or navigationDestination(isPresented:destination:), inside a NavigationStack or NavigationSplitView
  MeowBili/InMain/SearchView.swift:47
      'init(_:destination:isActive:)' was deprecated in iOS 16.0: use NavigationLink(value:label:), or navigationDestination(isPresented:destination:), inside a NavigationStack or NavigationSplitView
  MeowBili/Others/SwitchAccountView.swift:84
      Closure End Indentation Violation: Closure end should have the same indentation as the line that started it; expected 8, got 12 (closure_end_indentation)
  MeowBili/Others/SwitchAccountView.swift:99
      Empty Parentheses with Trailing Closure Violation: When using trailing closures, empty parentheses should be avoided after the method call (empty_parentheses_with_trailing_closure)
  MeowBili/Errors/NetwokFixView.swift:198
      Main actor-isolated property 'bilibiliAPIState' can not be mutated from a nonisolated context; this is an error in the Swift 6 language mode
  MeowBili/UserDynamic/DynamicDetailView.swift:215
      'init(_:isActive:destination:)' was deprecated in watchOS 9.0: use NavigationLink(value:label:), or navigationDestination(isPresented:destination:), inside a NavigationStack or NavigationSplitView
  MeowBili/Extension/CodeExt.swift:157
      Mutation of captured var 'retryCount' in concurrently-executing code; this is an error in the Swift 6 language mode
  MeowBili/Extension/UIExt.swift:98
      Capture of 'items' with non-sendable type '[NSItemProvider]' in an isolated closure; this is an error in the Swift 6 language mode
  MeowBili/PersonalCenter/UserDetailView.swift:1080
      'onChange(of:perform:)' was deprecated in watchOS 10.0: Use `onChange` with a two or zero parameter action closure instead.
  MeowBili/Extension/CodeExt.swift:156
      Reference to captured var 'retryCount' in concurrently-executing code; this is an error in the Swift 6 language mode
  MeowBili/Errors/NetwokFixView.swift:323
      Main actor-isolated property 'isTroubleshooting' can not be mutated from a Sendable function; this is an error in the Swift 6 language mode
  MeowBili/Extension/UIExt.swift:89
      'unarchiveTopLevelObjectWithData' was deprecated in iOS 12.0: Use unarchivedObject(ofClass:from:) instead
  MeowBili/Others/PhoneFormatterExt.swift:27
      Comma Spacing Violation: There should be no space before and one after any comma (comma)
  MeowBili/UserDynamic/UserDynamicMainView.swift:74
      'init(_:isActive:destination:)' was deprecated in iOS 16.0: use NavigationLink(value:label:), or navigationDestination(isPresented:destination:), inside a NavigationStack or NavigationSplitView
  MeowBili/Others/LoginView.swift:315
      'onChange(of:perform:)' was deprecated in iOS 17.0: Use `onChange` with a two or zero parameter action closure instead.
  MeowBili/Errors/NetwokFixView.swift:300
      Main actor-isolated property 'darockAPIState' can not be mutated from a Sendable closure; this is an error in the Swift 6 language mode
  MeowBili/UserDynamic/UserDynamicMainView.swift:195
      'init(_:isActive:destination:)' was deprecated in iOS 16.0: use NavigationLink(value:label:), or navigationDestination(isPresented:destination:), inside a NavigationStack or NavigationSplitView
  MeowBili/Errors/NetwokFixView.swift:183
      Main actor-isolated property 'darockAPIState' can not be mutated from a nonisolated context; this is an error in the Swift 6 language mode
  MeowBili/Others/PhoneFormatterExt.swift:78
      Comma Spacing Violation: There should be no space before and one after any comma (comma)
  MeowBili/PersonalCenter/FavoriteView.swift:88
      'unarchiveTopLevelObjectWithData' was deprecated in iOS 12.0: Use unarchivedObject(ofClass:from:) instead
  MeowBili/Errors/NetwokFixView.swift:181
      Main actor-isolated property 'darockAPIState' can not be mutated from a nonisolated context; this is an error in the Swift 6 language mode
  MeowBili/Others/SettingsView.swift:1395
      'onChange(of:perform:)' was deprecated in watchOS 10.0: Use `onChange` with a two or zero parameter action closure instead.
  MeowBili/Others/PhoneFormatterExt.swift:29
      Colon Spacing Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals (colon)
  MeowBili/Others/LoginView.swift:344
      'onChange(of:perform:)' was deprecated in iOS 17.0: Use `onChange` with a two or zero parameter action closure instead.
  MeowBili/Extension/UIExt.swift:108
      Capture of 'item' with non-sendable type 'NSItemProvider' in an isolated closure; this is an error in the Swift 6 language mode
  MeowBili/Others/LinkDetectText.swift:23
      Superfluous Disable Command Violation: SwiftLint rule 'trailing_whitespace' did not trigger a violation in the disabled region; remove the disable command (superfluous_disable_command)
  MeowBili/Others/LoginView.swift:306
      'onChange(of:perform:)' was deprecated in watchOS 10.0: Use `onChange` with a two or zero parameter action closure instead.
  The "validates_start_with_lowercase" configuration now expects a severity (warning or error). The boolean value 'true' will still enable it as an error. It is now deprecated and will be removed in a future release.
  MeowBili/Extension/CodeExt.swift:213
      'CC_MD5' was deprecated in watchOS 6.0: This function is cryptographically broken and should not be used in security contexts. Clients should migrate to SHA256 (or stronger).
  MeowBili/Errors/NetwokFixView.swift:298
      Main actor-isolated property 'darockAPIState' can not be mutated from a Sendable closure; this is an error in the Swift 6 language mode
  MeowBili/PersonalCenter/WatchLaterView.swift:66
      'unarchiveTopLevelObjectWithData' was deprecated in iOS 12.0: Use unarchivedObject(ofClass:from:) instead
  MeowBili/Others/PhoneFormatterExt.swift:25
      Colon Spacing Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals (colon)
  MeowBili/InMain/SearchView.swift:180
      'onChange(of:perform:)' was deprecated in iOS 17.0: Use `onChange` with a two or zero parameter action closure instead.
  MeowBili/Others/PhoneFormatterExt.swift:29
      Comma Spacing Violation: There should be no space before and one after any comma (comma)
  MeowBili/UserDynamic/UserDynamicMainView.swift:195
      'init(_:isActive:destination:)' was deprecated in watchOS 9.0: use NavigationLink(value:label:), or navigationDestination(isPresented:destination:), inside a NavigationStack or NavigationSplitView
  MeowBili/Extension/UIExt.swift:106
      Capture of 'items' with non-sendable type '[NSItemProvider]' in an isolated closure; this is an error in the Swift 6 language mode
  MeowBili/Extension/UIExt.swift:98
      Capture of 'items' with non-sendable type '[NSItemProvider]' in a `@Sendable` closure; this is an error in the Swift 6 language mode
  MeowBili/InMain/SearchView.swift:201
      'init(_:isActive:destination:)' was deprecated in watchOS 9.0: use NavigationLink(value:label:), or navigationDestination(isPresented:destination:), inside a NavigationStack or NavigationSplitView
  MeowBili/InMain/SearchView.swift:201
      'init(_:isActive:destination:)' was deprecated in iOS 16.0: use NavigationLink(value:label:), or navigationDestination(isPresented:destination:), inside a NavigationStack or NavigationSplitView
  MeowBili/UserDynamic/UserDynamicMainView.swift:140
      'init(_:isActive:destination:)' was deprecated in watchOS 9.0: use NavigationLink(value:label:), or navigationDestination(isPresented:destination:), inside a NavigationStack or NavigationSplitView
  MeowBili/Errors/NetwokFixView.swift:304
      Main actor-isolated property 'darockAPIState' can not be mutated from a Sendable closure; this is an error in the Swift 6 language mode
  MeowBili/PersonalCenter/UserDetailView.swift:243
      'init(_:isActive:destination:)' was deprecated in watchOS 9.0: use NavigationLink(value:label:), or navigationDestination(isPresented:destination:), inside a NavigationStack or NavigationSplitView
  MeowBili/Errors/NetwokFixView.swift:196
      Main actor-isolated property 'bilibiliAPIState' can not be mutated from a nonisolated context; this is an error in the Swift 6 language mode
  MeowBili/Others/LoginView.swift:323
      'onChange(of:perform:)' was deprecated in watchOS 10.0: Use `onChange` with a two or zero parameter action closure instead.
  MeowBili/Others/LoginView.swift:344
      'onChange(of:perform:)' was deprecated in watchOS 10.0: Use `onChange` with a two or zero parameter action closure instead.
  MeowBili/Extension/CodeExt.swift:78
      'CC_MD5' was deprecated in watchOS 6.0: This function is cryptographically broken and should not be used in security contexts. Clients should migrate to SHA256 (or stronger).
  MeowBili/Errors/NetwokFixView.swift:320
      Main actor-isolated property 'bilibiliAPIState' can not be mutated from a nonisolated context; this is an error in the Swift 6 language mode
  MeowBili/Errors/NetwokFixView.swift:201
      Main actor-isolated property 'isTroubleshooting' can not be mutated from a Sendable function; this is an error in the Swift 6 language mode
  MeowBili/PersonalCenter/HistoryView.swift:97
      'unarchiveTopLevelObjectWithData' was deprecated in iOS 12.0: Use unarchivedObject(ofClass:from:) instead
  MeowBili/GlobalView/CommentsView.swift:288
      'init(_:isActive:destination:)' was deprecated in iOS 16.0: use NavigationLink(value:label:), or navigationDestination(isPresented:destination:), inside a NavigationStack or NavigationSplitView
  MeowBili/Errors/NetwokFixView.swift:293
      Main actor-isolated property 'darockAPIState' can not be mutated from a Sendable function; this is an error in the Swift 6 language mode
  MeowBili/Others/LoginView.swift:315
      'onChange(of:perform:)' was deprecated in watchOS 10.0: Use `onChange` with a two or zero parameter action closure instead.
  MeowBili/Extension/CodeExt.swift:213
      'CC_MD5' was deprecated in iOS 13.0: This function is cryptographically broken and should not be used in security contexts. Clients should migrate to SHA256 (or stronger).
  MeowBili/Others/SwitchAccountView.swift:41
      Closure End Indentation Violation: Closure end should have the same indentation as the line that started it; expected 12, got 16 (closure_end_indentation)
  MeowBili/Video/AudioPlayerView.swift:340
      Closure End Indentation Violation: Closure end should have the same indentation as the line that started it; expected 4, got 8 (closure_end_indentation)
  MeowBili/PersonalCenter/UserDynamicListView.swift:75
      'init(_:isActive:destination:)' was deprecated in watchOS 9.0: use NavigationLink(value:label:), or navigationDestination(isPresented:destination:), inside a NavigationStack or NavigationSplitView
  MeowBili/PersonalCenter/FollowListView.swift:139
      'unarchiveTopLevelObjectWithData' was deprecated in iOS 12.0: Use unarchivedObject(ofClass:from:) instead
  MeowBili/Errors/NetwokFixView.swift:318
      Main actor-isolated property 'bilibiliAPIState' can not be mutated from a nonisolated context; this is an error in the Swift 6 language mode
  MeowBili/GlobalView/CommentsView.swift:288
      'init(_:isActive:destination:)' was deprecated in watchOS 9.0: use NavigationLink(value:label:), or navigationDestination(isPresented:destination:), inside a NavigationStack or NavigationSplitView
  MeowBili/MeowBiliApp.swift:242
      'init(_:isActive:destination:)' was deprecated in iOS 16.0: use NavigationLink(value:label:), or navigationDestination(isPresented:destination:), inside a NavigationStack or NavigationSplitView
  MeowBili/Extension/UIExt.swift:118
      Capture of 'items' with non-sendable type '[NSItemProvider]' in an isolated closure; this is an error in the Swift 6 language mode
  MeowBili/Errors/NetwokFixView.swift:192
      Concurrently-executed local function 'checkBilibili()' must be marked as '@Sendable'; this is an error in the Swift 6 language mode
  MeowBili/InMain/SearchView.swift:180
      'onChange(of:perform:)' was deprecated in watchOS 10.0: Use `onChange` with a two or zero parameter action closure instead.
  MeowBili/UserDynamic/UserDynamicMainView.swift:74
      'init(_:isActive:destination:)' was deprecated in watchOS 9.0: use NavigationLink(value:label:), or navigationDestination(isPresented:destination:), inside a NavigationStack or NavigationSplitView
  MeowBili/Errors/NetwokFixView.swift:315
      Main actor-isolated property 'bilibiliAPIState' can not be mutated from a Sendable function; this is an error in the Swift 6 language mode
  MeowBili/Extension/UIExt.swift:100
      Capture of 'item' with non-sendable type 'NSItemProvider' in a `@Sendable` closure; this is an error in the Swift 6 language mode
  MeowBili/Others/LinkDetectText.swift:73
      Todo Violation: FIXMEs should be resolved (The view commented shows empty...) (todo)
  MeowBili/Extension/UIExt.swift:120
      Capture of 'item' with non-sendable type 'NSItemProvider' in an isolated closure; this is an error in the Swift 6 language mode
  MeowBili/Others/SettingsView.swift:533
      'onChange(of:perform:)' was deprecated in iOS 17.0: Use `onChange` with a two or zero parameter action closure instead.
  MeowBili/Errors/NetwokFixView.swift:301
      Main actor-isolated property 'isTroubleshooting' can not be mutated from a Sendable closure; this is an error in the Swift 6 language mode
  MeowBili/Video/VideoDetailView.swift:170
      'onChange(of:perform:)' was deprecated in iOS 17.0: Use `onChange` with a two or zero parameter action closure instead.
  MeowBili/Errors/NetwokFixView.swift:186
      Main actor-isolated property 'darockAPIState' can not be mutated from a nonisolated context; this is an error in the Swift 6 language mode
  MeowBili/Others/LoginView.swift:323
      'onChange(of:perform:)' was deprecated in iOS 17.0: Use `onChange` with a two or zero parameter action closure instead.
  MeowBili/Extension/UIExt.swift:100
      Capture of 'item' with non-sendable type 'NSItemProvider' in an isolated closure; this is an error in the Swift 6 language mode
  MeowBili/Errors/NetwokFixView.swift:314
      Concurrently-executed local function 'checkBilibili()' must be marked as '@Sendable'; this is an error in the Swift 6 language mode
  MeowBili/GlobalView/CommentsView.swift:60
      'init(_:isActive:destination:)' was deprecated in iOS 16.0: use NavigationLink(value:label:), or navigationDestination(isPresented:destination:), inside a NavigationStack or NavigationSplitView
  MeowBili/Errors/NetwokFixView.swift:193
      Main actor-isolated property 'bilibiliAPIState' can not be mutated from a Sendable function; this is an error in the Swift 6 language mode
  MeowBili/Others/SettingsView.swift:1176
      'onChange(of:perform:)' was deprecated in watchOS 10.0: Use `onChange` with a two or zero parameter action closure instead.
  MeowBili/UserDynamic/UserDynamicMainView.swift:256
      'init(_:isActive:destination:)' was deprecated in watchOS 9.0: use NavigationLink(value:label:), or navigationDestination(isPresented:destination:), inside a NavigationStack or NavigationSplitView
  MeowBili/Errors/NetwokFixView.swift:177
      Main actor-isolated property 'darockAPIState' can not be mutated from a Sendable function; this is an error in the Swift 6 language mode
  MeowBili/Extension/CodeExt.swift:78
      'CC_MD5' was deprecated in iOS 13.0: This function is cryptographically broken and should not be used in security contexts. Clients should migrate to SHA256 (or stronger).
  MeowBili/Others/LoginView.swift:306
      'onChange(of:perform:)' was deprecated in iOS 17.0: Use `onChange` with a two or zero parameter action closure instead.

Annotations

Check notice on line 136 in MeowBili/Video/VideoPlayerView.swift

See this annotation in the file changed.

@xcode-cloud xcode-cloud / DarockBili | Analysis | Build - iOS

MeowBili/Video/VideoPlayerView.swift#L136

'animation' was deprecated in iOS 15.0: Use withAnimation or animation(_:value:) instead.