fix: dangling pointer in mission when saving character data #1183
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where characters would lose mission progress due to a dangling pointer in mission data.
This was proven by adding a logging message to the destructor of all CD tables which revealed that when crashing, the tables and all their data are destroyed first and then character data is saved. This causes all missions to enter a state where their pointers are dangling and character data will enter an invalid state.
This is a quick patch to get character save data stable and remove the dangling pointer.
Tested that previously, I would lose my mission progress with 3 clients in world
1251 1
every time on multiple characters and after the patch I would never lose save data.Image of save data with fragmented memory, as you can see, the missionID is a completely invalid number