Skip to content

Commit

Permalink
Remove localisation support from advancement titles (#21)
Browse files Browse the repository at this point in the history
Localisation of titles caused issues with generated criteria names. This could be exploited to earn prestige advancements multiple times.
  • Loading branch information
sam-kirby authored Apr 24, 2019
1 parent 3e57672 commit 315a3ca
Show file tree
Hide file tree
Showing 327 changed files with 335 additions and 660 deletions.
2 changes: 1 addition & 1 deletion src/config/triumph/script/amplified/amplified/root.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
setTranslatedTitle("advancement.amplified.amplified.root.title")
setTitle("Amplified")

setIcon(<minecraft:skull>)

Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
setTranslatedTitle("advancement.compactmachines.test.11x11x11.title")
setTitle("11x11x11")

setIcon(<compactmachines3:machine:4>)

Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
setTranslatedTitle("advancement.compactmachines.test.11x11x112.title")
setTitle("11x11x11")

setIcon(<compactmachines3:machine:4>)

Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
setTranslatedTitle("advancement.compactmachines.test.13x13x13.title")
setTitle("13x13x13")

setIcon(<compactmachines3:machine:5>)

Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
setTranslatedTitle("advancement.compactmachines.test.13x13x132.title")
setTitle("13x13x13")

setIcon(<compactmachines3:machine:5>)

Expand Down
2 changes: 1 addition & 1 deletion src/config/triumph/script/compactmachines/test/3x3x3.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
setTranslatedTitle("advancement.compactmachines.test.3x3x3.title")
setTitle("3x3x3")

setIcon(<compactmachines3:machine>)

Expand Down
2 changes: 1 addition & 1 deletion src/config/triumph/script/compactmachines/test/5x5x5.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
setTranslatedTitle("advancement.compactmachines.test.5x5x5.title")
setTitle("5x5x5")

setIcon(<compactmachines3:machine:1>)

Expand Down
2 changes: 1 addition & 1 deletion src/config/triumph/script/compactmachines/test/5x5x52.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
setTranslatedTitle("advancement.compactmachines.test.5x5x52.title")
setTitle("5x5x5")

setIcon(<compactmachines3:machine:1>)

Expand Down
2 changes: 1 addition & 1 deletion src/config/triumph/script/compactmachines/test/7x7x7.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
setTranslatedTitle("advancement.compactmachines.test.7x7x7.title")
setTitle("7x7x7")

setIcon(<compactmachines3:machine:2>)

Expand Down
2 changes: 1 addition & 1 deletion src/config/triumph/script/compactmachines/test/7x7x72.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
setTranslatedTitle("advancement.compactmachines.test.7x7x72.title")
setTitle("7x7x7")

setIcon(<compactmachines3:machine:2>)

Expand Down
2 changes: 1 addition & 1 deletion src/config/triumph/script/compactmachines/test/9x9x9.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
setTranslatedTitle("advancement.compactmachines.test.9x9x9.title")
setTitle("9x9x9")

setIcon(<compactmachines3:machine:3>)

Expand Down
2 changes: 1 addition & 1 deletion src/config/triumph/script/compactmachines/test/9x9x92.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
setTranslatedTitle("advancement.compactmachines.test.9x9x92.title")
setTitle("9x9x9")

setIcon(<compactmachines3:machine:3>)

Expand Down
2 changes: 1 addition & 1 deletion src/config/triumph/script/compactmachines/test/root.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
setTranslatedTitle("advancement.compactmachines.test.root.title")
setTitle("Compact Machines World")

setIcon(<compactmachines3:psd>)

Expand Down
2 changes: 1 addition & 1 deletion src/config/triumph/script/customized/customized/root.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
setTranslatedTitle("advancement.customized.customized.root.title")
setTitle("Customized")

setIcon(<minecraft:skull>)

Expand Down
2 changes: 1 addition & 1 deletion src/config/triumph/script/default/default/root.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
setTranslatedTitle("advancement.default.default.root.title")
setTitle("Default")

setIcon(<minecraft:skull>)

Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
setTranslatedTitle("advancement.hardcore.hardcore.forgivingvoid.title")
setTitle("Forgiving Void")

setIcon(<minecraft:elytra>)

Expand Down
2 changes: 1 addition & 1 deletion src/config/triumph/script/hardcore/hardcore/root.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
setTranslatedTitle("advancement.hardcore.hardcore.root.title")
setTitle("SkyFactory 4 Hardcore Mode")

setIcon(<minecraft:skull>)

Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
setTranslatedTitle("advancement.hardcore.hardcore.shell_constructor.title")
setTitle("A Syncing Feeling")

setIcon(<sync:item_shell_constructor>)

Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
setTranslatedTitle("advancement.hardcore.hardcore.shell_storage.title")
setTitle("Shell Script")

setIcon(<statues:blockpigstatue>)

Expand Down
2 changes: 1 addition & 1 deletion src/config/triumph/script/hardcore/hardcore/survive.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
setTranslatedTitle("advancement.hardcore.hardcore.survive.title")
setTitle("Through the Looking Glass")

setIcon(<cyclicmagic:soulstone>)

Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
setTranslatedTitle("advancement.large_biomes.large_biomes.root.title")
setTitle("Large Biomes")

setIcon(<minecraft:skull>)

Expand Down
2 changes: 1 addition & 1 deletion src/config/triumph/script/lost_cities/lost_cities/root.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
setTranslatedTitle("advancement.lost_cities.lost_cities.root.title")
setTitle("Lost Cities")

setIcon(<minecraft:skull>)

Expand Down
2 changes: 1 addition & 1 deletion src/config/triumph/script/pacifist/pacifist_run/lose.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
setTranslatedTitle("advancement.pacifist.pacifist_run.lose.title")
setTitle("You lose")

setIcon(<minecraft:iron_sword>)

Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
setTranslatedTitle("advancement.pacifist.pacifist_run.peaceful.title")
setTitle("Peaceful Mode On")

setIcon(<statues:blockspiderstatuet4>)

Expand Down
2 changes: 1 addition & 1 deletion src/config/triumph/script/pacifist/pacifist_run/root.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
setTranslatedTitle("advancement.pacifist.pacifist_run.root.title")
setTitle("Pacifist World")

setIcon(<minecraft:red_flower:8>)

Expand Down
2 changes: 1 addition & 1 deletion src/config/triumph/script/prestige/prestige/clock.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
setTranslatedTitle("advancement.prestige.prestige.clock.title")
setTitle("Back to the Future")

setIcon(<bibliocraft:clock>)

Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
setTranslatedTitle("advancement.prestige.prestige.energy_cube.title")
setTitle("Mr Fusion")

setIcon(<mekanism:energycube, nbt:{tier:1}>)

Expand Down
2 changes: 1 addition & 1 deletion src/config/triumph/script/prestige/prestige/parabox.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
setTranslatedTitle("advancement.prestige.prestige.parabox.title")
setTitle("Prestiging")

setIcon(<parabox:parabox>)

Expand Down
2 changes: 1 addition & 1 deletion src/config/triumph/script/prestige/prestige/root.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
setTranslatedTitle("advancement.prestige.prestige.root.title")
setTitle("Prestige")

setIcon(<parabox:parabox>)

Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
setTranslatedTitle("advancement.prestige.prestige.space_time_equalizer.title")
setTitle("The Flux Capacitor")

setIcon(<matteroverdrive:spacetime_equalizer>)

Expand Down
2 changes: 1 addition & 1 deletion src/config/triumph/script/projecte/projecte/root.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
setTranslatedTitle("advancement.projecte.projecte.root.title")
setTitle("ProjectE")

setIcon(<projecte:transmutation_table>)

Expand Down
2 changes: 1 addition & 1 deletion src/config/triumph/script/sf4/age1/acorn/dirt.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
setTranslatedTitle("advancement.sf4.age1.acorn.dirt.title")
setTitle("Starting from the Bottom")

setIcon(<sky_orchards:acorn_dirt>)

Expand Down
2 changes: 1 addition & 1 deletion src/config/triumph/script/sf4/age1/acorn/dirt_cooked.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
setTranslatedTitle("advancement.sf4.age1.acorn.dirt_cooked.title")
setTitle("Eating Dirt")

setIcon(<sky_orchards:acorn_dirt:1>)

Expand Down
2 changes: 1 addition & 1 deletion src/config/triumph/script/sf4/age1/amber/gold.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
setTranslatedTitle("advancement.sf4.age1.amber.gold.title")
setTitle("One Shiny Boi")

setIcon(<sky_orchards:amber_gold>)

Expand Down
2 changes: 1 addition & 1 deletion src/config/triumph/script/sf4/age1/amber/iron.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
setTranslatedTitle("advancement.sf4.age1.amber.iron.title")
setTitle("Amber is the Color of my Dinosaur")

setIcon(<sky_orchards:amber_iron>)

Expand Down
2 changes: 1 addition & 1 deletion src/config/triumph/script/sf4/age1/amber/lead.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
setTranslatedTitle("advancement.sf4.age1.amber.lead.title")
setTitle("Lead it Go")

setIcon(<sky_orchards:amber_lead>)

Expand Down
2 changes: 1 addition & 1 deletion src/config/triumph/script/sf4/age1/amber/silver.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
setTranslatedTitle("advancement.sf4.age1.amber.silver.title")
setTitle("Silver Surfer")

setIcon(<sky_orchards:amber_silver>)

Expand Down
2 changes: 1 addition & 1 deletion src/config/triumph/script/sf4/age1/amber/tin.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
setTranslatedTitle("advancement.sf4.age1.amber.tin.title")
setTitle("Tin Man")

setIcon(<sky_orchards:amber_tin>)

Expand Down
2 changes: 1 addition & 1 deletion src/config/triumph/script/sf4/age1/cauldron.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
setTranslatedTitle("advancement.sf4.age1.cauldron.title")
setTitle("Bubble, Bubble")

setIcon(<morecauldrons:oak_cauldron>)

Expand Down
2 changes: 1 addition & 1 deletion src/config/triumph/script/sf4/age1/clay_bucket.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
setTranslatedTitle("advancement.sf4.age1.clay_bucket.title")
setTitle("Slop in the Bucket")

setIcon(<ceramics:unfired_clay>)

Expand Down
2 changes: 1 addition & 1 deletion src/config/triumph/script/sf4/age1/coal.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
setTranslatedTitle("advancement.sf4.age1.coal.title")
setTitle("COALateral Damage")

setIcon(<minecraft:coal>)

Expand Down
2 changes: 1 addition & 1 deletion src/config/triumph/script/sf4/age1/cobblestone.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
setTranslatedTitle("advancement.sf4.age1.cobblestone.title")
setTitle("On the Rocks")

setIcon(<minecraft:cobblestone>)

Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
setTranslatedTitle("advancement.sf4.age1.cobblestone_generator.title")
setTitle("Cobble Cobble")

setIcon(<minecraft:cobblestone>)

Expand Down
2 changes: 1 addition & 1 deletion src/config/triumph/script/sf4/age1/complete.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
setTranslatedTitle("advancement.sf4.age1.complete.title")
setTitle("You Win!")

setIcon(<minecraft:cooked_chicken>)

Expand Down
2 changes: 1 addition & 1 deletion src/config/triumph/script/sf4/age1/completenoprestige.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
setTranslatedTitle("advancement.sf4.age1.completenoprestige.title")
setTitle("You Win!")

setIcon(<minecraft:cooked_chicken>)

Expand Down
2 changes: 1 addition & 1 deletion src/config/triumph/script/sf4/age1/crushing_tub.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
setTranslatedTitle("advancement.sf4.age1.crushing_tub.title")
setTitle("I Love Lucy")

setIcon(<rustic:crushing_tub>)

Expand Down
2 changes: 1 addition & 1 deletion src/config/triumph/script/sf4/age1/diamond.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
setTranslatedTitle("advancement.sf4.age1.diamond.title")
setTitle("Trees to Diamonds")

setIcon(<minecraft:diamond>)

Expand Down
2 changes: 1 addition & 1 deletion src/config/triumph/script/sf4/age1/dirt.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
setTranslatedTitle("advancement.sf4.age1.dirt.title")
setTitle("Dirty Dancing")

setIcon(<minecraft:dirt>)

Expand Down
2 changes: 1 addition & 1 deletion src/config/triumph/script/sf4/age1/drying_rack.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
setTranslatedTitle("advancement.sf4.age1.drying_rack.title")
setTitle("Air Fryer")

setIcon(<tconstruct:rack:1>)

Expand Down
2 changes: 1 addition & 1 deletion src/config/triumph/script/sf4/age1/green_slimy_dirt.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
setTranslatedTitle("advancement.sf4.age1.green_slimy_dirt.title")
setTitle("I've Been Slimed")

setIcon(<tconstruct:slime_dirt:0>)

Expand Down
2 changes: 1 addition & 1 deletion src/config/triumph/script/sf4/age1/iron_bucket.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
setTranslatedTitle("advancement.sf4.age1.iron_bucket.title")
setTitle("Not a Helmet")

setIcon(<minecraft:bucket>)

Expand Down
2 changes: 1 addition & 1 deletion src/config/triumph/script/sf4/age1/iron_ingot.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
setTranslatedTitle("advancement.sf4.age1.iron_ingot.title")
setTitle("Oh, the Irony")

setIcon(<minecraft:iron_ingot>)

Expand Down
2 changes: 1 addition & 1 deletion src/config/triumph/script/sf4/age1/lava.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
setTranslatedTitle("advancement.sf4.age1.lava.title")
setTitle("Hotbois")

setIcon(<minecraft:lava_bucket>)

Expand Down
2 changes: 1 addition & 1 deletion src/config/triumph/script/sf4/age1/lavasource.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
setTranslatedTitle("advancement.sf4.age1.lavasource.title")
setTitle("Get It While It's Hot")

setIcon(<tp:lava_block>)

Expand Down
2 changes: 1 addition & 1 deletion src/config/triumph/script/sf4/age1/nonpacifist.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
setTranslatedTitle("advancement.sf4.age1.nonpacifist.title")
setTitle("NonPacifist")

setIcon(<minecraft:cooked_porkchop>)

Expand Down
2 changes: 1 addition & 1 deletion src/config/triumph/script/sf4/age1/obsidian.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
setTranslatedTitle("advancement.sf4.age1.obsidian.title")
setTitle("Study in the Dark Arts")

setIcon(<minecraft:obsidian>)

Expand Down
2 changes: 1 addition & 1 deletion src/config/triumph/script/sf4/age1/prestige_notify.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
setTranslatedTitle("advancement.sf4.age1.prestige_notify.title")
setTitle("prestige_notify")

setIcon(<minecraft:sapling>)

Expand Down
2 changes: 1 addition & 1 deletion src/config/triumph/script/sf4/age1/resourcehogs.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
setTranslatedTitle("advancement.sf4.age1.resourcehogs.title")
setTitle("Hog Tied")

setIcon(<resourcehogs:mud_bucket, meta:0, count:1, nbt:{ResourceType:"cobblestone"}>)

Expand Down
2 changes: 1 addition & 1 deletion src/config/triumph/script/sf4/age1/root.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
setTranslatedTitle("advancement.sf4.age1.root.title")
setTitle("SkyFactory 4")

setIcon(<minecraft:sapling>)

Expand Down
2 changes: 1 addition & 1 deletion src/config/triumph/script/sf4/age1/sapling.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
setTranslatedTitle("advancement.sf4.age1.sapling.title")
setTitle("Tree Harder")

setIcon(<minecraft:sapling>)

Expand Down
2 changes: 1 addition & 1 deletion src/config/triumph/script/sf4/age1/sapling/bacon.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
setTranslatedTitle("advancement.sf4.age1.sapling.bacon.title")
setTitle("OinkTree")

setIcon(<sky_orchards:sapling_bacon>)

Expand Down
2 changes: 1 addition & 1 deletion src/config/triumph/script/sf4/age1/sapling/bone.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
setTranslatedTitle("advancement.sf4.age1.sapling.bone.title")
setTitle("Break a Leg")

setIcon(<sky_orchards:sapling_bone>)

Expand Down
2 changes: 1 addition & 1 deletion src/config/triumph/script/sf4/age1/sapling/clay.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
setTranslatedTitle("advancement.sf4.age1.sapling.clay.title")
setTitle("Clay Aiken")

setIcon(<sky_orchards:sapling_clay>)

Expand Down
2 changes: 1 addition & 1 deletion src/config/triumph/script/sf4/age1/sapling/coal.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
setTranslatedTitle("advancement.sf4.age1.sapling.coal.title")
setTitle("Sixteen Tons")

setIcon(<sky_orchards:sapling_coal>)

Expand Down
2 changes: 1 addition & 1 deletion src/config/triumph/script/sf4/age1/sapling/cottonwood.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
setTranslatedTitle("advancement.sf4.age1.sapling.cottonwood.title")
setTitle("You Cotton Be Kidding Me")

setIcon(<sky_orchards:sapling_cottonwood>)

Expand Down
2 changes: 1 addition & 1 deletion src/config/triumph/script/sf4/age1/sapling/diamond.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
setTranslatedTitle("advancement.sf4.age1.sapling.diamond.title")
setTitle("This Tree is Forever")

setIcon(<sky_orchards:sapling_diamond>)

Expand Down
Loading

0 comments on commit 315a3ca

Please sign in to comment.