[CODEREVIEW]

Co-authored-by: Stanislav Motylkov <[email protected]>
DarkFire01 · Oct 11, 2023 · db97f7a · db97f7a
1 parent a250e95
commit db97f7a
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/boot/freeldr/freeldr/arch/uefi/uefildr.c b/boot/freeldr/freeldr/arch/uefi/uefildr.c
@@ -78,8 +78,8 @@ ExecuteLoaderCleanly(PVOID PreviousStack)
 VOID __cdecl Reboot(VOID)
 {
     //TODO: Replace with a true firmware reboot eventually
-    WARN("Stopping freeloader something has gone wrong - Freezing");
-    for(;;)
+    WARN("Something has gone wrong - halting FreeLoader\n");
+    for (;;)
     {
         NOTHING;
     }

diff --git a/boot/freeldr/freeldr/arch/uefi/uefimem.c b/boot/freeldr/freeldr/arch/uefi/uefimem.c
@@ -238,7 +238,8 @@ UefiMemGetMemoryMap(ULONG *MemoryMapSize)
         MapEntry = NEXT_MEMORY_DESCRIPTOR(MapEntry, DescriptorSize);
     }
 
-    /* Reserve the first page, as on some UEFI systems it can be free */
+    /* Windows expects the first page to be reserved, otherwise it asserts.
+     * However it can be just a free page on some UEFI systems. */
     UefiSetMemory(FreeldrMem, 0x000000, 1, LoaderFirmwarePermanent);
     *MemoryMapSize = FreeldrDescCount;
     return FreeldrMem;