Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support 0x format in float #35

Merged
merged 1 commit into from
Aug 10, 2024
Merged

feat: support 0x format in float #35

merged 1 commit into from
Aug 10, 2024

Conversation

louiscaron
Copy link
Contributor

an official autosar tool is generating float values with this format.

@DanielT
Copy link
Owner

DanielT commented Aug 9, 2024

Thanks for the fix.
I will be happy to merge this, but at the moment the build is failing - it looks like one closing brace got lost.

@louiscaron
Copy link
Contributor Author

sorry about this, i made a mistake when applying the patch... i fixed the error now.

Copy link

codecov bot commented Aug 10, 2024

Codecov Report

Attention: Patch coverage is 64.70588% with 6 lines in your changes missing coverage. Please review.

Project coverage is 90.79%. Comparing base (fb99932) to head (e026b13).

Files Patch % Lines
a2lfile/src/parser.rs 64.70% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #35      +/-   ##
==========================================
- Coverage   90.80%   90.79%   -0.02%     
==========================================
  Files          27       27              
  Lines       37334    37344      +10     
==========================================
+ Hits        33901    33906       +5     
- Misses       3433     3438       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DanielT DanielT merged commit f0865ae into DanielT:main Aug 10, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants