This repository has been archived by the owner on Apr 25, 2020. It is now read-only.
Implement GHC version check warnings/errors #687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Still have to find a suitable place to actually perform the check so we don't have to do another call into cabal-helper (which is as slow as cabal configure because it has to read dist/setup-config)
DanielG
force-pushed
the
ghc-version-check
branch
from
f6e581a
to
eceb7e2
Compare
|
How about performing the check when command execution fails? Then we don't pay any overhead for the success case. |
|
Note that I have pretty much rewritten this now it's just not ready for committing yet so if anyone wants to work on this talk to me first. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still have to find a suitable place to actually perform the check so we
don't have to do another call into cabal-helper (which is as slow as
cabal configure because it has to read dist/setup-config)