Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Terminal Public Startpage #22

Merged
merged 12 commits into from
Jan 11, 2024
Merged

Feature: Terminal Public Startpage #22

merged 12 commits into from
Jan 11, 2024

Conversation

Chrinsieboy
Copy link
Collaborator

No description provided.

@Chrinsieboy Chrinsieboy added the enhancement New feature or request label Jan 10, 2024
@Chrinsieboy Chrinsieboy self-assigned this Jan 10, 2024
@Chrinsieboy Chrinsieboy changed the base branch from master to dev January 10, 2024 13:17
Huib8
Huib8 requested changes Jan 10, 2024
View reviewed changes
Copy link
Collaborator

@Huib8 Huib8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

paar veranderingen maken. comment weghalen en console log

DanericNetwork
DanericNetwork previously approved these changes Jan 11, 2024
View reviewed changes
src/resources/vue/components/Box.vue Outdated Show resolved Hide resolved
src/resources/vue/components/terminal-scan.vue Show resolved Hide resolved
@Chrinsieboy Chrinsieboy changed the title Feature: Startpage Feature: Terminal Public Startpage Jan 11, 2024
Timtendo12
Timtendo12 previously approved these changes Jan 11, 2024
View reviewed changes
Copy link
Collaborator

@Timtendo12 Timtendo12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Chrinsieboy Chrinsieboy dismissed stale reviews from Timtendo12 and DanericNetwork via 79444f7 January 11, 2024 13:07
Huib8
Huib8 previously approved these changes Jan 11, 2024
View reviewed changes
Timtendo12
Timtendo12 approved these changes Jan 11, 2024
View reviewed changes
Copy link
Collaborator

@Timtendo12 Timtendo12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Timtendo12
Timtendo12 approved these changes Jan 11, 2024
View reviewed changes
Copy link
Collaborator

@Timtendo12 Timtendo12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix NPM Build

Timtendo12
Timtendo12 requested changes Jan 11, 2024
View reviewed changes
Copy link
Collaborator

@Timtendo12 Timtendo12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fuck bedoelde request changes

@Chrinsieboy Chrinsieboy requested a review from Huib8 January 11, 2024 14:00
@Chrinsieboy Chrinsieboy merged commit 5cba4f9 into dev Jan 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanericNetwork DanericNetwork DanericNetwork approved these changes

@Timtendo12 Timtendo12 Timtendo12 approved these changes

@Huib8 Huib8 Awaiting requested review from Huib8

Assignees

@Chrinsieboy Chrinsieboy

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Chrinsieboy @Timtendo12 @DanericNetwork @Huib8