Add Haiku to OS detection logic. #185
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It must go before Linux because otherwise the "X11" check will misdetect Linux here. Right now, Haiku's native WebKit is detected as Safari since that's what the user-agent most specifically contains. It would probably make more sense to list the AppleWebKit version (the WebPositive/ version has not changed in years.) But at least we get the OS correct now.
|
The two added user-agent strings are real user-agents from WebPositive (HaikuWebKit) and Falkon (QtWebEngine) running on a recent Haiku x86_64 install. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It must go before Linux because otherwise the "X11" check will misdetect Linux here.
Right now, Haiku's native WebKit is detected as Safari since that's what the user-agent most specifically contains. It would probably make more sense to list the AppleWebKit version (the WebPositive/ version has not changed in years.) But at least we get the OS correct now.