Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for fetching flow run and task run logs #154

Merged
merged 2 commits into from
Sep 3, 2024

Conversation

huzaifmalik786
Copy link
Contributor

No description provided.

@Ishankoradia
Copy link
Contributor

Ishankoradia commented Aug 26, 2024

One task from the issue is still left to be done. @huzaifmalik786 please take a look at this #148
We need another api here to separate logs from the graph in get_flow_run_logs_v2.

Idea is to create a new api get_flow_run_graph which is exactly same as /proxy/flow_runs/v1/logs/{flow_run_id} but doesn't return the logs only the graph or you can set the logs to []

Were you planning to do it in another PR ?

@huzaifmalik786
Copy link
Contributor Author

huzaifmalik786 commented Aug 26, 2024

@Ishankoradia , I was assigned to this issue.
DalgoT4D/DDP_backend#789
So, this PR is for the changes mentioned in this particular ticket only.
Let's take up the issue mentioned above in another PR.

@Ishankoradia Ishankoradia merged commit fb7201a into DalgoT4D:main Sep 3, 2024
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants