Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configurable api endpoint #83

Merged
merged 4 commits into from
May 15, 2024
Merged

Conversation

fatchat
Copy link

@fatchat fatchat commented May 14, 2024

What

The Glific endpoint needs to be user-configurable
The default endpoint is no longer with cctides

How

Added a field to the source configuration form

Review guide

User Impact

Anyone using this connector will see their requests going to https://api.staging.glific.com/api instead of to the older CCTides endpoint which no longer works anyway

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

escaped the backslashes and the dash
@fatchat fatchat had a problem deploying to community-ci-auto May 14, 2024 08:54 — with GitHub Actions Failure
@fatchat fatchat had a problem deploying to community-ci-auto May 14, 2024 08:55 — with GitHub Actions Failure
@fatchat fatchat requested a review from siddhant3030 May 14, 2024 08:55
@siddhant3030 siddhant3030 merged commit 8820263 into feature/source_glific May 15, 2024
9 of 15 checks passed
@fatchat fatchat deleted the configurable-endpoint branch May 31, 2024 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants