Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

76 multiple base url for avni #77

Merged
merged 1 commit into from
Apr 13, 2024

Conversation

fatchat
Copy link

@fatchat fatchat commented Apr 13, 2024

What

Added a "Base URL" field to the Avni connector setup form

How

Added fields to the manifest.yaml
Referenced the url_base field in CustomAuthenticator to fetch the token from the correct IDP endpoint

🚨 User Impact 🚨

Existing source connectors need to be updated with their relevant Base URLs

@fatchat fatchat linked an issue Apr 13, 2024 that may be closed by this pull request
@fatchat fatchat requested a review from siddhant3030 April 13, 2024 10:26
Copy link

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@fatchat fatchat changed the base branch from master to feature/lowcode_avni April 13, 2024 10:27
@siddhant3030
Copy link
Collaborator

looks good to me

@fatchat fatchat merged commit 9a0152e into feature/lowcode_avni Apr 13, 2024
5 of 11 checks passed
@fatchat fatchat deleted the 76-multiple-base-url-for-avni branch April 13, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple base url for AVNI
2 participants