Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix full-refresh syncs #107

Conversation

fatchat
Copy link

@fatchat fatchat commented Sep 15, 2024

Don't update the cursor in read_records unless the sync mode is incremental

The changes inside state, mk_query and request_params are just for pylint, no functional changes there

@fatchat
Copy link
Author

fatchat commented Sep 15, 2024

Before this change, full-refresh

image

After this change, full-refresh

image

Important: This command can only be run by one of the repository admins:
Usage: ./tools/bin/get_repo_admins.sh <personal_access_token>

@fatchat
Copy link
Author

fatchat commented Sep 15, 2024

After this change, incremental still works

image

Important: This command can only be run by one of the repository admins:
Usage: ./tools/bin/get_repo_admins.sh <personal_access_token>

@fatchat fatchat merged commit 69c7bb4 into feature/source_kobo_tool Sep 15, 2024
9 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant