Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[호돌이] Week5 #876

Merged
merged 4 commits into from
Jan 12, 2025
Merged

[호돌이] Week5 #876

merged 4 commits into from
Jan 12, 2025

Conversation

yeeZinu
Copy link
Contributor

@yeeZinu yeeZinu commented Jan 10, 2025

답안 제출 문제

체크 리스트

  • 우측 메뉴에서 PR을 Projects에 추가해주세요.
  • Projects의 오른쪽 버튼(▼)을 눌러 확장한 뒤, Week를 현재 주차로 설정해주세요.
  • 바로 앞에 PR을 열어주신 분을 코드 검토자로 지정해주세요.
  • 문제를 모두 푸시면 프로젝트에서 StatusIn Review로 설정해주세요.
  • 코드 검토자 1분 이상으로부터 승인을 받으셨다면 PR을 병합해주세요.

@yeeZinu yeeZinu added the js label Jan 10, 2025
@yeeZinu yeeZinu self-assigned this Jan 10, 2025
@yeeZinu yeeZinu requested a review from a team as a code owner January 10, 2025 11:57
@yeeZinu yeeZinu requested a review from pmjuu January 10, 2025 11:58
@yeeZinu yeeZinu changed the title best-time-to-buy-and-sell-stock solution [호돌이] Week5 Jan 10, 2025
Copy link
Contributor

@HC-kang HC-kang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

안녕하세요 @yeeZinu 님~ 코멘트가 굉장히 상세해서 좋네요.
다만, 가능하시다면 복잡도 분석도 한번씩 추가해주시면 스터디에서 더 많은것을 얻어가실 수 있지 않을까 싶어요.
아직 solving중이시지만 우선 승인 드리겠습니다!

* obj.insert(word)
* var param_2 = obj.search(word)
* var param_3 = obj.startsWith(prefix)
*/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이 부분에 개행문자가 누락되어있는 것 같아요.
개행문자 추가 후에도 혹시 통합 워크플로우에 문제가 있다면 디스코드나 코멘트 남겨주세요!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

줄바꿈이 누락되어 통합테스트가 실패하고 있습니다! 수정하고 push부탁드립니다! @yeeZinu

@yeeZinu yeeZinu merged commit 4039896 into DaleStudy:main Jan 12, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Completed
Development

Successfully merging this pull request may close these issues.

3 participants